Changeset 269894 in webkit
- Timestamp:
- Nov 17, 2020 12:22:08 AM (3 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r269888 r269894 1 2020-11-17 Rob Buis <rbuis@igalia.com> 2 3 Check whether destination still can be selected 4 https://bugs.webkit.org/show_bug.cgi?id=218491 5 6 Reviewed by Ryosuke Niwa. 7 8 Add testcase. 9 10 * editing/deleting/delete-selection-crash-expected.txt: Added. 11 * editing/deleting/delete-selection-crash.html: Added. 12 1 13 2020-11-16 Sam Weinig <weinig@apple.com> 2 14 -
trunk/Source/WebCore/ChangeLog
r269893 r269894 1 2020-11-17 Rob Buis <rbuis@igalia.com> 2 3 Check whether destination still can be selected 4 https://bugs.webkit.org/show_bug.cgi?id=218491 5 6 Reviewed by Ryosuke Niwa. 7 8 Check whether destination still can be selected 9 after deletion. 10 11 Test: editing/deleting/delete-selection-crash.html 12 13 * editing/CompositeEditCommand.cpp: 14 (WebCore::CompositeEditCommand::moveParagraphs): 15 1 16 2020-11-16 Kimmo Kinnunen <kkinnunen@apple.com> 2 17 -
trunk/Source/WebCore/editing/CompositeEditCommand.cpp
r269609 r269894 1459 1459 1460 1460 // FIXME (Bug 211793): We should redesign cleanupAfterDeletion or find another destination when it is removed. 1461 if (!destination.deepEquivalent().anchorNode()->isConnected() )1461 if (!destination.deepEquivalent().anchorNode()->isConnected() || VisibleSelection(destination, originalIsDirectional).isNone()) 1462 1462 return; 1463 1463
Note: See TracChangeset
for help on using the changeset viewer.