Changeset 269911 in webkit

Timestamp:

Nov 17, 2020 9:56:44 AM (3 years ago)

Author:

Brent Fulgham

Message:

[macOS] Remove access to the unused AppleSNBFBUserClient IOKit class
​https://bugs.webkit.org/show_bug.cgi?id=219014
<rdar://problem/70463873>

Reviewed by Eric Carlson.

Although we originally thought this was needed for H.264 decoding, testing shows
that this class is never used in WebKit flows, and is not needed. We should remove it.

• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
• WebProcess/com.apple.WebProcess.sb.in:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (modified) (1 diff)
• WebProcess/com.apple.WebProcess.sb.in (modified) (3 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-11-17  Brent Fulgham  <bfulgham@apple.com>
+
+        [macOS] Remove access to the unused AppleSNBFBUserClient IOKit class
+        https://bugs.webkit.org/show_bug.cgi?id=219014
+        <rdar://problem/70463873>
+
+        Reviewed by Eric Carlson.
+
+        Although we originally thought this was needed for H.264 decoding, testing shows
+        that this class is never used in WebKit flows, and is not needed. We should remove it.
+
+        * GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
+        * WebProcess/com.apple.WebProcess.sb.in:
+
 2020-11-17  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in

@@ -118 +118 @@
     (allow iokit-open
         (iokit-registry-entry-class "IOFramebufferSharedUserClient"))
+#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101500
     ;; H.264 Acceleration
     (allow iokit-open
-#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101500
         (iokit-registry-entry-class "AppleIntelMEUserClient")
-#endif
         (iokit-registry-entry-class "AppleSNBFBUserClient"))
+#endif
     ;; QuartzCore
     (allow iokit-open

trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

@@ -172 +172 @@
         (iokit-registry-entry-class "IOFramebufferSharedUserClient"))
 #endif
+#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101500
     ;; H.264 Acceleration
-#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101500
     (allow iokit-open
         (iokit-registry-entry-class "AppleIntelMEUserClient")
@@ -189 +189 @@
 #endif
     )
-#endif
     (allow iokit-open
         (iokit-registry-entry-class "AppleSNBFBUserClient")
@@ -205 +204 @@
 #endif
     )
+#endif
     ;; QuartzCore
     (allow iokit-open