Changeset 269928 in webkit


Ignore:
Timestamp:
Nov 17, 2020 3:30:08 PM (3 years ago)
Author:
Chris Dumez
Message:

[macOS] Stop using RunLoopType=_WebKit starting in Big Sur
​https://bugs.webkit.org/show_bug.cgi?id=219052
<rdar://problem/61742969>

Reviewed by Geoffrey Garen.

Stop using RunLoopType=_WebKit starting in Big Sur. This was a temporary hack so that our WebProcesses would get the right
scheduling priority. Starting with Big Sur, the right way to do this is to use _ProcessType=App and restore the RunLoopType
to be NSRunLoop.

After this change, I have verified that the WebContent's main thread still runs at UserInteractive QoS. App Nap is also
still working as expected.

  • Configurations/WebContentService.xcconfig:
  • WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist:
Location:
trunk/Source/WebKit
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r269924 r269928  
     12020-11-17  Chris Dumez  <cdumez@apple.com>
     2
     3        [macOS] Stop using RunLoopType=_WebKit starting in Big Sur
     4        https://bugs.webkit.org/show_bug.cgi?id=219052
     5        <rdar://problem/61742969>
     6
     7        Reviewed by Geoffrey Garen.
     8
     9        Stop using RunLoopType=_WebKit starting in Big Sur. This was a temporary hack so that our WebProcesses would get the right
     10        scheduling priority. Starting with Big Sur, the right way to do this is to use _ProcessType=App and restore the RunLoopType
     11        to be NSRunLoop.
     12
     13        After this change, I have verified that the WebContent's main thread still runs at UserInteractive QoS. App Nap is also
     14        still working as expected.
     15
     16        * Configurations/WebContentService.xcconfig:
     17        * WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist:
     18
    1192020-11-17  Per Arne Vollan  <pvollan@apple.com>
    220

  • trunk/Source/WebKit/Configurations/WebContentService.xcconfig

    r262801 r269928  
    4848WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG_YES = $(USE_STAGING_INSTALL_PATH);
    4949
    50 RUNLOOP_TYPE = $(RUNLOOP_TYPE$(WK_MACOS_1014));
    51 RUNLOOP_TYPE_MACOS_BEFORE_1014 = _NSApplicationMain;
    52 RUNLOOP_TYPE_MACOS_SINCE_1014 = _WebKit;
     50RUNLOOP_TYPE = $(RUNLOOP_TYPE$(WK_MACOS_1016));
     51RUNLOOP_TYPE_MACOS_BEFORE_1016 = _WebKit;
     52RUNLOOP_TYPE_MACOS_SINCE_1016 = NSRunLoop;
    5353
    5454ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))

  • trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist

    r269777 r269928  
    4747                <key>RunLoopType</key>
    4848                <string>${RUNLOOP_TYPE}</string>
     49                <key>_ProcessType</key>
     50                <string>App</string>
    4951                <key>_MultipleInstances</key>
    5052                <true/>
Note: See TracChangeset for help on using the changeset viewer.