Changeset 269938 in webkit

Timestamp:

Nov 17, 2020 5:31:05 PM (3 years ago)

Author:

Alan Bujtas

Message:

REGRESSION (r269744): ASSERTION FAILED: m_hasValidContentHeight in WebCore::Layout::BoxGeometry::contentBoxHeight()
​https://bugs.webkit.org/show_bug.cgi?id=219004
<rdar://problem/71459284>

Reviewed by Antti Koivisto.

Unfortunately we have to disable all percentage height/width content until after the integration codepath is fixed.
(in this case, the layout code assumes that percentage height values can always be resolved by climbing up on the
ancestor chain -worst case scenario we find the ICB which always has fixed height value.
However the integration codepath does not set the height on the fake ICB (RenderBlockFlow) even when the flow's height
is fixed and the IFC code can't climb farther up on the tree)

• layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForChild):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/integration/LayoutIntegrationCoverage.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-17  Zalan Bujtas  <zalan@apple.com>
+
+        REGRESSION (r269744): ASSERTION FAILED: m_hasValidContentHeight in WebCore::Layout::BoxGeometry::contentBoxHeight()
+        https://bugs.webkit.org/show_bug.cgi?id=219004
+        <rdar://problem/71459284>
+
+        Reviewed by Antti Koivisto.
+
+        Unfortunately we have to disable all percentage height/width content until after the integration codepath is fixed.
+        (in this case, the layout code assumes that percentage height values can always be resolved by climbing up on the
+        ancestor chain -worst case scenario we find the ICB which always has fixed height value.
+        However the integration codepath does not set the height on the fake ICB (RenderBlockFlow) even when the flow's height
+        is fixed and the IFC code can't climb farther up on the tree)
+
+        * layout/integration/LayoutIntegrationCoverage.cpp:
+        (WebCore::LayoutIntegration::canUseForChild):
+
 2020-11-17  Megan Gardner  <megan_gardner@apple.com>
 

trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

@@ -584 +584 @@
         if (style.verticalAlign() == VerticalAlign::Sub || style.verticalAlign() == VerticalAlign::Super)
             return false;
-        auto& width = style.width();
-        auto& height = style.height();
-        if (width.isPercent() || height.isPercent())
+        if (style.width().isPercent() || style.height().isPercent())
             return false;
-        if (width.isAuto() && (style.minWidth().isPercent() || style.maxWidth().isPercent()))
+        if (style.minWidth().isPercent() || style.maxWidth().isPercent())
             return false;
-        if (height.isAuto() && (style.minHeight().isPercent() || style.maxHeight().isPercent()))
+        if (style.minHeight().isPercent() || style.maxHeight().isPercent())
             return false;
         return true;