Changeset 269992 in webkit

Timestamp:

Nov 18, 2020 2:50:36 PM (3 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] Add timeout to network requests
​https://bugs.webkit.org/show_bug.cgi?id=218994

Reviewed by Jonathan Bedard.

• CISupport/ews-build/steps.py:

(BugzillaMixin.fetch_data_from_url_with_authentication): Added timeout to requests.get() call.
(BugzillaMixin.fetch_data_from_url): Ditto.
(ValidateCommiterAndReviewer.load_contributors_from_trac): Ditto.
(CheckPatchStatusOnEWSQueues.get_patch_status): Ditto.

Location:

trunk/Tools

Files:

• CISupport/ews-build/steps.py (modified) (4 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/CISupport/ews-build/steps.py

@@ -400 +400 @@
         response = None
         try:
-            response = requests.get(url, params={'Bugzilla_api_key': self.get_bugzilla_api_key()})
+            response = requests.get(url, timeout=60, params={'Bugzilla_api_key': self.get_bugzilla_api_key()})
             if response.status_code != 200:
                 self._addToLog('stdio', 'Accessed {url} with unexpected status code {status_code}.\n'.format(url=url, status_code=response.status_code))
@@ -413 +413 @@
         response = None
         try:
-            response = requests.get(url)
+            response = requests.get(url, timeout=60)
         except Exception as e:
             if response:
@@ -740 +740 @@
     def load_contributors_from_trac(self):
         try:
-            response = requests.get(self.url)
+            response = requests.get(self.url, timeout=60)
             if response.status_code != 200:
                 self._addToLog('stdio', 'Failed to access {} with status code: {}\n'.format(self.url, response.status_code))
@@ -3054 +3054 @@
         url = '{}status/{}'.format(EWS_URL, patch_id)
         try:
-            response = requests.get(url)
+            response = requests.get(url, timeout=60)
             if response.status_code != 200:
                 self._addToLog('stdio', 'Failed to access {} with status code: {}\n'.format(url, response.status_code))

trunk/Tools/ChangeLog

@@ +1 @@
+2020-11-18  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Add timeout to network requests
+        https://bugs.webkit.org/show_bug.cgi?id=218994
+
+        Reviewed by Jonathan Bedard.
+
+        * CISupport/ews-build/steps.py:
+        (BugzillaMixin.fetch_data_from_url_with_authentication): Added timeout to requests.get() call.
+        (BugzillaMixin.fetch_data_from_url): Ditto.
+        (ValidateCommiterAndReviewer.load_contributors_from_trac): Ditto.
+        (CheckPatchStatusOnEWSQueues.get_patch_status): Ditto.
+
 2020-11-18  Keith Rollin  <krollin@apple.com>