Changeset 270026 in webkit

Timestamp:

Nov 19, 2020 6:18:29 AM (3 years ago)

Author:

Alan Bujtas

Message:

[LFC][Integration] Allow subpixel difference in the computed containing block height when switching between line layout systems
​https://bugs.webkit.org/show_bug.cgi?id=219143

Reviewed by Antti Koivisto.

With all the seemingly random flooring, ceiling and rounding in the legacy line layout codebase,
it's really difficult to subpixel match the end result in a sane way in IFC as we start supporting more complex content.

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::ensureLineBoxes):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBlockFlow.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-19  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][Integration] Allow subpixel difference in the computed containing block height when switching between line layout systems
+        https://bugs.webkit.org/show_bug.cgi?id=219143
+
+        Reviewed by Antti Koivisto.
+
+        With all the seemingly random flooring, ceiling and rounding in the legacy line layout codebase,
+        it's really difficult to subpixel match the end result in a sane way in IFC as we start supporting more complex content.
+
+        * rendering/RenderBlockFlow.cpp:
+        (WebCore::RenderBlockFlow::ensureLineBoxes):
+
 2020-11-19  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/rendering/RenderBlockFlow.cpp

@@ -3688 +3688 @@
 
     updateLogicalHeight();
-    ASSERT(didNeedLayout || logicalHeight() == oldHeight);
+    ASSERT(didNeedLayout || ceilf(logicalHeight()) == ceilf(oldHeight));
 
     if (!didNeedLayout)