Changeset 270027 in webkit

Timestamp:

Nov 19, 2020 6:19:36 AM (3 years ago)

Author:

Alan Bujtas

Message:

[LFC][Integration] Disable non-text content with floats
​https://bugs.webkit.org/show_bug.cgi?id=219122

Reviewed by Antti Koivisto.

Non-text content may stretch the line and we don't yet have support for dynamic float avoiding (as the line grows).

• layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/integration/LayoutIntegrationCoverage.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-19  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][Integration] Disable non-text content with floats
+        https://bugs.webkit.org/show_bug.cgi?id=219122
+
+        Reviewed by Antti Koivisto.
+
+        Non-text content may stretch the line and we don't yet have support for dynamic float avoiding (as the line grows).
+
+        * layout/integration/LayoutIntegrationCoverage.cpp:
+        (WebCore::LayoutIntegration::canUseForLineLayoutWithReason):
+
 2020-11-19  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

@@ -713 +713 @@
     // The <blockflow><inline>#text</inline></blockflow> case is also popular and should be relatively easy to cover.
     for (const auto* child = flow.firstChild(); child; child = child->nextSibling()) {
+        if (!is<RenderText>(*child) && flow.containsFloats()) {
+            // Non-text content may stretch the line and we don't yet have support for dynamic float avoiding (as the line grows).
+            SET_REASON_AND_RETURN_IF_NEEDED(FlowHasUnsupportedFloat, reasons, includeReasons);
+        }
         auto childReasons = canUseForChild(*child, includeReasons);
         if (childReasons)