Changeset 270041 in webkit

Timestamp:

Nov 19, 2020 11:51:58 AM (3 years ago)

Author:

Andres Gonzalez

Message:

Fix for crash in Accessibility::performFunctionOnMainThread.
​https://bugs.webkit.org/show_bug.cgi?id=219168

Reviewed by Chris Fleizach.

AXIsolatedObject::performFunctionOnMainThread captures the this pointer
to be accessed on the main thread. But since the same object can be
accessed concurrently on the AX thread, Accessibility::performFunctionOnMainThread
must be blocking even though the caller doesn't expect a return value.

• accessibility/AccessibilityObjectInterface.h:

(WebCore::Accessibility::performFunctionOnMainThread):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AccessibilityObjectInterface.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-19  Andres Gonzalez  <andresg_22@apple.com>
+
+        Fix for crash in Accessibility::performFunctionOnMainThread.
+        https://bugs.webkit.org/show_bug.cgi?id=219168
+
+        Reviewed by Chris Fleizach.
+
+        AXIsolatedObject::performFunctionOnMainThread captures the this pointer
+        to be accessed on the main thread. But since the same object can be
+        accessed concurrently on the AX thread, Accessibility::performFunctionOnMainThread
+        must be blocking even though the caller doesn't expect a return value.
+
+        * accessibility/AccessibilityObjectInterface.h:
+        (WebCore::Accessibility::performFunctionOnMainThread):
+
 2020-11-19  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h

@@ -1560 +1560 @@
         return lambda();
 
-    callOnMainThread([&lambda] {
+    callOnMainThreadAndWait([&lambda] {
         lambda();
     });