Changeset 270046 in webkit


Ignore:
Timestamp:
Nov 19, 2020 12:51:35 PM (3 years ago)
Author:
Chris Dumez
Message:

Unable to fetch an audio worklet module using a data URL
https://bugs.webkit.org/show_bug.cgi?id=219166

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test now that one more check is passing.

  • web-platform-tests/worklets/audio-worklet-import.https-expected.txt:

Source/WebCore:

Allow fetching an audio worklet module using a data URL.

No new tests, rebaselined existing test.

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadAsynchronously):

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/imported/w3c/ChangeLog

    r270045 r270046  
     12020-11-19  Chris Dumez  <cdumez@apple.com>
     2
     3        Unable to fetch an audio worklet module using a data URL
     4        https://bugs.webkit.org/show_bug.cgi?id=219166
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Rebaseline WPT test now that one more check is passing.
     9
     10        * web-platform-tests/worklets/audio-worklet-import.https-expected.txt:
     11
    1122020-11-19  Chris Dumez  <cdumez@apple.com>
    213
  • trunk/LayoutTests/imported/w3c/web-platform-tests/worklets/audio-worklet-import.https-expected.txt

    r270033 r270046  
    1111PASS Importing a blob URL should resolve the given promise.
    1212PASS Importing a file:// URL should reject the given promise.
    13 FAIL Importing a data URL should resolve the given promise. promise_test: Unhandled rejection with value: object "AbortError: Failed to fetch module, error: Cross origin requests are only supported for HTTP."
     13PASS Importing a data URL should resolve the given promise.
    1414PASS Importing about:blank should reject the given promise.
    1515PASS Importing a cross origin resource with the Access-Control-Allow-Origin header should resolve the given promise
  • trunk/Source/WebCore/ChangeLog

    r270044 r270046  
     12020-11-19  Chris Dumez  <cdumez@apple.com>
     2
     3        Unable to fetch an audio worklet module using a data URL
     4        https://bugs.webkit.org/show_bug.cgi?id=219166
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Allow fetching an audio worklet module using a data URL.
     9
     10        No new tests, rebaselined existing test.
     11
     12        * workers/WorkerScriptLoader.cpp:
     13        (WebCore::WorkerScriptLoader::loadAsynchronously):
     14
    1152020-11-19  Zalan Bujtas  <zalan@apple.com>
    216
  • trunk/Source/WebCore/workers/WorkerScriptLoader.cpp

    r268872 r270046  
    130130    if (fetchOptions.destination == FetchOptions::Destination::Serviceworker)
    131131        options.certificateInfoPolicy = CertificateInfoPolicy::IncludeCertificateInfo;
     132
     133    // FIXME: We should drop the sameOriginDataURLFlag flag and implement the latest Fetch specification.
     134    if (fetchOptions.destination != FetchOptions::Destination::Worker)
     135        options.sameOriginDataURLFlag = SameOriginDataURLFlag::Set;
     136
    132137    // A service worker job can be executed from a worker context or a document context.
    133138    options.serviceWorkersMode = serviceWorkerMode;
Note: See TracChangeset for help on using the changeset viewer.