Changeset 270060 in webkit

Timestamp:

Nov 19, 2020 5:05:08 PM (3 years ago)

Author:

Chris Dumez

Message:

Web Inspector: Unable to Show JavaScript Console in empty tab in Safari Technology Preview
​https://bugs.webkit.org/show_bug.cgi?id=211590
<rdar://problem/63000159>

Reviewed by Simon Fraser.

We used to launch the initial process for the inspected page from inside
WebInspectorProxy::connect(). I thought this was a good bottleneck to
make sure the inspected page has a process to inspect.

However, while WebInspectorProxy::connect() gets called by functions by
WebInspectorProxy::show(), it does not get called by
WebInspectorProxy::showConsole() for example.

To address this, I have moved the code that launches the inspected page's
initial process from WebInspectorProxy::connect() to
WebInspectorProxy::createFrontendPage(). This seems like a much better
bottleneck.

• UIProcess/Inspector/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::connect):
(WebKit::WebInspectorProxy::createFrontendPage):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Inspector/WebInspectorProxy.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-11-19  Chris Dumez  <cdumez@apple.com>
+
+        Web Inspector: Unable to Show JavaScript Console in empty tab in Safari Technology Preview
+        https://bugs.webkit.org/show_bug.cgi?id=211590
+        <rdar://problem/63000159>
+
+        Reviewed by Simon Fraser.
+
+        We used to launch the initial process for the inspected page from inside
+        WebInspectorProxy::connect(). I thought this was a good bottleneck to
+        make sure the inspected page has a process to inspect.
+
+        However, while WebInspectorProxy::connect() gets called by functions by
+        WebInspectorProxy::show(), it does not get called by
+        WebInspectorProxy::showConsole() for example.
+
+        To address this, I have moved the code that launches the inspected page's
+        initial process from WebInspectorProxy::connect() to
+        WebInspectorProxy::createFrontendPage(). This seems like a much better
+        bottleneck.
+
+        * UIProcess/Inspector/WebInspectorProxy.cpp:
+        (WebKit::WebInspectorProxy::connect):
+        (WebKit::WebInspectorProxy::createFrontendPage):
+
 2020-11-19  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp

@@ -144 +144 @@
     createFrontendPage();
 
-    m_inspectedPage->launchInitialProcessIfNecessary();
     m_inspectedPage->send(Messages::WebInspectorInterruptDispatcher::NotifyNeedDebuggerBreak(), 0);
     m_inspectedPage->send(Messages::WebInspector::Show());
@@ -421 +420 @@
     trackInspectorPage(m_inspectorPage, m_inspectedPage);
 
+    // Make sure the inspected page has a running WebProcess so we can inspect it.
+    m_inspectedPage->launchInitialProcessIfNecessary();
+
     m_inspectorPage->process().addMessageReceiver(Messages::WebInspectorProxy::messageReceiverName(), m_inspectedPage->identifier(), *this);
     m_inspectorPage->process().assumeReadAccessToBaseURL(*m_inspectorPage, WebInspectorProxy::inspectorBaseURL());