Changeset 270067 in webkit


Ignore:
Timestamp:
Nov 19, 2020 8:32:46 PM (3 years ago)
Author:
commit-queue@webkit.org
Message:

Turn on ENABLE_WEBXR for Cocoa
https://bugs.webkit.org/show_bug.cgi?id=219171

Patch by Ada Chan <adachan@apple.com> on 2020-11-19
Reviewed by Tim Horton.

Source/WebCore:

  • Modules/webxr/WebXRRigidTransform.h:
  • Modules/webxr/WebXRSystem.h:
  • Modules/webxr/WebXRView.h:
  • Modules/webxr/XREye.idl:
  • Modules/webxr/XRHandedness.idl:
  • Modules/webxr/XRReferenceSpaceType.idl:
  • Modules/webxr/XRSessionMode.idl:
  • Modules/webxr/XRTargetRayMode.idl:
  • Modules/webxr/XRVisibilityState.idl:
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCallbackData.h:
  • dom/ActiveDOMCallback.h:
  • platform/xr/cocoa/PlatformXRCocoa.cpp: Copied from Source/WebCore/Modules/webxr/XRTargetRayMode.idl.
  • platform/xr/cocoa/PlatformXRCocoa.h: Copied from Source/WebCore/Modules/webxr/XREye.idl.
  • platform/xr/openxr/PlatformXROpenXR.cpp:

(PlatformXR::Instance::Impl::queue const):
(PlatformXR::Instance::Impl::checkInstanceExtensionProperties const):
(PlatformXR::Instance::Impl::Impl):
(PlatformXR::Instance::Impl::~Impl):
(PlatformXR::Instance::enumerateImmersiveXRDevices):

  • platform/xr/openxr/PlatformXROpenXR.h:

Source/WTF:

  • wtf/PlatformEnableCocoa.h:
  • wtf/PlatformUse.h:
Location:
trunk/Source
Files:
1 added
19 edited
2 copied

Legend:

Unmodified
Added
Removed
  • trunk/Source/WTF/ChangeLog

    r270052 r270067  
     12020-11-19  Ada Chan  <adachan@apple.com>
     2
     3        Turn on ENABLE_WEBXR for Cocoa
     4        https://bugs.webkit.org/show_bug.cgi?id=219171
     5
     6        Reviewed by Tim Horton.
     7
     8        * wtf/PlatformEnableCocoa.h:
     9        * wtf/PlatformUse.h:
     10
    1112020-11-19  Saam Barati  <sbarati@apple.com>
    212
  • trunk/Source/WTF/wtf/PlatformEnableCocoa.h

    r269880 r270067  
    591591#endif
    592592
     593#if !defined(ENABLE_WEBXR) && (HAVE(WEBXR_INTERNALS) || (USE(APPLE_INTERNAL_SDK) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000))
     594#define ENABLE_WEBXR 1
     595#endif
     596
    593597#if !defined(ENABLE_WEB_API_STATISTICS)
    594598#define ENABLE_WEB_API_STATISTICS 1
  • trunk/Source/WTF/wtf/PlatformUse.h

    r270052 r270067  
    327327#endif
    328328#endif
     329
     330#if PLATFORM(COCOA)
     331#define USE_OPENXR 0
     332#endif
  • trunk/Source/WebCore/ChangeLog

    r270065 r270067  
     12020-11-19  Ada Chan  <adachan@apple.com>
     2
     3        Turn on ENABLE_WEBXR for Cocoa
     4        https://bugs.webkit.org/show_bug.cgi?id=219171
     5
     6        Reviewed by Tim Horton.
     7
     8        * Modules/webxr/WebXRRigidTransform.h:
     9        * Modules/webxr/WebXRSystem.h:
     10        * Modules/webxr/WebXRView.h:
     11        * Modules/webxr/XREye.idl:
     12        * Modules/webxr/XRHandedness.idl:
     13        * Modules/webxr/XRReferenceSpaceType.idl:
     14        * Modules/webxr/XRSessionMode.idl:
     15        * Modules/webxr/XRTargetRayMode.idl:
     16        * Modules/webxr/XRVisibilityState.idl:
     17        * SourcesCocoa.txt:
     18        * WebCore.xcodeproj/project.pbxproj:
     19        * bindings/js/JSCallbackData.h:
     20        * dom/ActiveDOMCallback.h:
     21        * platform/xr/cocoa/PlatformXRCocoa.cpp: Copied from Source/WebCore/Modules/webxr/XRTargetRayMode.idl.
     22        * platform/xr/cocoa/PlatformXRCocoa.h: Copied from Source/WebCore/Modules/webxr/XREye.idl.
     23        * platform/xr/openxr/PlatformXROpenXR.cpp:
     24        (PlatformXR::Instance::Impl::queue const):
     25        (PlatformXR::Instance::Impl::checkInstanceExtensionProperties const):
     26        (PlatformXR::Instance::Impl::Impl):
     27        (PlatformXR::Instance::Impl::~Impl):
     28        (PlatformXR::Instance::enumerateImmersiveXRDevices):
     29        * platform/xr/openxr/PlatformXROpenXR.h:
     30
    1312020-11-19  Aditya Keerthi  <akeerthi@apple.com>
    232
  • trunk/Source/WebCore/Modules/webxr/WebXRRigidTransform.h

    r258498 r270067  
    3939
    4040class WebXRRigidTransform : public RefCounted<WebXRRigidTransform> {
    41     WTF_MAKE_ISO_ALLOCATED(WebXRRigidTransform);
     41    WTF_MAKE_ISO_ALLOCATED_EXPORT(WebXRRigidTransform, WEBCORE_EXPORT);
    4242public:
    4343    static Ref<WebXRRigidTransform> create();
    44     static ExceptionOr<Ref<WebXRRigidTransform>> create(const DOMPointInit&, const DOMPointInit&);
    45     ~WebXRRigidTransform();
     44    WEBCORE_EXPORT static ExceptionOr<Ref<WebXRRigidTransform>> create(const DOMPointInit&, const DOMPointInit&);
     45    WEBCORE_EXPORT ~WebXRRigidTransform();
    4646
    4747    const DOMPointReadOnly& position() const;
  • trunk/Source/WebCore/Modules/webxr/WebXRSystem.h

    r268255 r270067  
    7676
    7777    // For testing purpouses only.
    78     void registerSimulatedXRDeviceForTesting(PlatformXR::Device&);
    79     void unregisterSimulatedXRDeviceForTesting(PlatformXR::Device&);
     78    WEBCORE_EXPORT void registerSimulatedXRDeviceForTesting(PlatformXR::Device&);
     79    WEBCORE_EXPORT void unregisterSimulatedXRDeviceForTesting(PlatformXR::Device&);
    8080
    8181protected:
  • trunk/Source/WebCore/Modules/webxr/WebXRView.h

    r260884 r270067  
    4141
    4242class WebXRView : public RefCounted<WebXRView> {
    43     WTF_MAKE_ISO_ALLOCATED(WebXRView);
     43    WTF_MAKE_ISO_ALLOCATED_EXPORT(WebXRView, WEBCORE_EXPORT);
    4444public:
    45     static Ref<WebXRView> create();
    46     ~WebXRView();
     45    WEBCORE_EXPORT static Ref<WebXRView> create();
     46    WEBCORE_EXPORT ~WebXRView();
    4747
    4848    XREye eye() const { return m_eye; }
     
    5151
    5252    void setEye(XREye eye) { m_eye = eye; }
    53     void setProjectionMatrix(const Vector<float>&);
     53    WEBCORE_EXPORT void setProjectionMatrix(const Vector<float>&);
    5454    void setTransform(RefPtr<WebXRRigidTransform>&& viewOffset) { m_transform = WTFMove(viewOffset); }
    5555
  • trunk/Source/WebCore/Modules/webxr/XREye.idl

    r258498 r270067  
    2626[
    2727    EnabledAtRuntime=WebXR,
    28     Conditional=WEBXR
     28    Conditional=WEBXR,
     29    ExportMacro=WEBCORE_EXPORT
    2930] enum XREye {
    3031    "none",
  • trunk/Source/WebCore/Modules/webxr/XRHandedness.idl

    r258498 r270067  
    2626[
    2727    EnabledAtRuntime=WebXR,
    28     Conditional=WEBXR
     28    Conditional=WEBXR,
     29    ExportMacro=WEBCORE_EXPORT
    2930] enum XRHandedness {
    3031    "none",
  • trunk/Source/WebCore/Modules/webxr/XRReferenceSpaceType.idl

    r258498 r270067  
    2626[
    2727    EnabledAtRuntime=WebXR,
    28     Conditional=WEBXR
     28    Conditional=WEBXR,
     29    ExportMacro=WEBCORE_EXPORT
    2930] enum XRReferenceSpaceType {
    3031    "viewer",
  • trunk/Source/WebCore/Modules/webxr/XRSessionMode.idl

    r258498 r270067  
    2626[
    2727    EnabledAtRuntime=WebXR,
    28     Conditional=WEBXR
     28    Conditional=WEBXR,
     29    ExportMacro=WEBCORE_EXPORT
    2930] enum XRSessionMode {
    3031    "inline",
  • trunk/Source/WebCore/Modules/webxr/XRTargetRayMode.idl

    r258498 r270067  
    2626[
    2727    EnabledAtRuntime=WebXR,
    28     Conditional=WEBXR
     28    Conditional=WEBXR,
     29    ExportMacro=WEBCORE_EXPORT
    2930] enum XRTargetRayMode {
    3031    "gaze",
  • trunk/Source/WebCore/Modules/webxr/XRVisibilityState.idl

    r258498 r270067  
    2626[
    2727    EnabledAtRuntime=WebXR,
    28     Conditional=WEBXR
     28    Conditional=WEBXR,
     29    ExportMacro=WEBCORE_EXPORT
    2930] enum XRVisibilityState {
    3031    "visible",
  • trunk/Source/WebCore/SourcesCocoa.txt

    r269830 r270067  
    588588platform/text/mac/TextCheckingMac.mm
    589589platform/text/mac/TextEncodingRegistryMac.mm
     590platform/xr/cocoa/PlatformXRCocoa.cpp
    590591rendering/RenderThemeCocoa.mm
    591592rendering/RenderThemeIOS.mm
  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r270023 r270067  
    16001600                51FB5504113E3E9100821176 /* JSCloseEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = 51FB5502113E3E9100821176 /* JSCloseEvent.h */; };
    16011601                51FB67DC1AE6B82F00D06C5A /* ContentExtensionStyleSheet.h in Headers */ = {isa = PBXBuildFile; fileRef = 51FB67DA1AE6B5E400D06C5A /* ContentExtensionStyleSheet.h */; settings = {ATTRIBUTES = (Private, ); }; };
     1602                5273CC77256103CF00850007 /* PlatformXRCocoa.h in Headers */ = {isa = PBXBuildFile; fileRef = 5273CC75256103CF00850007 /* PlatformXRCocoa.h */; };
     1603                5273CC8E25637EB500850007 /* WebXRTest.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E18D83E0243F71CE009247D6 /* WebXRTest.cpp */; };
     1604                5273CC9025637F6700850007 /* WebFakeXRDevice.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E18D83E9243F71D3009247D6 /* WebFakeXRDevice.cpp */; };
     1605                5273CC9125637F7500850007 /* WebFakeXRInputController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E18D83DD243F71CC009247D6 /* WebFakeXRInputController.cpp */; };
     1606                5273CC9C2563B25A00850007 /* JSWebXRTest.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5273CC9A2563B21200850007 /* JSWebXRTest.cpp */; };
     1607                5273CCA02563B37700850007 /* JSWebFakeXRDevice.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5273CC9E2563B37600850007 /* JSWebFakeXRDevice.cpp */; };
     1608                5273CCA42563B4F800850007 /* JSXRSimulateUserActivationFunction.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5273CCA22563B4F700850007 /* JSXRSimulateUserActivationFunction.cpp */; };
     1609                5273CCA82563B5CA00850007 /* JSWebFakeXRInputController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5273CCA62563B5C900850007 /* JSWebFakeXRInputController.cpp */; };
     1610                5273CCB02564576F00850007 /* JSFakeXRInputSourceInit.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5273CCAA2564576B00850007 /* JSFakeXRInputSourceInit.cpp */; };
     1611                5273CCB12564576F00850007 /* JSFakeXRBoundsPoint.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5273CCAC2564576C00850007 /* JSFakeXRBoundsPoint.cpp */; };
     1612                5273CCB22564576F00850007 /* JSFakeXRButtonStateInit.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5273CCAD2564576C00850007 /* JSFakeXRButtonStateInit.cpp */; };
     1613                5273CCB32564576F00850007 /* JSFakeXRRigidTransformInit.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5273CCAE2564576D00850007 /* JSFakeXRRigidTransformInit.cpp */; };
     1614                5273CCB42564576F00850007 /* JSFakeXRViewInit.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5273CCAF2564576E00850007 /* JSFakeXRViewInit.cpp */; };
    16021615                52B0D4BE1C57FD1E0077CE53 /* PlatformView.h in Headers */ = {isa = PBXBuildFile; fileRef = 52B0D4BD1C57FD1E0077CE53 /* PlatformView.h */; settings = {ATTRIBUTES = (Private, ); }; };
    16031616                52B0D4C01C57FD660077CE53 /* VideoFullscreenChangeObserver.h in Headers */ = {isa = PBXBuildFile; fileRef = 52B0D4BF1C57FD660077CE53 /* VideoFullscreenChangeObserver.h */; settings = {ATTRIBUTES = (Private, ); }; };
     
    88288841                526B3F0122FB7BDD0076D37D /* WHLSLPruneUnreachableStandardLibraryFunctions.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WHLSLPruneUnreachableStandardLibraryFunctions.cpp; sourceTree = "<group>"; };
    88298842                526B3F0322FB7BDE0076D37D /* WHLSLPruneUnreachableStandardLibraryFunctions.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLPruneUnreachableStandardLibraryFunctions.h; sourceTree = "<group>"; };
     8843                5273CC74256103CF00850007 /* PlatformXRCocoa.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = PlatformXRCocoa.cpp; sourceTree = "<group>"; };
     8844                5273CC75256103CF00850007 /* PlatformXRCocoa.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = PlatformXRCocoa.h; sourceTree = "<group>"; };
     8845                5273CC9A2563B21200850007 /* JSWebXRTest.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSWebXRTest.cpp; sourceTree = "<group>"; };
     8846                5273CC9E2563B37600850007 /* JSWebFakeXRDevice.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSWebFakeXRDevice.cpp; sourceTree = "<group>"; };
     8847                5273CCA22563B4F700850007 /* JSXRSimulateUserActivationFunction.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSXRSimulateUserActivationFunction.cpp; sourceTree = "<group>"; };
     8848                5273CCA62563B5C900850007 /* JSWebFakeXRInputController.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSWebFakeXRInputController.cpp; sourceTree = "<group>"; };
     8849                5273CCAA2564576B00850007 /* JSFakeXRInputSourceInit.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSFakeXRInputSourceInit.cpp; sourceTree = "<group>"; };
     8850                5273CCAC2564576C00850007 /* JSFakeXRBoundsPoint.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSFakeXRBoundsPoint.cpp; sourceTree = "<group>"; };
     8851                5273CCAD2564576C00850007 /* JSFakeXRButtonStateInit.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSFakeXRButtonStateInit.cpp; sourceTree = "<group>"; };
     8852                5273CCAE2564576D00850007 /* JSFakeXRRigidTransformInit.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSFakeXRRigidTransformInit.cpp; sourceTree = "<group>"; };
     8853                5273CCAF2564576E00850007 /* JSFakeXRViewInit.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSFakeXRViewInit.cpp; sourceTree = "<group>"; };
    88308854                52914C2A22F93E4E00578150 /* WHLSLParsingMode.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLParsingMode.h; sourceTree = "<group>"; };
    88318855                52914C2C22F93E5D00578150 /* WHLSLAddressEscapeMode.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLAddressEscapeMode.h; sourceTree = "<group>"; };
     
    1933919363                        isa = PBXGroup;
    1934019364                        children = (
     19365                                5273CCAC2564576C00850007 /* JSFakeXRBoundsPoint.cpp */,
     19366                                5273CCAD2564576C00850007 /* JSFakeXRButtonStateInit.cpp */,
     19367                                5273CCAA2564576B00850007 /* JSFakeXRInputSourceInit.cpp */,
     19368                                5273CCAE2564576D00850007 /* JSFakeXRRigidTransformInit.cpp */,
     19369                                5273CCAF2564576E00850007 /* JSFakeXRViewInit.cpp */,
    1934119370                                51714EAE1CF6654A004723C4 /* JSGCObservation.cpp */,
    1934219371                                51714EAF1CF6654A004723C4 /* JSGCObservation.h */,
     
    1937419403                                EBF5121A1696496C0056BD25 /* JSTypeConversions.cpp */,
    1937519404                                EBF5121B1696496C0056BD25 /* JSTypeConversions.h */,
     19405                                5273CC9E2563B37600850007 /* JSWebFakeXRDevice.cpp */,
     19406                                5273CCA62563B5C900850007 /* JSWebFakeXRInputController.cpp */,
     19407                                5273CC9A2563B21200850007 /* JSWebXRTest.cpp */,
     19408                                5273CCA22563B4F700850007 /* JSXRSimulateUserActivationFunction.cpp */,
    1937619409                        );
    1937719410                        name = Testing;
     
    2056320596                        );
    2056420597                        path = service;
     20598                        sourceTree = "<group>";
     20599                };
     20600                5273CC722561039B00850007 /* cocoa */ = {
     20601                        isa = PBXGroup;
     20602                        children = (
     20603                                5273CC74256103CF00850007 /* PlatformXRCocoa.cpp */,
     20604                                5273CC75256103CF00850007 /* PlatformXRCocoa.h */,
     20605                        );
     20606                        path = cocoa;
    2056520607                        sourceTree = "<group>";
    2056620608                };
     
    2859028632                        isa = PBXGroup;
    2859128633                        children = (
     28634                                5273CC722561039B00850007 /* cocoa */,
    2859228635                                E1EE8B6D2412B2A700E794D6 /* openxr */,
    2859328636                                E1EE8B6F2412B2A700E794D6 /* PlatformXR.h */,
     
    3383433877                                935C476B09AC4D4F00A6AAB4 /* PlatformWheelEvent.h in Headers */,
    3383533878                                E1EE8B722412B2A800E794D6 /* PlatformXR.h in Headers */,
     33879                                5273CC77256103CF00850007 /* PlatformXRCocoa.h in Headers */,
    3383633880                                E1C1A39E2480080800E0AF66 /* PlatformXROpenXR.h in Headers */,
    3383733881                                712BE4801FE864A7002031CC /* PlaybackDirection.h in Headers */,
     
    3566435708                                4136C57A2398E5BE002497D3 /* InternalsMapLike.cpp in Sources */,
    3566535709                                4136EC0C23838870000ADBCE /* InternalsSetLike.cpp in Sources */,
     35710                                5273CCB12564576F00850007 /* JSFakeXRBoundsPoint.cpp in Sources */,
     35711                                5273CCB22564576F00850007 /* JSFakeXRButtonStateInit.cpp in Sources */,
     35712                                5273CCB02564576F00850007 /* JSFakeXRInputSourceInit.cpp in Sources */,
     35713                                5273CCB32564576F00850007 /* JSFakeXRRigidTransformInit.cpp in Sources */,
     35714                                5273CCB42564576F00850007 /* JSFakeXRViewInit.cpp in Sources */,
    3566635715                                DE5F86121FA239E7006DB63A /* JSGCObservation.cpp in Sources */,
    3566735716                                417DA71D13735DFA007C57FB /* JSInternals.cpp in Sources */,
     
    3568335732                                427DA71D13735DFA007C57FB /* JSServiceWorkerInternals.cpp in Sources */,
    3568435733                                EBF5121C1696496C0056BD25 /* JSTypeConversions.cpp in Sources */,
     35734                                5273CCA02563B37700850007 /* JSWebFakeXRDevice.cpp in Sources */,
     35735                                5273CCA82563B5CA00850007 /* JSWebFakeXRInputController.cpp in Sources */,
     35736                                5273CC9C2563B25A00850007 /* JSWebXRTest.cpp in Sources */,
     35737                                5273CCA42563B4F800850007 /* JSXRSimulateUserActivationFunction.cpp in Sources */,
    3568535738                                CDC26B40160A8CC60026757B /* LegacyMockCDM.cpp in Sources */,
    3568635739                                A1E086632489D34E00E496D9 /* MockApplePaySetupFeature.cpp in Sources */,
     
    3570135754                                DE7710861FA2F0D600460016 /* WebArchiveDumpSupport.mm in Sources */,
    3570235755                                41815C1E138319830057AAA4 /* WebCoreTestSupport.cpp in Sources */,
     35756                                5273CC9025637F6700850007 /* WebFakeXRDevice.cpp in Sources */,
     35757                                5273CC9125637F7500850007 /* WebFakeXRInputController.cpp in Sources */,
     35758                                5273CC8E25637EB500850007 /* WebXRTest.cpp in Sources */,
    3570335759                        );
    3570435760                        runOnlyForDeploymentPostprocessing = 0;
  • trunk/Source/WebCore/bindings/js/JSCallbackData.h

    r268365 r270067  
    6363    }
    6464   
    65     static JSC::JSValue invokeCallback(JSDOMGlobalObject&, JSC::JSObject* callback, JSC::JSValue thisValue, JSC::MarkedArgumentBuffer&, CallbackType, JSC::PropertyName functionName, NakedPtr<JSC::Exception>& returnedException);
     65    WEBCORE_EXPORT static JSC::JSValue invokeCallback(JSDOMGlobalObject&, JSC::JSObject* callback, JSC::JSValue thisValue, JSC::MarkedArgumentBuffer&, CallbackType, JSC::PropertyName functionName, NakedPtr<JSC::Exception>& returnedException);
    6666
    6767private:
  • trunk/Source/WebCore/dom/ActiveDOMCallback.h

    r252263 r270067  
    4848class ActiveDOMCallback : public ContextDestructionObserver {
    4949public:
    50     ActiveDOMCallback(ScriptExecutionContext*);
    51     virtual ~ActiveDOMCallback();
     50    WEBCORE_EXPORT ActiveDOMCallback(ScriptExecutionContext*);
     51    WEBCORE_EXPORT virtual ~ActiveDOMCallback();
    5252
    5353    WEBCORE_EXPORT bool canInvokeCallback() const;
  • trunk/Source/WebCore/platform/xr/cocoa/PlatformXRCocoa.cpp

    r270066 r270067  
    11/*
    2  * Copyright (C) 2020 Igalia S.L. All rights reserved.
     2 * Copyright (C) 2020 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    2424 */
    2525
    26 [
    27     EnabledAtRuntime=WebXR,
    28     Conditional=WEBXR
    29 ] enum XRSessionMode {
    30     "inline",
    31     "immersive-vr",
    32     "immersive-ar"
    33 };
     26#include "config.h"
     27#include "PlatformXRCocoa.h"
     28
     29#if ENABLE(WEBXR) && PLATFORM(COCOA)
     30
     31#include <WebKitAdditions/PlatformXRAdditions.cpp>
     32
     33#endif
  • trunk/Source/WebCore/platform/xr/cocoa/PlatformXRCocoa.h

    r270066 r270067  
    11/*
    2  * Copyright (C) 2020 Igalia S.L. All rights reserved.
     2 * Copyright (C) 2020 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    2424 */
    2525
    26 [
    27     EnabledAtRuntime=WebXR,
    28     Conditional=WEBXR
    29 ] enum XREye {
    30     "none",
    31     "left",
    32     "right"
    33 };
     26#pragma once
     27
     28#if ENABLE(WEBXR) && PLATFORM(COCOA)
     29
     30#include <WebKitAdditions/PlatformXRAdditions.h>
     31
     32#endif
  • trunk/Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp

    r269032 r270067  
    2121#include "PlatformXROpenXR.h"
    2222
    23 #if ENABLE(WEBXR)
     23#if ENABLE(WEBXR) && USE(OPENXR)
    2424
    2525#include "Logging.h"
    26 #if USE_OPENXR
    2726#include <openxr/openxr_platform.h>
    2827#include <wtf/Optional.h>
     
    3029#include <wtf/text/StringConcatenateNumbers.h>
    3130#include <wtf/text/WTFString.h>
    32 #endif // USE_OPENXR
    3331#include <wtf/NeverDestroyed.h>
    3432
     
    3634
    3735namespace PlatformXR {
    38 
    39 #if USE_OPENXR
    4036
    4137template<typename T, XrStructureType StructureType>
     
    6460    }                                                                                               \
    6561
    66 #endif // USE_OPENXR
    67 
    6862struct Instance::Impl {
    6963    WTF_MAKE_FAST_ALLOCATED;
     
    7266    ~Impl();
    7367
    74 #if USE_OPENXR
    7568    XrInstance xrInstance() const { return m_instance; }
    7669    WorkQueue& queue() const { return m_workQueue; }
    77 #endif
    7870
    7971private:
    80 #if USE_OPENXR
    8172    void enumerateApiLayerProperties() const;
    8273    bool checkInstanceExtensionProperties() const;
     
    8475    XrInstance m_instance { XR_NULL_HANDLE };
    8576    Ref<WorkQueue> m_workQueue;
    86 #endif // USE_OPENXR
    8777};
    8878
    89 #if USE_OPENXR
    9079void Instance::Impl::enumerateApiLayerProperties() const
    9180{
     
    156145    return true;
    157146}
    158 #endif // USE_OPENXR
    159147
    160148Instance::Impl::Impl()
    161 #if USE_OPENXR
    162149    : m_workQueue(WorkQueue::create("OpenXR queue"))
    163 #endif
    164 {
    165 #if USE_OPENXR
     150{
    166151    m_workQueue->dispatch([this]() {
    167152        LOG(XR, "OpenXR: initializing\n");
     
    194179        LOG(XR, "xrCreateInstance(): using instance %p\n", m_instance);
    195180    });
    196 #endif // USE_OPENXR
    197181}
    198182
    199183Instance::Impl::~Impl()
    200184{
    201 #if USE_OPENXR
    202185    m_workQueue->dispatch([this] {
    203186        if (m_instance != XR_NULL_HANDLE)
    204187            xrDestroyInstance(m_instance);
    205188    });
    206 #endif
    207189}
    208190
     
    225207void Instance::enumerateImmersiveXRDevices(CompletionHandler<void(const DeviceList& devices)>&& callback)
    226208{
    227 #if USE_OPENXR
    228209    m_impl->queue().dispatch([this, callback = WTFMove(callback)]() mutable {
    229210        auto callbackOnExit = makeScopeExit([&]() {
     
    254235        });
    255236    });
    256 
    257 #endif // USE_OPENXR
    258 }
    259 
    260 #if USE_OPENXR
     237}
     238
    261239OpenXRDevice::OpenXRDevice(XrSystemId id, XrInstance instance, WorkQueue& queue, CompletionHandler<void()>&& callback)
    262240    : m_systemId(id)
     
    400378}
    401379
    402 #endif // USE_OPENXR
    403 
    404380} // namespace PlatformXR
    405381
    406 #endif // ENABLE(WEBXR)
     382#endif // ENABLE(WEBXR) && USE(OPENXR)
  • trunk/Source/WebCore/platform/xr/openxr/PlatformXROpenXR.h

    r269032 r270067  
    2020#pragma once
    2121
    22 #if ENABLE(WEBXR)
     22#if ENABLE(WEBXR) && USE(OPENXR)
    2323#include "PlatformXR.h"
    2424
    2525#include <wtf/HashMap.h>
    2626
    27 #if USE_OPENXR
    2827#include <openxr/openxr.h>
    2928#include <wtf/WorkQueue.h>
     
    7069} // namespace PlatformXR
    7170
    72 #endif // USE_OPENXR
    73 #endif // ENABLE(WEBXR)
     71#endif // ENABLE(WEBXR) && USE(OPENXR)
Note: See TracChangeset for help on using the changeset viewer.