Changeset 270069 in webkit
- Timestamp:
- Nov 19, 2020 9:56:15 PM (3 years ago)
- Location:
- trunk
- Files:
-
- 32 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r270067 r270069 1 2020-11-19 Hoa Dinh <dvh@apple.com> 2 3 Code formatting: change instances of "@synthesize a=b" to "@synthesize a = b". 4 https://bugs.webkit.org/show_bug.cgi?id=219094 5 6 Reviewed by Wenson Hsieh. 7 8 There was a mix of "@synthesize a=b" and "@synthesize a = b" in the codebase. 9 Most of the instances are "@synthesize a = b", with spaces around the equal sign. 10 With https://bugs.webkit.org/show_bug.cgi?id=219092, we're changing the behavior of 11 the code style checker to require spaces around the equal sign. 12 The change replace all the instances of "@synthesize a=b" with "@synthesize a = b". 13 14 * accessibility/mac/WebAccessibilityObjectWrapperBase.mm: 15 * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: 16 * platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm: 17 * platform/graphics/cocoa/WebGPULayer.mm: 18 * platform/mac/VideoFullscreenInterfaceMac.mm: 19 * platform/mac/WebPlaybackControlsManager.mm: 20 * platform/network/cocoa/WebCoreNSURLSession.mm: 21 1 22 2020-11-19 Ada Chan <adachan@apple.com> 2 23 -
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
r269923 r270069 277 277 @implementation WebAccessibilityObjectWrapperBase 278 278 279 @synthesize identifier =_identifier;279 @synthesize identifier = _identifier; 280 280 281 281 - (id)initWithAccessibilityObject:(AXCoreObject*)axObject -
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
r269850 r270069 3644 3644 @implementation WebCoreAVFPullDelegate 3645 3645 3646 @synthesize semaphore =m_semaphore;3646 @synthesize semaphore = m_semaphore; 3647 3647 3648 3648 - (void)outputMediaDataWillChange:(AVPlayerItemVideoOutput *)output -
trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm
r269711 r270069 78 78 } 79 79 80 @synthesize parent =_parent;80 @synthesize parent = _parent; 81 81 82 82 - (void)dealloc -
trunk/Source/WebCore/platform/graphics/cocoa/WebGPULayer.mm
r260366 r270069 34 34 @implementation WebGPULayer 35 35 36 @synthesize swapChain =_swapChain;36 @synthesize swapChain = _swapChain; 37 37 38 38 - (id)init -
trunk/Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm
r269557 r270069 76 76 @implementation WebVideoViewContainer 77 77 78 @synthesize videoViewContainerDelegate =_videoViewContainerDelegate;78 @synthesize videoViewContainerDelegate = _videoViewContainerDelegate; 79 79 80 80 - (void)resizeWithOldSuperviewSize:(NSSize)oldBoundsSize … … 135 135 @implementation WebVideoFullscreenInterfaceMacObjC 136 136 137 @synthesize playing =_playing;138 @synthesize videoDimensions =_videoDimensions;139 @synthesize exitingToStandardFullscreen =_exitingToStandardFullscreen;137 @synthesize playing = _playing; 138 @synthesize videoDimensions = _videoDimensions; 139 @synthesize exitingToStandardFullscreen = _exitingToStandardFullscreen; 140 140 141 141 - (instancetype)initWithVideoFullscreenInterfaceMac:(WebCore::VideoFullscreenInterfaceMac*)videoFullscreenInterfaceMac -
trunk/Source/WebCore/platform/mac/WebPlaybackControlsManager.mm
r266218 r270069 46 46 @implementation WebPlaybackControlsManager 47 47 48 @synthesize seekToTime =_seekToTime;49 @synthesize hasEnabledAudio =_hasEnabledAudio;50 @synthesize hasEnabledVideo =_hasEnabledVideo;51 @synthesize rate =_rate;52 @synthesize canTogglePlayback =_canTogglePlayback;48 @synthesize seekToTime = _seekToTime; 49 @synthesize hasEnabledAudio = _hasEnabledAudio; 50 @synthesize hasEnabledVideo = _hasEnabledVideo; 51 @synthesize rate = _rate; 52 @synthesize canTogglePlayback = _canTogglePlayback; 53 53 @synthesize allowsPictureInPicturePlayback; 54 54 @synthesize pictureInPictureActive; -
trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm
r264054 r270069 732 732 733 733 #pragma mark - NSURLSession API 734 @synthesize session =_session;735 @synthesize taskIdentifier =_taskIdentifier;736 @synthesize originalRequest =_originalRequest;737 @synthesize currentRequest =_currentRequest;738 @synthesize countOfBytesReceived =_countOfBytesReceived;739 @synthesize countOfBytesSent =_countOfBytesSent;740 @synthesize countOfBytesExpectedToSend =_countOfBytesExpectedToSend;741 @synthesize countOfBytesExpectedToReceive =_countOfBytesExpectedToReceive;742 @synthesize state =_state;743 @synthesize error =_error;744 @synthesize taskDescription =_taskDescription;745 @synthesize priority =_priority;734 @synthesize session = _session; 735 @synthesize taskIdentifier = _taskIdentifier; 736 @synthesize originalRequest = _originalRequest; 737 @synthesize currentRequest = _currentRequest; 738 @synthesize countOfBytesReceived = _countOfBytesReceived; 739 @synthesize countOfBytesSent = _countOfBytesSent; 740 @synthesize countOfBytesExpectedToSend = _countOfBytesExpectedToSend; 741 @synthesize countOfBytesExpectedToReceive = _countOfBytesExpectedToReceive; 742 @synthesize state = _state; 743 @synthesize error = _error; 744 @synthesize taskDescription = _taskDescription; 745 @synthesize priority = _priority; 746 746 747 747 - (NSURLResponse *)response -
trunk/Source/WebKit/ChangeLog
r270061 r270069 1 2020-11-19 Hoa Dinh <dvh@apple.com> 2 3 Code formatting: change instances of "@synthesize a=b" to "@synthesize a = b". 4 https://bugs.webkit.org/show_bug.cgi?id=219094 5 6 Reviewed by Wenson Hsieh. 7 8 There was a mix of "@synthesize a=b" and "@synthesize a = b" in the codebase. 9 Most of the instances are "@synthesize a = b", with spaces around the equal sign. 10 With https://bugs.webkit.org/show_bug.cgi?id=219092, we're changing the behavior of 11 the code style checker to require spaces around the equal sign. 12 The change replace all the instances of "@synthesize a=b" with "@synthesize a = b". 13 14 * NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm: 15 * UIProcess/API/Cocoa/WKPreviewActionItem.mm: 16 * UIProcess/API/Cocoa/_WKThumbnailView.mm: 17 * UIProcess/Cocoa/WebViewImpl.mm: 18 * UIProcess/QuickLookThumbnailLoader.mm: 19 * UIProcess/WebAuthentication/Mock/MockNfcService.mm: 20 * UIProcess/ios/fullscreen/WKFullScreenViewController.mm: 21 * UIProcess/mac/ViewGestureControllerMac.mm: 22 * UIProcess/mac/WKFullScreenWindowController.mm: 23 * WebProcess/Plugins/PDF/PDFPlugin.mm: 24 1 25 2020-11-19 Brent Fulgham <bfulgham@apple.com> 2 26 -
trunk/Source/WebKit/NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm
r260191 r270069 70 70 @implementation WKCustomProtocol 71 71 72 @synthesize customProtocolID =_customProtocolID;72 @synthesize customProtocolID = _customProtocolID; 73 73 74 74 + (BOOL)canInitWithRequest:(NSURLRequest *)request -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreviewActionItem.mm
r245691 r270069 30 30 31 31 @implementation WKPreviewAction 32 @synthesize identifier =_identifier;32 @synthesize identifier = _identifier; 33 33 34 34 ALLOW_DEPRECATED_DECLARATIONS_BEGIN -
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm
r254241 r270069 61 61 } 62 62 63 @synthesize _waitingForSnapshot =_waitingForSnapshot;63 @synthesize _waitingForSnapshot = _waitingForSnapshot; 64 64 65 65 - (instancetype)initWithFrame:(NSRect)frame -
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
r269869 r270069 524 524 @implementation WKTextListTouchBarViewController 525 525 526 @synthesize currentListType =_currentListType;526 @synthesize currentListType = _currentListType; 527 527 528 528 static const CGFloat listControlSegmentWidth = 67; … … 638 638 @implementation WKTextTouchBarItemController 639 639 640 @synthesize textIsBold =_textIsBold;641 @synthesize textIsItalic =_textIsItalic;642 @synthesize textIsUnderlined =_textIsUnderlined;643 @synthesize currentTextAlignment =_currentTextAlignment;640 @synthesize textIsBold = _textIsBold; 641 @synthesize textIsItalic = _textIsItalic; 642 @synthesize textIsUnderlined = _textIsUnderlined; 643 @synthesize currentTextAlignment = _currentTextAlignment; 644 644 645 645 - (instancetype)initWithWebViewImpl:(WebKit::WebViewImpl*)webViewImpl -
trunk/Source/WebKit/UIProcess/QuickLookThumbnailLoader.mm
r266743 r270069 144 144 } 145 145 146 @synthesize executing =_executing;146 @synthesize executing = _executing; 147 147 148 148 - (BOOL)isExecuting … … 164 164 } 165 165 166 @synthesize finished =_finished;166 @synthesize finished = _finished; 167 167 168 168 - (BOOL)isFinished -
trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockNfcService.mm
r251645 r270069 58 58 } 59 59 60 @synthesize technology =_technology;61 @synthesize AppData =_AppData;62 @synthesize UID =_UID;63 @synthesize ndefAvailability =_ndefAvailability;64 @synthesize ndefMessageSize =_ndefMessageSize;65 @synthesize ndefContainerSize =_ndefContainerSize;66 @synthesize tagA =_tagA;67 @synthesize tagB =_tagB;68 @synthesize tagF =_tagF;60 @synthesize technology = _technology; 61 @synthesize AppData = _AppData; 62 @synthesize UID = _UID; 63 @synthesize ndefAvailability = _ndefAvailability; 64 @synthesize ndefMessageSize = _ndefMessageSize; 65 @synthesize ndefContainerSize = _ndefContainerSize; 66 @synthesize tagA = _tagA; 67 @synthesize tagB = _tagB; 68 @synthesize tagF = _tagF; 69 69 70 70 - (NFTagType)type -
trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
r268268 r270069 123 123 } 124 124 125 @synthesize prefersStatusBarHidden =_prefersStatusBarHidden;126 @synthesize prefersHomeIndicatorAutoHidden =_prefersHomeIndicatorAutoHidden;125 @synthesize prefersStatusBarHidden = _prefersStatusBarHidden; 126 @synthesize prefersHomeIndicatorAutoHidden = _prefersHomeIndicatorAutoHidden; 127 127 128 128 #pragma mark - External Interface -
trunk/Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm
r263825 r270069 77 77 78 78 @implementation WKSwipeCancellationTracker 79 @synthesize isCancelled =_isCancelled;79 @synthesize isCancelled = _isCancelled; 80 80 @end 81 81 -
trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm
r269557 r270069 171 171 #pragma mark Accessors 172 172 173 @synthesize initialFrame =_initialFrame;174 @synthesize finalFrame =_finalFrame;173 @synthesize initialFrame = _initialFrame; 174 @synthesize finalFrame = _finalFrame; 175 175 176 176 - (BOOL)isFullScreen -
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
r268989 r270069 162 162 @implementation WKPDFPluginAccessibilityObject 163 163 164 @synthesize parent =_parent;165 @synthesize pdfPlugin =_pdfPlugin;164 @synthesize parent = _parent; 165 @synthesize pdfPlugin = _pdfPlugin; 166 166 167 167 - (id)initWithPDFPlugin:(WebKit::PDFPlugin *)plugin … … 360 360 @implementation WKPDFPluginScrollbarLayer 361 361 362 @synthesize pdfPlugin =_pdfPlugin;362 @synthesize pdfPlugin = _pdfPlugin; 363 363 364 364 - (id)initWithPDFPlugin:(WebKit::PDFPlugin *)plugin … … 394 394 @implementation WKPDFLayerControllerDelegate 395 395 396 @synthesize pdfPlugin =_pdfPlugin;396 @synthesize pdfPlugin = _pdfPlugin; 397 397 398 398 - (id)initWithPDFPlugin:(WebKit::PDFPlugin *)plugin -
trunk/Source/WebKitLegacy/mac/ChangeLog
r269888 r270069 1 2020-11-19 Hoa Dinh <dvh@apple.com> 2 3 Code formatting: change instances of "@synthesize a=b" to "@synthesize a = b". 4 https://bugs.webkit.org/show_bug.cgi?id=219094 5 6 Reviewed by Wenson Hsieh. 7 8 There was a mix of "@synthesize a=b" and "@synthesize a = b" in the codebase. 9 Most of the instances are "@synthesize a = b", with spaces around the equal sign. 10 With https://bugs.webkit.org/show_bug.cgi?id=219092, we're changing the behavior of 11 the code style checker to require spaces around the equal sign. 12 The change replace all the instances of "@synthesize a=b" with "@synthesize a = b". 13 14 * WebView/WebFullScreenController.mm: 15 * WebView/WebView.mm: 16 1 17 2020-11-16 Sam Weinig <weinig@apple.com> 2 18 -
trunk/Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm
r254241 r270069 102 102 } 103 103 104 @synthesize initialFrame =_initialFrame;105 @synthesize finalFrame =_finalFrame;104 @synthesize initialFrame = _initialFrame; 105 @synthesize finalFrame = _finalFrame; 106 106 107 107 - (void)windowDidLoad -
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
r269888 r270069 808 808 @implementation WebUITextIndicatorData 809 809 810 @synthesize dataInteractionImage =_dataInteractionImage;811 @synthesize selectionRectInRootViewCoordinates =_selectionRectInRootViewCoordinates;812 @synthesize textBoundingRectInRootViewCoordinates =_textBoundingRectInRootViewCoordinates;813 @synthesize textRectsInBoundingRectCoordinates =_textRectsInBoundingRectCoordinates;814 @synthesize contentImageWithHighlight =_contentImageWithHighlight;815 @synthesize contentImageWithoutSelection =_contentImageWithoutSelection;816 @synthesize contentImageWithoutSelectionRectInRootViewCoordinates =_contentImageWithoutSelectionRectInRootViewCoordinates;817 @synthesize contentImage =_contentImage;818 @synthesize estimatedBackgroundColor =_estimatedBackgroundColor;810 @synthesize dataInteractionImage = _dataInteractionImage; 811 @synthesize selectionRectInRootViewCoordinates = _selectionRectInRootViewCoordinates; 812 @synthesize textBoundingRectInRootViewCoordinates = _textBoundingRectInRootViewCoordinates; 813 @synthesize textRectsInBoundingRectCoordinates = _textRectsInBoundingRectCoordinates; 814 @synthesize contentImageWithHighlight = _contentImageWithHighlight; 815 @synthesize contentImageWithoutSelection = _contentImageWithoutSelection; 816 @synthesize contentImageWithoutSelectionRectInRootViewCoordinates = _contentImageWithoutSelectionRectInRootViewCoordinates; 817 @synthesize contentImage = _contentImage; 818 @synthesize estimatedBackgroundColor = _estimatedBackgroundColor; 819 819 820 820 - (void)dealloc … … 986 986 @implementation WebTextListTouchBarViewController 987 987 988 @synthesize currentListType =_currentListType;988 @synthesize currentListType = _currentListType; 989 989 990 990 static const CGFloat listControlSegmentWidth = 67.0; … … 1092 1092 @implementation WebTextTouchBarItemController 1093 1093 1094 @synthesize textIsBold =_textIsBold;1095 @synthesize textIsItalic =_textIsItalic;1096 @synthesize textIsUnderlined =_textIsUnderlined;1097 @synthesize currentTextAlignment =_currentTextAlignment;1094 @synthesize textIsBold = _textIsBold; 1095 @synthesize textIsItalic = _textIsItalic; 1096 @synthesize textIsUnderlined = _textIsUnderlined; 1097 @synthesize currentTextAlignment = _currentTextAlignment; 1098 1098 1099 1099 - (instancetype)initWithWebView:(WebView *)webView … … 4983 4983 4984 4984 #if PLATFORM(IOS_FAMILY) 4985 @synthesize asyncForwarder =_asyncForwarder;4985 @synthesize asyncForwarder = _asyncForwarder; 4986 4986 4987 4987 - (void)dealloc -
trunk/Tools/ChangeLog
r270068 r270069 1 2020-11-19 Hoa Dinh <dvh@apple.com> 2 3 Code formatting: change instances of "@synthesize a=b" to "@synthesize a = b". 4 https://bugs.webkit.org/show_bug.cgi?id=219094 5 6 Reviewed by Wenson Hsieh. 7 8 There was a mix of "@synthesize a=b" and "@synthesize a = b" in the codebase. 9 Most of the instances are "@synthesize a = b", with spaces around the equal sign. 10 With https://bugs.webkit.org/show_bug.cgi?id=219092, we're changing the behavior of 11 the code style checker to require spaces around the equal sign. 12 The change replace all the instances of "@synthesize a=b" with "@synthesize a = b". 13 14 * DumpRenderTree/DumpRenderTreeFileDraggingSource.m: 15 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: 16 * MiniBrowser/mac/BrowserWindowController.m: 17 * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm: 18 * TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.mm: 19 * TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm: 20 * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm: 21 * TestWebKitAPI/mac/TestDraggingInfo.mm: 22 * TestWebKitAPI/mac/TestFontOptions.mm: 23 1 24 2020-11-19 Hoa Dinh <dvh@apple.com> 2 25 -
trunk/Tools/DumpRenderTree/DumpRenderTreeFileDraggingSource.m
r229297 r270069 33 33 @implementation DumpRenderTreeFileDraggingSource 34 34 35 @synthesize promisedFileURLs =_promisedFileURLs;35 @synthesize promisedFileURLs = _promisedFileURLs; 36 36 37 37 - (instancetype)initWithPromisedFileURLs:(NSArray<NSURL *> *)promisedFileURLs -
trunk/Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm
r260334 r270069 53 53 @implementation DumpRenderTreeFilePromiseReceiver 54 54 55 @synthesize draggingSource =_draggingSource;55 @synthesize draggingSource = _draggingSource; 56 56 57 57 - (instancetype)initWithPromisedUTIs:(NSArray<NSString *> *)promisedUTIs -
trunk/Tools/MiniBrowser/mac/BrowserWindowController.m
r265061 r270069 34 34 @implementation BrowserWindowController 35 35 36 @synthesize editable =_editable;36 @synthesize editable = _editable; 37 37 38 38 - (id)initWithWindow:(NSWindow *)window -
trunk/Tools/TestRunnerShared/cocoa/LayoutTestSpellChecker.mm
r267761 r270069 170 170 @implementation LayoutTestSpellChecker 171 171 172 @synthesize spellCheckerLoggingEnabled =_spellCheckerLoggingEnabled;172 @synthesize spellCheckerLoggingEnabled = _spellCheckerLoggingEnabled; 173 173 174 174 + (instancetype)checker -
trunk/Tools/TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.mm
r233207 r270069 33 33 @implementation CustomBundleObject 34 34 35 @synthesize somePayload =_somePayload;35 @synthesize somePayload = _somePayload; 36 36 37 37 - (id)initWithValue:(long)value -
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm
r267763 r270069 45 45 @implementation IDBCheckpointWALMessageHandler 46 46 47 @synthesize receivedScriptMessage =_receivedScriptMessage;48 @synthesize lastScriptMessage =_lastScriptMessage;47 @synthesize receivedScriptMessage = _receivedScriptMessage; 48 @synthesize lastScriptMessage = _lastScriptMessage; 49 49 50 50 - (void)dealloc -
trunk/Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm
r262507 r270069 101 101 } 102 102 103 @synthesize currentDragOperation =_currentDragOperation;104 @synthesize initialDragImageLocationInView =_initialDragImageLocationInView;103 @synthesize currentDragOperation = _currentDragOperation; 104 @synthesize initialDragImageLocationInView = _initialDragImageLocationInView; 105 105 106 106 - (instancetype)initWithWebViewFrame:(CGRect)frame -
trunk/Tools/TestWebKitAPI/mac/TestDraggingInfo.mm
r246141 r270069 51 51 } 52 52 53 @synthesize draggingSourceOperationMask =_draggingSourceOperationMask;54 @synthesize draggingLocation =_draggingLocation;55 @synthesize draggingFormation =_draggingFormation;56 @synthesize numberOfValidItemsForDrop =_numberOfValidItemsForDrop;53 @synthesize draggingSourceOperationMask = _draggingSourceOperationMask; 54 @synthesize draggingLocation = _draggingLocation; 55 @synthesize draggingFormation = _draggingFormation; 56 @synthesize numberOfValidItemsForDrop = _numberOfValidItemsForDrop; 57 57 58 58 - (NSArray<NSFilePromiseReceiver *> *)filePromiseReceivers … … 129 129 // The following methods are not currently used by WebKit. 130 130 131 @synthesize draggedImageLocation =_draggedImageLocation;132 @synthesize draggingSequenceNumber =_draggingSequenceNumber;133 @synthesize animatesToDestination =_animatesToDestination;134 @synthesize springLoadingHighlight =_springLoadingHighlight;131 @synthesize draggedImageLocation = _draggedImageLocation; 132 @synthesize draggingSequenceNumber = _draggingSequenceNumber; 133 @synthesize animatesToDestination = _animatesToDestination; 134 @synthesize springLoadingHighlight = _springLoadingHighlight; 135 135 136 136 - (NSWindow *)draggingDestinationWindow -
trunk/Tools/TestWebKitAPI/mac/TestFontOptions.mm
r248846 r270069 60 60 } 61 61 62 @synthesize hasShadow =_hasShadow;63 @synthesize shadowBlurRadius =_shadowBlurRadius;64 @synthesize hasMultipleFonts =_hasMultipleFonts;62 @synthesize hasShadow = _hasShadow; 63 @synthesize shadowBlurRadius = _shadowBlurRadius; 64 @synthesize hasMultipleFonts = _hasMultipleFonts; 65 65 66 66 + (instancetype)sharedInstance
Note: See TracChangeset
for help on using the changeset viewer.