Changeset 270101 in webkit


Ignore:
Timestamp:
Nov 20, 2020 3:05:32 AM (3 years ago)
Author:
youenn@apple.com
Message:

Add support for RTCPeerConnection.onicecandidateerror event
https://bugs.webkit.org/show_bug.cgi?id=169644

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/idlharness.https.window-expected.txt:

Source/WebCore:

Expose RTCPeerConnection.onicecandidateerror and use it for wrong STUN/TURN server URLs.
For that matter, add RTCPeerConnectionIceErrorEvent as per spec with a slight change to the init directory to keep the same terminology between event and init dictionary.

Covered by updated webrtc/stun-server-filtering.html test.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::iceServersFromConfiguration):
(WebCore::iceServersFromConfiguration): Deleted.

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCPeerConnectionIceErrorEvent.cpp: Added.

(WebCore::RTCPeerConnectionIceErrorEvent::create):
(WebCore::RTCPeerConnectionIceErrorEvent::RTCPeerConnectionIceErrorEvent):
(WebCore::RTCPeerConnectionIceErrorEvent::eventInterface const):

  • Modules/mediastream/RTCPeerConnectionIceErrorEvent.h: Added.
  • Modules/mediastream/RTCPeerConnectionIceErrorEvent.idl: Added.
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreBuiltinNames.h:
  • dom/EventNames.h:
  • dom/EventNames.in:

LayoutTests:

  • webrtc/rtcpeerconnection-error-messages-expected.txt:
  • webrtc/stun-server-filtering.html:
Location:
trunk
Files:
3 added
18 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r270070 r270101  
     12020-11-20  Youenn Fablet  <youenn@apple.com>
     2
     3        Add support for RTCPeerConnection.onicecandidateerror event
     4        https://bugs.webkit.org/show_bug.cgi?id=169644
     5
     6        Reviewed by Alex Christensen.
     7
     8        * webrtc/rtcpeerconnection-error-messages-expected.txt:
     9        * webrtc/stun-server-filtering.html:
     10
    1112020-11-19  Zalan Bujtas  <zalan@apple.com>
    212
  • trunk/LayoutTests/imported/w3c/ChangeLog

    r270073 r270101  
     12020-11-20  Youenn Fablet  <youenn@apple.com>
     2
     3        Add support for RTCPeerConnection.onicecandidateerror event
     4        https://bugs.webkit.org/show_bug.cgi?id=169644
     5
     6        Reviewed by Alex Christensen.
     7
     8        * web-platform-tests/webrtc/idlharness.https.window-expected.txt:
     9
    1102020-11-16  Sergio Villar Senin  <svillar@igalia.com>
    211
  • trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/idlharness.https.window-expected.txt

    r267649 r270101  
    4545PASS RTCPeerConnection interface: attribute onnegotiationneeded
    4646PASS RTCPeerConnection interface: attribute onicecandidate
    47 FAIL RTCPeerConnection interface: attribute onicecandidateerror assert_true: The prototype object must have a property "onicecandidateerror" expected true got false
     47PASS RTCPeerConnection interface: attribute onicecandidateerror
    4848PASS RTCPeerConnection interface: attribute onsignalingstatechange
    4949PASS RTCPeerConnection interface: attribute oniceconnectionstatechange
     
    9797PASS RTCPeerConnection interface: new RTCPeerConnection() must inherit property "onnegotiationneeded" with the proper type
    9898PASS RTCPeerConnection interface: new RTCPeerConnection() must inherit property "onicecandidate" with the proper type
    99 FAIL RTCPeerConnection interface: new RTCPeerConnection() must inherit property "onicecandidateerror" with the proper type assert_inherits: property "onicecandidateerror" not found in prototype chain
     99PASS RTCPeerConnection interface: new RTCPeerConnection() must inherit property "onicecandidateerror" with the proper type
    100100PASS RTCPeerConnection interface: new RTCPeerConnection() must inherit property "onsignalingstatechange" with the proper type
    101101PASS RTCPeerConnection interface: new RTCPeerConnection() must inherit property "oniceconnectionstatechange" with the proper type
     
    196196PASS RTCPeerConnectionIceEvent interface: new RTCPeerConnectionIceEvent('ice') must inherit property "candidate" with the proper type
    197197PASS RTCPeerConnectionIceEvent interface: new RTCPeerConnectionIceEvent('ice') must inherit property "url" with the proper type
    198 FAIL RTCPeerConnectionIceErrorEvent interface: existence and properties of interface object assert_own_property: self does not have own property "RTCPeerConnectionIceErrorEvent" expected property "RTCPeerConnectionIceErrorEvent" missing
    199 FAIL RTCPeerConnectionIceErrorEvent interface object length assert_own_property: self does not have own property "RTCPeerConnectionIceErrorEvent" expected property "RTCPeerConnectionIceErrorEvent" missing
    200 FAIL RTCPeerConnectionIceErrorEvent interface object name assert_own_property: self does not have own property "RTCPeerConnectionIceErrorEvent" expected property "RTCPeerConnectionIceErrorEvent" missing
    201 FAIL RTCPeerConnectionIceErrorEvent interface: existence and properties of interface prototype object assert_own_property: self does not have own property "RTCPeerConnectionIceErrorEvent" expected property "RTCPeerConnectionIceErrorEvent" missing
    202 FAIL RTCPeerConnectionIceErrorEvent interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "RTCPeerConnectionIceErrorEvent" expected property "RTCPeerConnectionIceErrorEvent" missing
    203 FAIL RTCPeerConnectionIceErrorEvent interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "RTCPeerConnectionIceErrorEvent" expected property "RTCPeerConnectionIceErrorEvent" missing
    204 FAIL RTCPeerConnectionIceErrorEvent interface: attribute address assert_own_property: self does not have own property "RTCPeerConnectionIceErrorEvent" expected property "RTCPeerConnectionIceErrorEvent" missing
    205 FAIL RTCPeerConnectionIceErrorEvent interface: attribute port assert_own_property: self does not have own property "RTCPeerConnectionIceErrorEvent" expected property "RTCPeerConnectionIceErrorEvent" missing
    206 FAIL RTCPeerConnectionIceErrorEvent interface: attribute url assert_own_property: self does not have own property "RTCPeerConnectionIceErrorEvent" expected property "RTCPeerConnectionIceErrorEvent" missing
    207 FAIL RTCPeerConnectionIceErrorEvent interface: attribute errorCode assert_own_property: self does not have own property "RTCPeerConnectionIceErrorEvent" expected property "RTCPeerConnectionIceErrorEvent" missing
    208 FAIL RTCPeerConnectionIceErrorEvent interface: attribute errorText assert_own_property: self does not have own property "RTCPeerConnectionIceErrorEvent" expected property "RTCPeerConnectionIceErrorEvent" missing
    209 FAIL RTCPeerConnectionIceErrorEvent must be primary interface of new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 }); assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Can't find variable: RTCPeerConnectionIceErrorEvent"
    210 FAIL Stringification of new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 }); assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Can't find variable: RTCPeerConnectionIceErrorEvent"
    211 FAIL RTCPeerConnectionIceErrorEvent interface: new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 }); must inherit property "address" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Can't find variable: RTCPeerConnectionIceErrorEvent"
    212 FAIL RTCPeerConnectionIceErrorEvent interface: new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 }); must inherit property "port" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Can't find variable: RTCPeerConnectionIceErrorEvent"
    213 FAIL RTCPeerConnectionIceErrorEvent interface: new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 }); must inherit property "url" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Can't find variable: RTCPeerConnectionIceErrorEvent"
    214 FAIL RTCPeerConnectionIceErrorEvent interface: new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 }); must inherit property "errorCode" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Can't find variable: RTCPeerConnectionIceErrorEvent"
    215 FAIL RTCPeerConnectionIceErrorEvent interface: new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 }); must inherit property "errorText" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Can't find variable: RTCPeerConnectionIceErrorEvent"
     198PASS RTCPeerConnectionIceErrorEvent interface: existence and properties of interface object
     199PASS RTCPeerConnectionIceErrorEvent interface object length
     200PASS RTCPeerConnectionIceErrorEvent interface object name
     201PASS RTCPeerConnectionIceErrorEvent interface: existence and properties of interface prototype object
     202PASS RTCPeerConnectionIceErrorEvent interface: existence and properties of interface prototype object's "constructor" property
     203PASS RTCPeerConnectionIceErrorEvent interface: existence and properties of interface prototype object's @@unscopables property
     204PASS RTCPeerConnectionIceErrorEvent interface: attribute address
     205PASS RTCPeerConnectionIceErrorEvent interface: attribute port
     206PASS RTCPeerConnectionIceErrorEvent interface: attribute url
     207PASS RTCPeerConnectionIceErrorEvent interface: attribute errorCode
     208PASS RTCPeerConnectionIceErrorEvent interface: attribute errorText
     209PASS RTCPeerConnectionIceErrorEvent must be primary interface of new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 });
     210PASS Stringification of new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 });
     211PASS RTCPeerConnectionIceErrorEvent interface: new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 }); must inherit property "address" with the proper type
     212PASS RTCPeerConnectionIceErrorEvent interface: new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 }); must inherit property "port" with the proper type
     213PASS RTCPeerConnectionIceErrorEvent interface: new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 }); must inherit property "url" with the proper type
     214PASS RTCPeerConnectionIceErrorEvent interface: new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 }); must inherit property "errorCode" with the proper type
     215PASS RTCPeerConnectionIceErrorEvent interface: new RTCPeerConnectionIceErrorEvent('ice-error', { port: 0, errorCode: 701 }); must inherit property "errorText" with the proper type
    216216PASS RTCCertificate interface: existence and properties of interface object
    217217PASS RTCCertificate interface object length
  • trunk/LayoutTests/webrtc/rtcpeerconnection-error-messages-expected.txt

    r267644 r270101  
    1616TypeError: The RTCPeerConnection.onnegotiationneeded getter can only be used on instances of RTCPeerConnection
    1717TypeError: The RTCPeerConnection.onicecandidate getter can only be used on instances of RTCPeerConnection
    18 [object RTCPeerConnection] has no property named onicecandidateerror
     18TypeError: The RTCPeerConnection.onicecandidateerror getter can only be used on instances of RTCPeerConnection
    1919TypeError: The RTCPeerConnection.onsignalingstatechange getter can only be used on instances of RTCPeerConnection
    2020TypeError: The RTCPeerConnection.oniceconnectionstatechange getter can only be used on instances of RTCPeerConnection
  • trunk/LayoutTests/webrtc/stun-server-filtering.html

    r256024 r270101  
    33<script src='../resources/testharnessreport.js'></script>
    44<script>
    5 test((test) => {
     5promise_test(async (test) => {
    66    let pc = new RTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'stun:blabla.local']}]});
     7    let promise = new Promise(resolve => pc.onicecandidateerror = resolve);
    78    let configuration = pc.getConfiguration();
    89
    910    assert_equals(configuration.iceServers[0].urls.length, 1);
    1011    assert_equals(configuration.iceServers[0].urls[0], 'stun:foo.com');
     12
     13    const event = await promise;
     14    assert_equals(event.url, 'stun:blabla.local');
     15    assert_equals(event.errorCode, 701);
    1116}, "RTCPeerConnection and local STUN server");
    1217
    13 test((test) => {
     18promise_test(async (test) => {
    1419    let pc = new RTCPeerConnection({iceServers:[{username: 'test', credential: 'test', urls:['turn:foo.com', 'turn:blabla.local']}]});
     20    let promise = new Promise(resolve => pc.onicecandidateerror = resolve);
    1521    let configuration = pc.getConfiguration();
    1622
    1723    assert_equals(configuration.iceServers[0].urls.length, 1);
    1824    assert_equals(configuration.iceServers[0].urls[0], 'turn:foo.com');
     25
     26    const event = await promise;
     27    assert_equals(event.url, 'turn:blabla.local');
     28    assert_equals(event.errorCode, 701);
    1929}, "RTCPeerConnection and local TURN server");
    2030</script>
  • trunk/Source/WebCore/CMakeLists.txt

    r269984 r270101  
    390390    Modules/mediastream/RTCOfferOptions.idl
    391391    Modules/mediastream/RTCPeerConnection.idl
     392    Modules/mediastream/RTCPeerConnectionIceErrorEvent.idl
    392393    Modules/mediastream/RTCPeerConnectionIceEvent.idl
    393394    Modules/mediastream/RTCPeerConnectionState.idl
  • trunk/Source/WebCore/ChangeLog

    r270073 r270101  
     12020-11-20  Youenn Fablet  <youenn@apple.com>
     2
     3        Add support for RTCPeerConnection.onicecandidateerror event
     4        https://bugs.webkit.org/show_bug.cgi?id=169644
     5
     6        Reviewed by Alex Christensen.
     7
     8        Expose RTCPeerConnection.onicecandidateerror and use it for wrong STUN/TURN server URLs.
     9        For that matter, add RTCPeerConnectionIceErrorEvent as per spec with a slight change to the init directory to keep the same terminology between event and init dictionary.
     10
     11        Covered by updated webrtc/stun-server-filtering.html test.
     12
     13        * CMakeLists.txt:
     14        * DerivedSources-input.xcfilelist:
     15        * DerivedSources-output.xcfilelist:
     16        * DerivedSources.make:
     17        * Modules/mediastream/RTCPeerConnection.cpp:
     18        (WebCore::RTCPeerConnection::iceServersFromConfiguration):
     19        (WebCore::iceServersFromConfiguration): Deleted.
     20        * Modules/mediastream/RTCPeerConnection.h:
     21        * Modules/mediastream/RTCPeerConnection.idl:
     22        * Modules/mediastream/RTCPeerConnectionIceErrorEvent.cpp: Added.
     23        (WebCore::RTCPeerConnectionIceErrorEvent::create):
     24        (WebCore::RTCPeerConnectionIceErrorEvent::RTCPeerConnectionIceErrorEvent):
     25        (WebCore::RTCPeerConnectionIceErrorEvent::eventInterface const):
     26        * Modules/mediastream/RTCPeerConnectionIceErrorEvent.h: Added.
     27        * Modules/mediastream/RTCPeerConnectionIceErrorEvent.idl: Added.
     28        * Sources.txt:
     29        * WebCore.xcodeproj/project.pbxproj:
     30        * bindings/js/WebCoreBuiltinNames.h:
     31        * dom/EventNames.h:
     32        * dom/EventNames.in:
     33
    1342020-11-16  Sergio Villar Senin  <svillar@igalia.com>
    235
  • trunk/Source/WebCore/DerivedSources-input.xcfilelist

    r269999 r270101  
    221221$(PROJECT_DIR)/Modules/mediastream/RTCPeerConnection.idl
    222222$(PROJECT_DIR)/Modules/mediastream/RTCPeerConnection.js
     223$(PROJECT_DIR)/Modules/mediastream/RTCPeerConnectionIceErrorEvent.idl
    223224$(PROJECT_DIR)/Modules/mediastream/RTCPeerConnectionIceEvent.idl
    224225$(PROJECT_DIR)/Modules/mediastream/RTCPeerConnectionInternals.js
  • trunk/Source/WebCore/DerivedSources-output.xcfilelist

    r269880 r270101  
    16781678$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSRTCPeerConnection.cpp
    16791679$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSRTCPeerConnection.h
     1680$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSRTCPeerConnectionIceErrorEvent.cpp
     1681$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSRTCPeerConnectionIceErrorEvent.h
    16801682$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSRTCPeerConnectionIceEvent.cpp
    16811683$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSRTCPeerConnectionIceEvent.h
  • trunk/Source/WebCore/DerivedSources.make

    r269999 r270101  
    247247    $(WebCore)/Modules/mediastream/RTCPeerConnection.idl \
    248248    $(WebCore)/Modules/mediastream/RTCPeerConnectionIceEvent.idl \
     249    $(WebCore)/Modules/mediastream/RTCPeerConnectionIceErrorEvent.idl \
    249250    $(WebCore)/Modules/mediastream/RTCPeerConnectionState.idl \
    250251    $(WebCore)/Modules/mediastream/RTCPriorityType.idl \
  • trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp

    r266468 r270101  
    5555#include "RTCIceCandidateInit.h"
    5656#include "RTCOfferOptions.h"
     57#include "RTCPeerConnectionIceErrorEvent.h"
    5758#include "RTCPeerConnectionIceEvent.h"
    5859#include "RTCSessionDescription.h"
     
    330331
    331332// Implementation of https://w3c.github.io/webrtc-pc/#set-pc-configuration
    332 static inline ExceptionOr<Vector<MediaEndpointConfiguration::IceServerInfo>> iceServersFromConfiguration(RTCConfiguration& newConfiguration, const RTCConfiguration* existingConfiguration, bool isLocalDescriptionSet)
     333ExceptionOr<Vector<MediaEndpointConfiguration::IceServerInfo>> RTCPeerConnection::iceServersFromConfiguration(RTCConfiguration& newConfiguration, const RTCConfiguration* existingConfiguration, bool isLocalDescriptionSet)
    333334{
    334335    if (existingConfiguration && newConfiguration.bundlePolicy != existingConfiguration->bundlePolicy)
     
    352353            });
    353354
    354             urls.removeAllMatching([](auto& url) {
    355                 return URL { URL { }, url }.path().endsWithIgnoringASCIICase(".local");
     355            urls.removeAllMatching([&](auto& urlString) {
     356                URL url { URL { }, urlString };
     357                if (url.path().endsWithIgnoringASCIICase(".local") || !portAllowed(url)) {
     358                    queueTaskToDispatchEvent(*this, TaskSource::MediaElement, RTCPeerConnectionIceErrorEvent::create(Event::CanBubble::No, Event::IsCancelable::No, { }, { }, WTFMove(urlString), 701, "URL is not allowed"_s));
     359                    return true;
     360                }
     361                return false;
    356362            });
    357363
  • trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h

    r266511 r270101  
    223223    friend class RTCRtpSender;
    224224
     225    ExceptionOr<Vector<MediaEndpointConfiguration::IceServerInfo>> iceServersFromConfiguration(RTCConfiguration& newConfiguration, const RTCConfiguration* existingConfiguration, bool isLocalDescriptionSet);
     226
    225227    bool m_isStopped { false };
    226228    RTCSignalingState m_signalingState { RTCSignalingState::Stable };
  • trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl

    r267813 r270101  
    114114    attribute EventHandler onicegatheringstatechange;
    115115    attribute EventHandler onconnectionstatechange;
    116     // FIXME 169644: missing onfingerprintfailure and onicecandidateerror
     116    attribute EventHandler onicecandidateerror;
    117117
    118118    // 4.11 Certificate management
  • trunk/Source/WebCore/Sources.txt

    r270064 r270101  
    163163Modules/mediastream/RTCPeerConnection.cpp
    164164Modules/mediastream/RTCPeerConnectionIceEvent.cpp
     165Modules/mediastream/RTCPeerConnectionIceErrorEvent.cpp
    165166Modules/mediastream/RTCRtpReceiver.cpp
    166167Modules/mediastream/RTCRtpSFrameTransform.cpp
     
    33123313JSRTCPeerConnection.cpp
    33133314JSRTCPeerConnectionIceEvent.cpp
     3315JSRTCPeerConnectionIceErrorEvent.cpp
    33143316JSRTCPeerConnectionState.cpp
    33153317JSRTCPriorityType.cpp
  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r270067 r270101  
    11271127                419BC2DF1685329900D64D6D /* VisitedLinkState.h in Headers */ = {isa = PBXBuildFile; fileRef = 419BC2DD1685329900D64D6D /* VisitedLinkState.h */; };
    11281128                419BE7591BC7F42B00E1C85B /* WebCoreBuiltinNames.h in Headers */ = {isa = PBXBuildFile; fileRef = 419BE7521BC7F3DB00E1C85B /* WebCoreBuiltinNames.h */; };
     1129                419E6EC92566D278002B5010 /* RTCPeerConnectionIceErrorEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = 419E6EC72566D214002B5010 /* RTCPeerConnectionIceErrorEvent.h */; };
    11291130                41A0829C22935F3D008426E0 /* FeaturePolicy.h in Headers */ = {isa = PBXBuildFile; fileRef = 41A0829922932EF4008426E0 /* FeaturePolicy.h */; settings = {ATTRIBUTES = (Private, ); }; };
    11301131                41A1B01C1E54239B007F3769 /* JSDOMGuardedObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 41A1B01A1E542396007F3769 /* JSDOMGuardedObject.h */; settings = {ATTRIBUTES = (Private, ); }; };
     
    77727773                419D9305255E842700DA1984 /* CryptoUtilitiesCocoa.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CryptoUtilitiesCocoa.h; sourceTree = "<group>"; };
    77737774                419D9307255E842800DA1984 /* CryptoUtilitiesCocoa.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = CryptoUtilitiesCocoa.cpp; sourceTree = "<group>"; };
     7775                419E6EC42566D211002B5010 /* RTCPeerConnectionIceErrorEvent.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = RTCPeerConnectionIceErrorEvent.idl; sourceTree = "<group>"; };
     7776                419E6EC62566D213002B5010 /* RTCPeerConnectionIceErrorEvent.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = RTCPeerConnectionIceErrorEvent.cpp; sourceTree = "<group>"; };
     7777                419E6EC72566D214002B5010 /* RTCPeerConnectionIceErrorEvent.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RTCPeerConnectionIceErrorEvent.h; sourceTree = "<group>"; };
    77747778                419FAFAD1ABABCD5005B3572 /* ReadableStreamBYOBReader.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = ReadableStreamBYOBReader.idl; sourceTree = "<group>"; };
    77757779                419FAFAD1ABABCD5005B828B /* ReadableStreamDefaultReader.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = ReadableStreamDefaultReader.idl; sourceTree = "<group>"; };
     
    1712117125                                07221B7817CEC32700848E51 /* RTCPeerConnection.h */,
    1712217126                                07221B7917CEC32700848E51 /* RTCPeerConnection.idl */,
     17127                                419E6EC62566D213002B5010 /* RTCPeerConnectionIceErrorEvent.cpp */,
     17128                                419E6EC72566D214002B5010 /* RTCPeerConnectionIceErrorEvent.h */,
     17129                                419E6EC42566D211002B5010 /* RTCPeerConnectionIceErrorEvent.idl */,
    1712317130                                07221B7417CEC32700848E51 /* RTCPeerConnectionIceEvent.cpp */,
    1712417131                                07221B7517CEC32700848E51 /* RTCPeerConnectionIceEvent.h */,
     
    3422834235                                078E092517D14D1C00420AA1 /* RTCPeerConnection.h in Headers */,
    3422934236                                078E094217D16E1C00420AA1 /* RTCPeerConnectionHandlerClient.h in Headers */,
     34237                                419E6EC92566D278002B5010 /* RTCPeerConnectionIceErrorEvent.h in Headers */,
    3423034238                                078E092417D14D1C00420AA1 /* RTCPeerConnectionIceEvent.h in Headers */,
    3423134239                                412DE4B8219285C00075F3A7 /* RTCRtpCapabilities.h in Headers */,
  • trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h

    r269880 r270101  
    220220    macro(RTCPeerConnection) \
    221221    macro(RTCPeerConnectionIceEvent) \
     222    macro(RTCPeerConnectionIceErrorEvent) \
    222223    macro(RTCRtpReceiver) \
    223224    macro(RTCRtpSFrameTransform) \
  • trunk/Source/WebCore/dom/EventNames.h

    r267744 r270101  
    145145    macro(hashchange) \
    146146    macro(icecandidate) \
     147    macro(icecandidateerror) \
    147148    macro(iceconnectionstatechange) \
    148149    macro(icegatheringstatechange) \
  • trunk/Source/WebCore/dom/EventNames.in

    r268762 r270101  
    5858PaymentMethodChangeEvent conditional=PAYMENT_REQUEST
    5959PaymentRequestUpdateEvent conditional=PAYMENT_REQUEST
     60RTCPeerConnectionIceErrorEvent conditional=WEB_RTC
    6061RTCPeerConnectionIceEvent conditional=WEB_RTC
    6162RTCDataChannelEvent conditional=WEB_RTC
    6263RTCDTMFToneChangeEvent conditional=WEB_RTC
    63 RTCPeerConnectionIceEvent conditional=WEB_RTC
    6464RTCTrackEvent conditional=WEB_RTC
    6565SpeechRecognitionErrorEvent
Note: See TracChangeset for help on using the changeset viewer.