Changeset 270138 in webkit

Timestamp:

Nov 20, 2020 4:51:51 PM (3 years ago)

Author:

Dewei Zhu

Message:

Fix a bug that platform groups cannot be updated on 'admin/platform'.
​https://bugs.webkit.org/show_bug.cgi?id=219118

Reviewed by Ryosuke Niwa.

Admins should be able to update platform group on 'admin/platform'.
Update the assertion on BuildbotTriggerable._pullBuildbotOnAllSyncers so that when there is no
corresponding entry in buildRequestByGroup, the test group for the request should be finished.

• public/admin/platforms.php:
• tools/js/buildbot-triggerable.js: Updated the assert statement.

(BuildbotTriggerable.prototype._pullBuildbotOnAllSyncers):

Location:

trunk/Websites/perf.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• public/admin/platforms.php (modified) (1 diff)
• tools/js/buildbot-triggerable.js (modified) (1 diff)

trunk/Websites/perf.webkit.org/ChangeLog

@@ +1 @@
+2020-11-18  Dewei Zhu  <dewei_zhu@apple.com>
+
+        Fix a bug that platform groups cannot be updated on 'admin/platform'.
+        https://bugs.webkit.org/show_bug.cgi?id=219118
+
+        Reviewed by Ryosuke Niwa.
+
+        Admins should be able to update platform group on 'admin/platform'.
+        Update the assertion on BuildbotTriggerable._pullBuildbotOnAllSyncers so that when there is no
+        corresponding entry in buildRequestByGroup, the test group for the request should be finished.
+
+        * public/admin/platforms.php:
+        * tools/js/buildbot-triggerable.js: Updated the assert statement.
+        (BuildbotTriggerable.prototype._pullBuildbotOnAllSyncers):
+
 2020-11-16  Dewei Zhu  <dewei_zhu@apple.com>
 

trunk/Websites/perf.webkit.org/public/admin/platforms.php

@@ -60 +60 @@
     if ($action == 'update') {
         if (update_field('platforms', 'platform', 'name')
-            || update_boolean_field('platforms', 'platform', 'hidden')
-            || update_field('platforms', 'platform', 'hidden')
-            || update_field('platforms', 'platform', 'group'))
+            || update_field('platforms', 'platform', 'group')
+            || update_boolean_field('platforms', 'platform', 'hidden'))
             regenerate_manifest();
         else

trunk/Websites/perf.webkit.org/tools/js/buildbot-triggerable.js

@@ -180 +180 @@
                     const info = buildReqeustsByGroup.get(request.testGroupId());
                     if (!info) {
-                        assert(request.hasFinished());
+                        assert(request.testGroup().hasFinished());
                         continue;
                     }