Changeset 270140 in webkit
- Timestamp:
- Nov 20, 2020 5:27:13 PM (3 years ago)
- Location:
- trunk/Websites/perf.webkit.org
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Websites/perf.webkit.org/ChangeLog
r270138 r270140 1 2020-11-20 Dewei Zhu <dewei_zhu@apple.com> 2 3 'run-analysis' script should schedule retries for A/B tests even after chart analysis failure. 4 https://bugs.webkit.org/show_bug.cgi?id=219116 5 6 Reviewed by Ryosuke Niwa. 7 8 Anlyzing charts and schedule retries for A/B tests on run-analysis script are independent task. 9 It should not skip scheduling retries even when chart analysis part fails. 10 11 * tools/run-analysis.js: 12 (async analysisLoop): Change the logic so that chart analysis failure will not stop scheduling retries. 13 Fix a typo for 'notificationRemoteAPI'. 14 1 15 2020-11-18 Dewei Zhu <dewei_zhu@apple.com> 2 16 -
trunk/Websites/perf.webkit.org/tools/run-analysis.js
r236861 r270140 29 29 async function analysisLoop(options) 30 30 { 31 let secondsToSleep;31 const secondsToSleep = options['--seconds-to-sleep']; 32 32 try { 33 33 const serverConfig = JSON.parse(fs.readFileSync(options['--server-config-json'], 'utf-8')); 34 const notificationConfig = JSON.parse(fs.readFileSync(options['--notification-config-json'], 'utf-8'));35 34 const analysisRangeInDays = options['--analysis-range-in-days']; 36 const maximumRetryFactor = options['--max-retry-factor']; 37 secondsToSleep = options['--seconds-to-sleep']; 35 38 36 global.RemoteAPI = new RemoteAPI(serverConfig.server); 39 37 PrivilegedAPI.configure(serverConfig.slave.name, serverConfig.slave.password); … … 48 46 console.log(`Start analyzing last ${analysisRangeInDays} days measurement sets.`); 49 47 await analyzer.analyzeOnce(); 48 } catch (error) { 49 console.error(`Failed to analyze measurement sets due to ${error}`); 50 } 50 51 52 try { 53 const notificationConfig = JSON.parse(fs.readFileSync(options['--notification-config-json'], 'utf-8')); 54 const maximumRetryFactor = options['--max-retry-factor']; 51 55 const testGroupsMayNeedMoreRequests = await TestGroup.fetchAllThatMayNeedMoreRequests(); 52 56 await createAdditionalBuildRequestsForTestGroupsWithFailedRequests(testGroupsMayNeedMoreRequests, maximumRetryFactor); 53 57 54 58 const testGroupsNeedNotification = await TestGroup.fetchAllWithNotificationReady(); 55 const notificationRemo veAPI = new RemoteAPI(notificationConfig.notificationServerConfig);59 const notificationRemoteAPI = new RemoteAPI(notificationConfig.notificationServerConfig); 56 60 const notificationMessageConfig = notificationConfig.notificationMessageConfig; 57 61 const notifier = new AnalysisResultsNotifier(notificationMessageConfig.messageTemplate, notificationMessageConfig.finalizeScript, 58 notificationMessageConfig.messageConstructionRules, notificationRemo veAPI, notificationConfig.notificationServerConfig.path, new Subprocess);62 notificationMessageConfig.messageConstructionRules, notificationRemoteAPI, notificationConfig.notificationServerConfig.path, new Subprocess); 59 63 60 64 await notifier.sendNotificationsForTestGroups(testGroupsNeedNotification); 61 } catch (error) {62 console.error(`Failed analyze measurement sets due to ${error}`);65 } catch (error) { 66 console.error(`Failed to retry test groups due to ${error}`); 63 67 } 64 68
Note: See TracChangeset
for help on using the changeset viewer.