Changeset 270150 in webkit
- Timestamp:
- Nov 21, 2020 11:43:11 AM (3 years ago)
- Location:
- trunk
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r270149 r270150 1 2020-11-21 Antti Koivisto <antti@apple.com> 2 3 [LFC][Integration] Remove ensureLineBoxes call from RenderedPosition constructor 4 https://bugs.webkit.org/show_bug.cgi?id=219164 5 6 Reviewed by Zalan Bujtas. 7 8 * accessibility/mac/attachment-element-replacement-character-expected.txt: 9 * platform/ios/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt: 10 1 11 2020-11-21 Brian Burg <bburg@apple.com> 2 12 -
trunk/LayoutTests/accessibility/mac/attachment-element-replacement-character-expected.txt
r269745 r270150 6 6 7 7 String: 8 some [ATTACHMENT] test8 some [ATTACHMENT] test 9 9 This tests that attachment element replacements are present in strings. 10 10 -
trunk/LayoutTests/platform/ios/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt
r179104 r270150 22 22 RenderBlock {HR} at (0,198) size 784x2 [border: (1px inset #000000)] 23 23 RenderBlock {PRE} at (0,213) size 108x78 [border: (4px solid #0000FF)] 24 RenderText {#text} at (4,4) size 100x70 25 text run at (4,4) width 86: "This text" 26 text run at (89,4) width 15: " " 24 RenderText {#text} at (4,4) size 94x70 25 text run at (4,4) width 86: "This text " 27 26 text run at (4,18) width 71: "will wrap" 28 27 text run at (74,18) width 1: " " 29 text run at (4,32) width 71: "and fit" 30 text run at (74,32) width 24: " " 28 text run at (4,32) width 94: "and fit " 31 29 text run at (4,46) width 79: "within the" 32 30 text run at (82,46) width 1: " " -
trunk/Source/WebCore/ChangeLog
r270148 r270150 1 2020-11-21 Antti Koivisto <antti@apple.com> 2 3 [LFC][Integration] Remove ensureLineBoxes call from RenderedPosition constructor 4 https://bugs.webkit.org/show_bug.cgi?id=219164 5 6 Reviewed by Zalan Bujtas. 7 8 It is not needed anymore. We can use LFC line layout through the editing code. 9 10 * dom/Position.cpp: 11 (WebCore::Position::ensureLineBoxes const): Deleted. 12 * dom/Position.h: 13 * editing/RenderedPosition.cpp: 14 (WebCore::RenderedPosition::RenderedPosition): 15 * editing/RenderedPosition.h: 16 (WebCore::RenderedPosition::rootBox): Deleted. 17 1 18 2020-11-21 Aditya Keerthi <akeerthi@apple.com> 2 19 -
trunk/Source/WebCore/dom/Position.cpp
r270025 r270150 1364 1364 } 1365 1365 1366 void Position::ensureLineBoxes() const1367 {1368 auto node = deprecatedNode();1369 if (!node)1370 return;1371 auto renderer = node->renderer();1372 if (!renderer)1373 return;1374 auto* parent = renderer->parent();1375 if (is<RenderBlockFlow>(parent))1376 downcast<RenderBlockFlow>(*parent).ensureLineBoxes();1377 }1378 1379 1366 TextDirection Position::primaryDirection() const 1380 1367 { -
trunk/Source/WebCore/dom/Position.h
r270025 r270150 200 200 bool equals(const Position&) const; 201 201 202 void ensureLineBoxes() const;203 204 202 private: 205 203 // For creating legacy editing positions: (Anchor type will be determined from editingIgnoresContent(node)) -
trunk/Source/WebCore/editing/RenderedPosition.cpp
r269693 r270150 86 86 return; 87 87 88 // FIXME: Remove.89 position.ensureLineBoxes();90 91 88 auto runAndOffset = position.inlineRunAndOffset(affinity); 92 89 m_run = runAndOffset.run; -
trunk/Source/WebCore/editing/RenderedPosition.h
r269693 r270150 52 52 LayoutIntegration::LineIterator line() const { return m_run ? m_run.line() : LayoutIntegration::LineIterator(); } 53 53 54 RootInlineBox* rootBox() { return m_run ? &m_run->legacyInlineBox()->root() : nullptr; }55 56 54 unsigned char bidiLevelOnLeft() const; 57 55 unsigned char bidiLevelOnRight() const;
Note: See TracChangeset
for help on using the changeset viewer.