Changeset 270152 in webkit


Ignore:
Timestamp:
Nov 21, 2020 12:12:10 PM (3 years ago)
Author:
Simon Fraser
Message:

Add an Experimental Features for wheel event gestures becoming non-blocking
https://bugs.webkit.org/show_bug.cgi?id=219236

Reviewed by Sam Weinig.
Source/WebCore:

Add a feature flag for the behavior that is being added via webkit.org/b/218764,
which is that only the first wheel event in a gesture is cancelable.

  • platform/cocoa/VersionChecks.h:

Source/WebKit:

Add a feature flag for the behavior that is being added via webkit.org/b/218764,
which is that only the first wheel event in a gesture is cancelable.

  • Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultWheelEventGesturesBecomeNonBlocking):

  • Shared/WebPreferencesDefaultValues.h:

Source/WebKitLegacy/mac:

Add a feature flag for the behavior that is being added via webkit.org/b/218764,
which is that only the first wheel event in a gesture is cancelable.

  • WebView/WebPreferencesDefaultValues.h:
  • WebView/WebPreferencesDefaultValues.mm:

(WebKit::defaultWheelEventGesturesBecomeNonBlocking):

Source/WTF:

Add a feature flag for the behavior that is being added via webkit.org/b/218764,
which is that only the first wheel event in a gesture is cancelable.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:
Location:
trunk/Source
Files:
10 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WTF/ChangeLog

    r270132 r270152  
     12020-11-21  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Add an Experimental Features for wheel event gestures becoming non-blocking
     4        https://bugs.webkit.org/show_bug.cgi?id=219236
     5
     6        Reviewed by Sam Weinig.
     7
     8        Add a feature flag for the behavior that is being added via webkit.org/b/218764,
     9        which is that only the first wheel event in a gesture is cancelable.
     10
     11        * Scripts/Preferences/WebPreferencesExperimental.yaml:
     12
    1132020-11-20  Geoffrey Garen  <ggaren@apple.com>
    214
  • trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml

    r269897 r270152  
    10971097      default: WebKit::defaultWebXREnabled()
    10981098
     1099WheelEventGesturesBecomeNonBlocking:
     1100  type: bool
     1101  humanReadableName: "Wheel Event gestures become non-blocking"
     1102  humanReadableDescription: "preventDefault() is only allowed on the first wheel event in a gesture"
     1103  defaultValue:
     1104    WebKitLegacy:
     1105      "PLATFORM(MAC)": WebKit::defaultWheelEventGesturesBecomeNonBlocking()
     1106      default: true
     1107    WebKit:
     1108      "PLATFORM(MAC)": WebKit::defaultWheelEventGesturesBecomeNonBlocking()
     1109      default: true
     1110    WebCore:
     1111      default: true
     1112
    10991113WritableStreamAPIEnabled:
    11001114  type: bool
  • trunk/Source/WebCore/ChangeLog

    r270151 r270152  
     12020-11-21  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Add an Experimental Features for wheel event gestures becoming non-blocking
     4        https://bugs.webkit.org/show_bug.cgi?id=219236
     5
     6        Reviewed by Sam Weinig.
     7
     8        Add a feature flag for the behavior that is being added via webkit.org/b/218764,
     9        which is that only the first wheel event in a gesture is cancelable.
     10
     11        * platform/cocoa/VersionChecks.h:
     12
    1132020-11-21  Zalan Bujtas  <zalan@apple.com>
    214
  • trunk/Source/WebCore/platform/cocoa/VersionChecks.h

    r269780 r270152  
    7373    FirstWithExpiredOnlyReloadBehavior = DYLD_MACOSX_VERSION_10_13,
    7474    FirstThatDefaultsToPassiveWheelListenersOnDocument = DYLD_MACOSX_VERSION_11_3,
     75    FirstThatAllowsWheelEventGesturesToBecomeNonBlocking = DYLD_MACOSX_VERSION_11_3,
    7576    FirstWithWebIconDatabaseWarning = DYLD_MACOSX_VERSION_10_13,
    7677    FirstWithMainThreadReleaseAssertionInWebPageProxy = DYLD_MACOSX_VERSION_10_14,
  • trunk/Source/WebKit/ChangeLog

    r270142 r270152  
     12020-11-21  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Add an Experimental Features for wheel event gestures becoming non-blocking
     4        https://bugs.webkit.org/show_bug.cgi?id=219236
     5
     6        Reviewed by Sam Weinig.
     7
     8        Add a feature flag for the behavior that is being added via webkit.org/b/218764,
     9        which is that only the first wheel event in a gesture is cancelable.
     10
     11        * Shared/WebPreferencesDefaultValues.cpp:
     12        (WebKit::defaultWheelEventGesturesBecomeNonBlocking):
     13        * Shared/WebPreferencesDefaultValues.h:
     14
    1152020-11-21  Jiewen Tan  <jiewen_tan@apple.com>
    216
  • trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp

    r269865 r270152  
    6161}
    6262
     63bool defaultWheelEventGesturesBecomeNonBlocking()
     64{
     65    static bool result = linkedOnOrAfter(WebCore::SDKVersion::FirstThatAllowsWheelEventGesturesToBecomeNonBlocking);
     66    return result;
     67}
     68
    6369#endif
    6470
  • trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h

    r269865 r270152  
    5050#if PLATFORM(MAC)
    5151bool defaultPassiveWheelListenersAsDefaultOnDocument();
     52bool defaultWheelEventGesturesBecomeNonBlocking();
    5253#endif
    5354
  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r270069 r270152  
     12020-11-21  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Add an Experimental Features for wheel event gestures becoming non-blocking
     4        https://bugs.webkit.org/show_bug.cgi?id=219236
     5
     6        Reviewed by Sam Weinig.
     7       
     8        Add a feature flag for the behavior that is being added via webkit.org/b/218764,
     9        which is that only the first wheel event in a gesture is cancelable.
     10
     11        * WebView/WebPreferencesDefaultValues.h:
     12        * WebView/WebPreferencesDefaultValues.mm:
     13        (WebKit::defaultWheelEventGesturesBecomeNonBlocking):
     14
    1152020-11-19  Hoa Dinh  <dvh@apple.com>
    216
  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h

    r269780 r270152  
    8585#if PLATFORM(MAC)
    8686bool defaultPassiveWheelListenersAsDefaultOnDocument();
     87bool defaultWheelEventGesturesBecomeNonBlocking();
    8788#endif
    8889
  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm

    r269780 r270152  
    292292}
    293293
     294bool defaultWheelEventGesturesBecomeNonBlocking()
     295{
     296    static bool result = linkedOnOrAfter(WebCore::SDKVersion::FirstThatAllowsWheelEventGesturesToBecomeNonBlocking);
     297    return result;
     298}
     299
    294300#endif
    295301
Note: See TracChangeset for help on using the changeset viewer.