Changeset 270418 in webkit

Timestamp:

Dec 3, 2020 4:31:23 PM (3 years ago)

Author:

Brent Fulgham

Message:

[macOS] Only extend access to the AppleSNBFBUserClient IOKit class if the GPU Process is not used
​https://bugs.webkit.org/show_bug.cgi?id=219014
<rdar://problem/70463873>

Reviewed by Per Arne Vollan.

Instead of globally extending access to the AppleSNBFBUserClient IOKit class,
only extend it when the GPU process is not in use.

• UIProcess/WebPageProxy.cpp:

(WebKit::gpuIOKitClasses): Add 'AppleSNBFBUserClient' as a dynamically-extended
IOKit class.

• WebProcess/com.apple.WebProcess.sb.in: Only allow 'AppleSNBFBUserClient' if it

was dynamically extended.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)
• WebProcess/com.apple.WebProcess.sb.in (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-12-03  Brent Fulgham  <bfulgham@apple.com>
+
+        [macOS] Only extend access to the AppleSNBFBUserClient IOKit class if the GPU Process is not used
+        https://bugs.webkit.org/show_bug.cgi?id=219014
+        <rdar://problem/70463873>
+
+        Reviewed by Per Arne Vollan.
+
+        Instead of globally extending access to the AppleSNBFBUserClient IOKit class,
+        only extend it when the GPU process is not in use.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::gpuIOKitClasses): Add 'AppleSNBFBUserClient' as a dynamically-extended
+        IOKit class.
+        * WebProcess/com.apple.WebProcess.sb.in: Only allow 'AppleSNBFBUserClient' if it
+        was dynamically extended.
+
 2020-12-03  Said Abou-Hallawa  <said@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -7743 +7743 @@
 #if PLATFORM(MAC) || PLATFORM(MACCATALYST)
         "AppleIntelMEUserClient"_s,
+        "AppleSNBFBUserClient"_s,
 #endif
     });

trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

@@ -201 +201 @@
     ;; This is needed for Encrypted Media on some hardware (MacMini8,1 for example)
     (allow iokit-open
-        (iokit-registry-entry-class "AppleSNBFBUserClient")
+        (require-all
+            (extension "com.apple.webkit.extension.iokit")
+            (iokit-registry-entry-class "AppleSNBFBUserClient")
+        )
 #if HAVE(SANDBOX_MESSAGE_FILTERING)
         (with telemetry-backtrace)
@@ -1618 +1621 @@
         (iokit-registry-entry-class
             "AppleIntelMEUserClient"
+            "AppleSNBFBUserClient"
         )
     )