Changeset 270619 in webkit


Ignore:
Timestamp:
Dec 10, 2020 3:26:15 AM (3 years ago)
Author:
jiewen_tan@apple.com
Message:

Unreviewed, build fix after r270616

Source/WebKit:

Adds a platform have flag.

  • Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
  • UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.h:
  • UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.mm:
  • UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:

(WebKit::AuthenticatorPresenterCoordinator::AuthenticatorPresenterCoordinator):

  • UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.h:
  • UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:

Source/WTF:

Adds a platform have flag.

  • wtf/PlatformHave.h:

LayoutTests:

Turns the modern WebAuthn feature off for this test.

  • http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html:
Location:
trunk
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r270618 r270619  
     12020-12-10  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        Unreviewed, build fix after r270616
     4
     5        Turns the modern WebAuthn feature off for this test.
     6
     7        * http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html:
     8
    192020-12-10  Rob Buis  <rbuis@igalia.com>
    210

  • trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html

    r269360 r270619  
    1 <!DOCTYPE html><!-- webkit-test-runner [ WebAuthenticationModernEnabled=true ] -->
     1<!DOCTYPE html><!-- webkit-test-runner [ WebAuthenticationModernEnabled=false ] -->
    22<title>Web Authentication API: PublicKeyCredential's [[create]] silent failure cases with a mock local authenticator.</title>
    33<script src="/resources/testharness.js"></script>

  • trunk/Source/WTF/ChangeLog

    r270613 r270619  
     12020-12-10  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        Unreviewed, build fix after r270616
     4
     5        Adds a platform have flag.
     6
     7        * wtf/PlatformHave.h:
     8
    192020-12-09  Cathie Chen  <cathiechen@igalia.com>
    210

  • trunk/Source/WTF/wtf/PlatformHave.h

    r270600 r270619  
    799799#define HAVE_LIBXSLT_FIX_FOR_RADAR_71864140 1
    800800#endif
     801
     802#if __has_include(<AuthenticationServicesCore/ASCAuthorizationPresenter.h>)
     803#define HAVE_ASC_AUTH_UI 1
     804#endif

  • trunk/Source/WebKit/ChangeLog

    r270616 r270619  
     12020-12-10  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        Unreviewed, build fix after r270616
     4
     5        Adds a platform have flag.
     6
     7        * Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
     8        * UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.h:
     9        * UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.mm:
     10        * UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:
     11        (WebKit::AuthenticatorPresenterCoordinator::AuthenticatorPresenterCoordinator):
     12        * UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.h:
     13        * UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:
     14
    1152020-12-10  Jiewen Tan  <jiewen_tan@apple.com>
    216

  • trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h

    r270616 r270619  
    2626#pragma once
    2727
    28 #if PLATFORM(IOS)
     28#if HAVE(ASC_AUTH_UI)
    2929
    3030#if USE(APPLE_INTERNAL_SDK)
    … …  
    135135#endif // USE(APPLE_INTERNAL_SDK)
    136136
    137 #endif // PLATFORM(IOS)
     137#endif // HAVE(ASC_AUTH_UI)

  • trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.h

    r270616 r270619  
    2929#import <wtf/SoftLinking.h>
    3030
    31 #if PLATFORM(IOS)
     31#if HAVE(ASC_AUTH_UI)
    3232
    3333SOFT_LINK_FRAMEWORK_FOR_HEADER(WebKit, AuthenticationServicesCore);
    … …  
    3838SOFT_LINK_CLASS_FOR_HEADER(WebKit, ASCSecurityKeyPublicKeyCredentialLoginChoice);
    3939
    40 #endif // PLATFORM(IOS)
     40#endif // HAVE(ASC_AUTH_UI)

  • trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.mm

    r270616 r270619  
    2929#import <wtf/SoftLinking.h>
    3030
    31 #if PLATFORM(IOS)
     31#if HAVE(ASC_AUTH_UI)
    3232
    3333SOFT_LINK_PRIVATE_FRAMEWORK_FOR_SOURCE(WebKit, AuthenticationServicesCore);
    … …  
    3838SOFT_LINK_CLASS_FOR_SOURCE(WebKit, AuthenticationServicesCore, ASCSecurityKeyPublicKeyCredentialLoginChoice);
    3939
    40 #endif // PLATFORM(IOS)
     40#endif // HAVE(ASC_AUTH_UI)

  • trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm

    r270616 r270619  
    4242    : m_manager(makeWeakPtr(manager))
    4343{
    44 #if PLATFORM(IOS)
     44#if HAVE(ASC_AUTH_UI)
    4545    auto presentationContext = adoptNS([allocASCAuthorizationPresentationContextInstance() initWithRequestContext:nullptr appIdentifier:nullptr]);
    4646    [presentationContext setRelyingPartyIdentifier: rpId];
    … …  
    7777    });
    7878    [m_presenter presentAuthorizationWithContext:presentationContext.get() completionHandler:completionHandler.get()];
    79 #else
    80     notImplemented();
    81 #endif // PLATFORM(IOS)
     79#endif // HAVE(ASC_AUTH_UI)
    8280}
    8381

  • trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.h

    r270616 r270619  
    2626#pragma once
    2727
    28 #if ENABLE(WEB_AUTHN) && PLATFORM(IOS)
     28#if ENABLE(WEB_AUTHN) && HAVE(ASC_AUTH_UI)
    2929
    3030#import "AuthenticationServicesCoreSPI.h"
    … …  
    4444NS_ASSUME_NONNULL_END
    4545
    46 #endif // ENABLE(WEB_AUTHN) && PLATFORM(IOS)
     46#endif // ENABLE(WEB_AUTHN) && HAVE(ASC_AUTH_UI)

  • trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm

    r270616 r270619  
    2727#import "WKASCAuthorizationPresenterDelegate.h"
    2828
    29 #if ENABLE(WEB_AUTHN) && PLATFORM(IOS)
     29#if ENABLE(WEB_AUTHN) && HAVE(ASC_AUTH_UI)
    3030
    3131#import "AuthenticatorPresenterCoordinator.h"
    … …  
    5858NS_ASSUME_NONNULL_END
    5959
    60 #endif // ENABLE(WEB_AUTHN) && PLATFORM(IOS)
     60#endif // ENABLE(WEB_AUTHN) && HAVE(ASC_AUTH_UI)
Note: See TracChangeset for help on using the changeset viewer.