Changeset 270719 in webkit

Timestamp:

Dec 11, 2020 4:43:52 PM (3 years ago)

Author:

Tadeu Zagallo

Message:

REGRESSION (r270665): testapi failing on JSC bots
​https://bugs.webkit.org/show_bug.cgi?id=219787

Reviewed by Saam Barati.

• API/JSValueRef.cpp:

(JSValueIsString):
(JSValueIsObject):
(JSValueIsSymbol):

Location:

trunk/Source/JavaScriptCore

Files:

• API/JSValueRef.cpp (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSValueRef.cpp

@@ -151 +151 @@
     return toJS(globalObject, value).isString();
 #else
-    return toJS(value).isString();
+    return value && toJS(value).isString();
 #endif
 }
@@ -166 +166 @@
     return toJS(globalObject, value).isObject();
 #else
-    return toJS(value).isObject();
+    return value && toJS(value).isObject();
 #endif
 }
@@ -181 +181 @@
     return toJS(globalObject, value).isSymbol();
 #else
-    return toJS(value).isSymbol();
+    return value && toJS(value).isSymbol();
 #endif
 }

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-12-11  Tadeu Zagallo  <tzagallo@apple.com>
+
+        REGRESSION (r270665): testapi failing on JSC bots
+        https://bugs.webkit.org/show_bug.cgi?id=219787
+
+        Reviewed by Saam Barati.
+
+        * API/JSValueRef.cpp:
+        (JSValueIsString):
+        (JSValueIsObject):
+        (JSValueIsSymbol):
+
 2020-12-11  Caio Lima  <ticaiolima@gmail.com>