Changeset 271418 in webkit

Timestamp:

Jan 12, 2021 2:47:50 PM (3 years ago)

Author:

eric.carlson@apple.com

Message:

[Mac] Add runtime logging to format reader and WebM parser
​https://bugs.webkit.org/show_bug.cgi?id=220423
<rdar://problem/72896655>

Unreviewed, address post-review comments after r271270.

• dom/Document.cpp:

(WebCore::Document::addToDocumentsMap): ASSERT that document was not already in the map.
(WebCore::Document::Document): Move ASSERT to addToDocumentsMap.

• dom/Document.h:

• platform/graphics/cocoa/SourceBufferParserWebM.cpp:

(WTF::LogArgument<webm::TrackType>::toString): Return ASCIILiteral instead of String.
(WTF::LogArgument<webm::Id>::toString): Ditto.
(WTF::LogArgument<WebCore::SourceBufferParserWebM::State>::toString): Ditto.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (2 diffs)
• dom/Document.h (modified) (1 diff)
• platform/graphics/cocoa/SourceBufferParserWebM.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-01-12  Eric Carlson  <eric.carlson@apple.com>
+
+        [Mac] Add runtime logging to format reader and WebM parser
+        https://bugs.webkit.org/show_bug.cgi?id=220423
+        <rdar://problem/72896655>
+
+        Unreviewed, address post-review comments after r271270.
+
+        * dom/Document.cpp:
+        (WebCore::Document::addToDocumentsMap): ASSERT that document was not already in the map.
+        (WebCore::Document::Document): Move ASSERT to addToDocumentsMap.
+        * dom/Document.h:
+
+        * platform/graphics/cocoa/SourceBufferParserWebM.cpp:
+        (WTF::LogArgument<webm::TrackType>::toString): Return ASCIILiteral instead of String.
+        (WTF::LogArgument<webm::Id>::toString): Ditto.
+        (WTF::LogArgument<WebCore::SourceBufferParserWebM::State>::toString): Ditto.
+
 2021-01-12  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -551 +551 @@
 }
 
-auto Document::addToDocumentsMap() -> DocumentsMap::AddResult
+void Document::addToDocumentsMap()
 {
     auto addResult = allDocumentsMap().add(m_identifier, this);
+    ASSERT_UNUSED(addResult, addResult.isNewEntry);
+
     configureSharedLogger();
-    
-    return addResult;
 }
 
@@ -640 +640 @@
     , m_selection(makeUniqueRef<FrameSelection>(this))
 {
-    auto addResult = addToDocumentsMap();
-    ASSERT_UNUSED(addResult, addResult.isNewEntry);
+    addToDocumentsMap();
 
     // We depend on the url getting immediately set in subframes, but we

trunk/Source/WebCore/dom/Document.h

@@ -1722 +1722 @@
     static void configureSharedLogger();
 
-    DocumentsMap::AddResult addToDocumentsMap();
+    void addToDocumentsMap();
     void removeFromDocumentsMap();
 

trunk/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp

@@ -63 +63 @@
 
 template<> struct LogArgument<webm::TrackType> {
-    static String toString(webm::TrackType type)
+    static ASCIILiteral toString(webm::TrackType type)
     {
         switch (type) {
@@ -79 +79 @@
 
 template<> struct LogArgument<webm::Id> {
-    static String toString(webm::Id id)
+    static ASCIILiteral toString(webm::Id id)
     {
         switch (id) {
@@ -236 +236 @@
 
 template<> struct LogArgument<WebCore::SourceBufferParserWebM::State> {
-    static String toString(WebCore::SourceBufferParserWebM::State state)
+    static ASCIILiteral toString(WebCore::SourceBufferParserWebM::State state)
     {
         switch (state) {