Changeset 271420 in webkit

Timestamp:

Jan 12, 2021 4:05:54 PM (3 years ago)

Author:

Caio Lima

Message:

[ESNext] super accesses broken on arrow functions defined as class field
​https://bugs.webkit.org/show_bug.cgi?id=220558

Reviewed by Darin Adler.

JSTests:

• stress/class-field-arrow-function-using-super.js: Added.

Source/JavaScriptCore:

We need to properly set isClassContext for class fields
initialization.

• bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::generateUnlinkedFunctionCodeBlock):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/class-field-arrow-function-using-super.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2021-01-12  Caio Lima  <ticaiolima@gmail.com>
+
+        [ESNext] super accesses broken on arrow functions defined as class field
+        https://bugs.webkit.org/show_bug.cgi?id=220558
+
+        Reviewed by Darin Adler.
+
+        * stress/class-field-arrow-function-using-super.js: Added.
+
 2021-01-08  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-01-12  Caio Lima  <ticaiolima@gmail.com>
+
+        [ESNext] super accesses broken on arrow functions defined as class field
+        https://bugs.webkit.org/show_bug.cgi?id=220558
+
+        Reviewed by Darin Adler.
+
+        We need to properly set `isClassContext` for class fields
+        initialization.
+
+        * bytecode/UnlinkedFunctionExecutable.cpp:
+        (JSC::generateUnlinkedFunctionCodeBlock):
+
 2021-01-12  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp

@@ -69 +69 @@
     executable->recordParse(function->features(), function->hasCapturedVariables());
 
-    bool isClassContext = executable->superBinding() == SuperBinding::Needed;
+    bool isClassContext = executable->superBinding() == SuperBinding::Needed || executable->parseMode() == SourceParseMode::ClassFieldInitializerMode;
 
     UnlinkedFunctionCodeBlock* result = UnlinkedFunctionCodeBlock::create(vm, FunctionCode, ExecutableInfo(function->usesEval(), kind == CodeForConstruct, functionKind == UnlinkedBuiltinFunction, executable->constructorKind(), scriptMode, executable->superBinding(), parseMode, executable->derivedContextType(), executable->needsClassFieldInitializer(), false, isClassContext, EvalContextType::FunctionEvalContext), codeGenerationMode);