Changeset 271449 in webkit

Timestamp:

Jan 13, 2021 12:16:23 PM (3 years ago)

Author:

commit-queue@webkit.org

Message:

[JSC] Remove the unused compilation byproducts from the wasm embedder entrypoint
​https://bugs.webkit.org/show_bug.cgi?id=220587

Patch by Xan Lopez <Xan Lopez> on 2021-01-13
Reviewed by Yusuke Suzuki.

This is just passed around uninitialized, remove it.

• wasm/WasmB3IRGenerator.h:
• wasm/WasmBBQPlan.cpp:

(JSC::Wasm::BBQPlan::didCompleteCompilation):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wasm/WasmB3IRGenerator.h (modified) (1 diff)
• wasm/WasmBBQPlan.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-01-13  Xan Lopez  <xan@igalia.com>
+
+        [JSC] Remove the unused compilation byproducts from the wasm embedder entrypoint
+        https://bugs.webkit.org/show_bug.cgi?id=220587
+
+        Reviewed by Yusuke Suzuki.
+
+        This is just passed around uninitialized, remove it.
+
+        * wasm/WasmB3IRGenerator.h:
+        * wasm/WasmBBQPlan.cpp:
+        (JSC::Wasm::BBQPlan::didCompleteCompilation):
+
 2021-01-12  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/JavaScriptCore/wasm/WasmB3IRGenerator.h

@@ -47 +47 @@
 struct CompilationContext {
     std::unique_ptr<CCallHelpers> embedderEntrypointJIT;
-    std::unique_ptr<B3::OpaqueByproducts> embedderEntrypointByproducts;
     std::unique_ptr<CCallHelpers> wasmEntrypointJIT;
     std::unique_ptr<B3::OpaqueByproducts> wasmEntrypointByproducts;

trunk/Source/JavaScriptCore/wasm/WasmBBQPlan.cpp

@@ -241 +241 @@
             embedderToWasmInternalFunction->entrypoint.compilation = makeUnique<B3::Compilation>(
                 FINALIZE_CODE(linkBuffer, B3CompilationPtrTag, "Embedder->WebAssembly entrypoint[%i] %s name %s", functionIndex, signature.toString().ascii().data(), makeString(IndexOrName(functionIndexSpace, m_moduleInformation->nameSection->get(functionIndexSpace))).ascii().data()),
-                WTFMove(context.embedderEntrypointByproducts));
+                nullptr);
         }
     }