Changeset 271515 in webkit


Ignore:
Timestamp:
Jan 15, 2021 3:23:31 AM (3 years ago)
Author:
graouts@webkit.org
Message:

REGRESSION(r269813): PLT5 regressed by 0.5%
https://bugs.webkit.org/show_bug.cgi?id=220652
<rdar://problem/71517335>

Reviewed by Antti Koivisto.

In r269813 we added support for animating more pseudo-elements besides ::after and ::before. However, the only other
pseudo-element we realistically should be supporting animations for at this juncture is ::marker. So instead of
calling Style::TreeResolver::resolvePseudoStyle() for all public pseudo-elements, we call it for ::after, ::before
and ::marker alone.

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r271514 r271515  
     12021-01-15  Antoine Quint  <graouts@webkit.org>
     2
     3        REGRESSION(r269813): PLT5 regressed by 0.5%
     4        https://bugs.webkit.org/show_bug.cgi?id=220652
     5        <rdar://problem/71517335>
     6
     7        Reviewed by Antti Koivisto.
     8
     9        In r269813 we added support for animating more pseudo-elements besides ::after and ::before. However, the only other
     10        pseudo-element we realistically should be supporting animations for at this juncture is ::marker. So instead of
     11        calling Style::TreeResolver::resolvePseudoStyle() for all public pseudo-elements, we call it for ::after, ::before
     12        and ::marker alone.
     13
     14        * style/StyleTreeResolver.cpp:
     15        (WebCore::Style::TreeResolver::resolveElement):
     16
    1172021-01-15  Rob Buis  <rbuis@igalia.com>
    218
  • trunk/Source/WebCore/style/StyleTreeResolver.cpp

    r271435 r271515  
    250250
    251251    PseudoIdToElementUpdateMap pseudoUpdates;
    252     for (PseudoId pseudoId = PseudoId::FirstPublicPseudoId; pseudoId < PseudoId::FirstInternalPseudoId; pseudoId = static_cast<PseudoId>(static_cast<unsigned>(pseudoId) + 1)) {
    253         if (auto elementUpdate = resolvePseudoStyle(element, update, pseudoId))
    254             pseudoUpdates.set(pseudoId, WTFMove(*elementUpdate));
    255     }
     252    if (auto beforeElementUpdate = resolvePseudoStyle(element, update, PseudoId::Before))
     253        pseudoUpdates.set(PseudoId::Before, WTFMove(*beforeElementUpdate));
     254    if (auto afterElementUpdate = resolvePseudoStyle(element, update, PseudoId::After))
     255        pseudoUpdates.set(PseudoId::After, WTFMove(*afterElementUpdate));
     256    if (auto markerElementUpdate = resolvePseudoStyle(element, update, PseudoId::Marker))
     257        pseudoUpdates.set(PseudoId::Marker, WTFMove(*markerElementUpdate));
    256258
    257259#if ENABLE(TOUCH_ACTION_REGIONS)
Note: See TracChangeset for help on using the changeset viewer.