Changeset 271671 in webkit

Timestamp:

Jan 20, 2021 1:41:50 PM (3 years ago)

Author:

Manuel Rego Casasnovas

Message:

[WPE] focus-visible-003.html and focus-visible-004.html are timing out in input tags
​https://bugs.webkit.org/show_bug.cgi?id=220578

Reviewed by Javier Fernandez.

Source/WebCore:

Dispatch "focus" event for form controls when they are focused via mouse click.
This was already done in GTK+ but was not yet in WPE.

This works different on Mac ports as it's a particularity of how focus works on Mac platforms
(see ​https://webkit.org/b/22261 for details).

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isMouseFocusable const): Add PLATFORM(WPE).

LayoutTests:

• platform/wpe/TestExpectations: Unskip tests that are not failing anymore.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/wpe/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLFormControlElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-01-20  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [WPE] focus-visible-003.html and focus-visible-004.html are timing out in input tags
+        https://bugs.webkit.org/show_bug.cgi?id=220578
+
+        Reviewed by Javier Fernandez.
+
+        * platform/wpe/TestExpectations: Unskip tests that are not failing anymore.
+
 2021-01-20  Alex Christensen  <achristensen@webkit.org>
 

trunk/LayoutTests/platform/wpe/TestExpectations

@@ -167 +167 @@
 # Flexbox layout
 webkit.org/b/215502 fast/flexbox/image-percent-max-height.html [ Failure Pass ImageOnlyFailure ]
-
-# Focus-visible
-webkit.org/b/220578 imported/w3c/web-platform-tests/css/selectors/focus-visible-003.html [ Failure ]
-webkit.org/b/220578 imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Failure ]
 
 # Link target

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-01-20  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [WPE] focus-visible-003.html and focus-visible-004.html are timing out in input tags
+        https://bugs.webkit.org/show_bug.cgi?id=220578
+
+        Reviewed by Javier Fernandez.
+
+        Dispatch "focus" event for form controls when they are focused via mouse click.
+        This was already done in GTK+ but was not yet in WPE.
+
+        This works different on Mac ports as it's a particularity of how focus works on Mac platforms
+        (see https://webkit.org/b/22261 for details).
+
+        * html/HTMLFormControlElement.cpp:
+        (WebCore::HTMLFormControlElement::isMouseFocusable const): Add PLATFORM(WPE).
+
 2021-01-20  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/html/HTMLFormControlElement.cpp

@@ -392 +392 @@
 bool HTMLFormControlElement::isMouseFocusable() const
 {
-#if PLATFORM(GTK)
+#if (PLATFORM(GTK) || PLATFORM(WPE))
     return HTMLElement::isMouseFocusable();
 #else