Changeset 272193 in webkit


Ignore:
Timestamp:
Feb 2, 2021 12:10:30 AM (3 years ago)
Author:
commit-queue@webkit.org
Message:

Support aspect-ratio on <body> in quirks mode
​https://bugs.webkit.org/show_bug.cgi?id=219489

Patch by Rob Buis <​rbuis@igalia.com> on 2021-02-02
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update test expectation.

  • web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-001-expected.txt:

Source/WebCore:

If the logical height is auto, the actual computed height could still be
non-auto because of aspect-ratio, so add a check for that case.

Test: imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-001.html

  • rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToViewport const):

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r272125 r272193  
     12021-02-02  Rob Buis  <rbuis@igalia.com>
     2
     3        Support aspect-ratio on <body> in quirks mode
     4        https://bugs.webkit.org/show_bug.cgi?id=219489
     5
     6        Reviewed by Simon Fraser.
     7
     8        Update test expectation.
     9
     10        * web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-001-expected.txt:
     11
    1122021-01-31  Sam Weinig  <weinig@apple.com>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-001-expected.txt

    r269241 r272193  
    11
    2 FAIL body height is 100 assert_equals: expected 100 but got 584
     2PASS body height is 100
    33

  • trunk/Source/WebCore/ChangeLog

    r272190 r272193  
     12021-02-02  Rob Buis  <rbuis@igalia.com>
     2
     3        Support aspect-ratio on <body> in quirks mode
     4        https://bugs.webkit.org/show_bug.cgi?id=219489
     5
     6        Reviewed by Simon Fraser.
     7
     8        If the logical height is auto, the actual computed height could still be
     9        non-auto because of aspect-ratio, so add a check for that case.
     10
     11        Test: imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-001.html
     12
     13        * rendering/RenderBox.h:
     14        (WebCore::RenderBox::stretchesToViewport const):
     15
    1162021-02-01  Peng Liu  <peng.liu6@apple.com>
    217

  • trunk/Source/WebCore/rendering/RenderBox.h

    r271934 r272193  
    422422    bool stretchesToViewport() const
    423423    {
    424         return document().inQuirksMode() && style().logicalHeight().isAuto() && !isFloatingOrOutOfFlowPositioned() && (isDocumentElementRenderer() || isBody()) && !isInline();
     424        return document().inQuirksMode() && style().logicalHeight().isAuto() && !isFloatingOrOutOfFlowPositioned() && (isDocumentElementRenderer() || isBody()) && !shouldComputeLogicalHeightFromAspectRatio() && !isInline();
    425425    }
    426426
Note: See TracChangeset for help on using the changeset viewer.