Changeset 272927 in webkit


Ignore:
Timestamp:
Feb 16, 2021 2:01:33 PM (3 years ago)
Author:
graouts@webkit.org
Message:

REGRESSION(r271515): ::marker fired at wrong time
https://bugs.webkit.org/show_bug.cgi?id=221961
<rdar://problem/74397846>

Reviewed by Dean Jackson.

Source/WebCore:

Restore the order in which we generate CSS Animations for pseudo-elements as it was prior to r271515.

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement):

LayoutTests:

Remove flakiness for this test since it didn't allow us to spot the regression introduced by r271515.

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r272926 r272927  
     12021-02-16  Antoine Quint  <graouts@webkit.org>
     2
     3        REGRESSION(r271515): ::marker fired at wrong time
     4        https://bugs.webkit.org/show_bug.cgi?id=221961
     5        <rdar://problem/74397846>
     6
     7        Reviewed by Dean Jackson.
     8
     9        Remove flakiness for this test since it didn't allow us to spot the regression introduced by r271515.
     10
     11        * TestExpectations:
     12
    1132021-02-16  Chris Gambrell  <cgambrell@apple.com>
    214
  • trunk/LayoutTests/TestExpectations

    r272847 r272927  
    31963196# wpt css-transitions and css-animations failures and flakiness
    31973197webkit.org/b/203296 imported/w3c/web-platform-tests/css/css-animations/keyframes-remove-documentElement-crash.html [ Skip ]
    3198 webkit.org/b/203480 imported/w3c/web-platform-tests/css/css-animations/event-order.tentative.html [ Pass Failure ]
    31993198webkit.org/b/203305 imported/w3c/web-platform-tests/css/css-transitions/properties-value-001.html [ Pass Failure ]
    32003199webkit.org/b/203305 imported/w3c/web-platform-tests/css/css-transitions/properties-value-inherit-001.html [ Pass Failure ]
  • trunk/Source/WebCore/ChangeLog

    r272925 r272927  
     12021-02-16  Antoine Quint  <graouts@webkit.org>
     2
     3        REGRESSION(r271515): ::marker fired at wrong time
     4        https://bugs.webkit.org/show_bug.cgi?id=221961
     5        <rdar://problem/74397846>
     6
     7        Reviewed by Dean Jackson.
     8
     9        Restore the order in which we generate CSS Animations for pseudo-elements as it was prior to r271515.
     10
     11        * style/StyleTreeResolver.cpp:
     12        (WebCore::Style::TreeResolver::resolveElement):
     13
    1142021-02-16  Megan Gardner  <megan_gardner@apple.com>
    215
  • trunk/Source/WebCore/style/StyleTreeResolver.cpp

    r272904 r272927  
    250250
    251251    PseudoIdToElementUpdateMap pseudoUpdates;
     252    if (auto markerElementUpdate = resolvePseudoStyle(element, update, PseudoId::Marker))
     253        pseudoUpdates.set(PseudoId::Marker, WTFMove(*markerElementUpdate));
    252254    if (auto beforeElementUpdate = resolvePseudoStyle(element, update, PseudoId::Before))
    253255        pseudoUpdates.set(PseudoId::Before, WTFMove(*beforeElementUpdate));
    254256    if (auto afterElementUpdate = resolvePseudoStyle(element, update, PseudoId::After))
    255257        pseudoUpdates.set(PseudoId::After, WTFMove(*afterElementUpdate));
    256     if (auto markerElementUpdate = resolvePseudoStyle(element, update, PseudoId::Marker))
    257         pseudoUpdates.set(PseudoId::Marker, WTFMove(*markerElementUpdate));
    258258
    259259#if ENABLE(TOUCH_ACTION_REGIONS)
Note: See TracChangeset for help on using the changeset viewer.