Changeset 273197 in webkit

Timestamp:

Feb 20, 2021 2:39:06 AM (3 years ago)

Author:

commit-queue@webkit.org

Message:

Remove unused isGoogle function
​https://bugs.webkit.org/show_bug.cgi?id=222227

Patch by Rob Buis <​rbuis@igalia.com> on 2021-02-20
Reviewed by Frédéric Wang.

Remove unused (after r273084) isGoogle function.

• platform/UserAgentQuirks.cpp:

(WebCore::isGoogle): Deleted.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/UserAgentQuirks.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-20  Rob Buis  <rbuis@igalia.com>
+
+        Remove unused isGoogle function
+        https://bugs.webkit.org/show_bug.cgi?id=222227
+
+        Reviewed by Frédéric Wang.
+
+        Remove unused (after r273084) isGoogle function.
+
+        * platform/UserAgentQuirks.cpp:
+        (WebCore::isGoogle): Deleted.
+
 2021-02-19  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/UserAgentQuirks.cpp

@@ -35 +35 @@
 // When editing the quirks in this file, be sure to update
 // Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp.
-
-static bool isGoogle(const URL& url)
-{
-    String domain = url.host().toString();
-    String baseDomain = topPrivatelyControlledDomain(domain);
-
-    // Our Google UA is *very* complicated to get right. Read
-    // https://webkit.org/b/142074 carefully before changing. Test that 3D
-    // view is available in Google Maps. Test Google Calendar. Test logging out
-    // and logging in to a Google account. Change platformVersionForUAString()
-    // to return "FreeBSD amd64" and test everything again.
-    if (baseDomain.startsWith("google."))
-        return true;
-    if (baseDomain == "gstatic.com")
-        return true;
-    if (baseDomain == "googleusercontent.com")
-        return true;
-    // googleapis.com is in the public suffix list, which is confusing. E.g.
-    // fonts.googleapis.com is actually a base domain.
-    if (domain.endsWith(".googleapis.com"))
-        return true;
-
-    return false;
-}
 
 // Be careful with this quirk: it's an invitation for sites to use JavaScript