Changeset 273267 in webkit


Ignore:
Timestamp:
Feb 22, 2021 11:58:25 AM (3 years ago)
Author:
Jonathan Bedard
Message:

[git-webkit] Failure to retrieve commit in EWS
https://bugs.webkit.org/show_bug.cgi?id=222050
<rdar://problem/74439957>

Reviewed by Aakash Jain.

  • CISupport/ews-build/loadConfig.py:

(loadBuilderConfig): Load GitHub credentials.

  • CISupport/ews-build/steps.py:

(ShowIdentifier.start): Pass GitHub credentials to worker.

  • CISupport/ews-build/steps_unittest.py:
Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/CISupport/ews-build/loadConfig.py

    r271361 r273267  
    5151    checkValidSchedulers(config, config['schedulers'])
    5252
     53    for variable in ['GITHUB_COM_USERNAME', 'GITHUB_COM_ACCESS_TOKEN']:
     54        value = passwords.get(variable)
     55        if value:
     56            os.environ[variable] = value
     57
    5358    c['workers'] = [Worker(worker['name'], passwords.get(worker['name'], 'password'), max_builds=worker.get('max_builds', 1)) for worker in config['workers']]
    5459    if use_localhost_worker:
  • trunk/Tools/CISupport/ews-build/steps.py

    r273199 r273267  
    5353WithProperties = properties.WithProperties
    5454Interpolate = properties.Interpolate
     55GITHUB_COM_USERNAME = 'GITHUB_COM_USERNAME'
     56GITHUB_COM_ACCESS_TOKEN = 'GITHUB_COM_ACCESS_TOKEN'
    5557
    5658
     
    179181
    180182    def start(self):
     183        self.workerEnvironment[GITHUB_COM_USERNAME] = os.getenv(GITHUB_COM_USERNAME)
     184        self.workerEnvironment[GITHUB_COM_ACCESS_TOKEN] = os.getenv(GITHUB_COM_ACCESS_TOKEN)
     185
    181186        self.log_observer = logobserver.BufferLogObserver()
    182187        self.addLogObserver('stdio', self.log_observer)
  • trunk/Tools/CISupport/ews-build/steps_unittest.py

    r273199 r273267  
    38343834                        timeout=300,
    38353835                        logEnviron=False,
     3836                        env={'GITHUB_COM_USERNAME': None, 'GITHUB_COM_ACCESS_TOKEN': None},
    38363837                        command=['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', '51a6aec9f664']) +
    38373838            ExpectShell.log('stdio', stdout='Identifier: 233175@main') +
     
    38493850                        timeout=300,
    38503851                        logEnviron=False,
     3852                        env={'GITHUB_COM_USERNAME': None, 'GITHUB_COM_ACCESS_TOKEN': None},
    38513853                        command=['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', 'HEAD']) +
    38523854            ExpectShell.log('stdio', stdout='Unexpected failure') +
  • trunk/Tools/ChangeLog

    r273263 r273267  
     12021-02-22  Jonathan Bedard  <jbedard@apple.com>
     2
     3        [git-webkit] Failure to retrieve commit in EWS
     4        https://bugs.webkit.org/show_bug.cgi?id=222050
     5        <rdar://problem/74439957>
     6
     7        Reviewed by Aakash Jain.
     8
     9        * CISupport/ews-build/loadConfig.py:
     10        (loadBuilderConfig): Load GitHub credentials.
     11        * CISupport/ews-build/steps.py:
     12        (ShowIdentifier.start): Pass GitHub credentials to worker.
     13        * CISupport/ews-build/steps_unittest.py:
     14
    1152021-02-22  Alex Christensen  <achristensen@webkit.org>
    216
Note: See TracChangeset for help on using the changeset viewer.