Changeset 273269 in webkit

Timestamp:

Feb 22, 2021 12:15:51 PM (3 years ago)

Author:

keith_miller@apple.com

Message:

Remove unused internal fields from AbstractModuleLoader
​https://bugs.webkit.org/show_bug.cgi?id=222256

Reviewed by Saam Barati.

• runtime/AbstractModuleRecord.h:

(JSC::AbstractModuleRecord::initialValues):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/AbstractModuleRecord.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-02-22  Keith Miller  <keith_miller@apple.com>
+
+        Remove unused internal fields from AbstractModuleLoader
+        https://bugs.webkit.org/show_bug.cgi?id=222256
+
+        Reviewed by Saam Barati.
+
+        * runtime/AbstractModuleRecord.h:
+        (JSC::AbstractModuleRecord::initialValues):
+
 2021-02-21  Lauro Moura  <lmoura@igalia.com>
 

trunk/Source/JavaScriptCore/runtime/AbstractModuleRecord.h

@@ -39 +39 @@
 // Based on the Source Text Module Record
 // http://www.ecma-international.org/ecma-262/6.0/#sec-source-text-module-records
-class AbstractModuleRecord : public JSInternalFieldObjectImpl<4> {
+class AbstractModuleRecord : public JSInternalFieldObjectImpl<2> {
     friend class LLIntOffsetsExtractor;
 public:
-    using Base = JSInternalFieldObjectImpl<4>;
+    using Base = JSInternalFieldObjectImpl<2>;
 
     static constexpr bool needsDestruction = true;
@@ -58 +58 @@
     enum class Field : uint32_t {
         State,
-        Next,
-        This,
         Frame,
     };
 
-    static_assert(numberOfInternalFields == 4);
+    static_assert(numberOfInternalFields == 2);
     static std::array<JSValue, numberOfInternalFields> initialValues()
     {
         return { {
             jsNumber(static_cast<int32_t>(State::Init)),
-            jsUndefined(),
-            jsUndefined(),
             jsUndefined(),
         } };