Changeset 273289 in webkit


Ignore:
Timestamp:
Feb 22, 2021 5:10:56 PM (3 years ago)
Author:
eric.carlson@apple.com
Message:

UserMediaPermissionRequestManagerProxy may be released while computing capture device list
https://bugs.webkit.org/show_bug.cgi?id=222236
<rdar://74480265>

Unreviewed, address post-review comment.

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList): Use
captured this.

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r273288 r273289  
     12021-02-22  Eric Carlson  <eric.carlson@apple.com>
     2
     3        UserMediaPermissionRequestManagerProxy may be released while computing capture device list
     4        https://bugs.webkit.org/show_bug.cgi?id=222236
     5        <rdar://74480265>
     6
     7        Unreviewed, address post-review comment.
     8
     9        * UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
     10        (WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList): Use
     11        captured `this`.
     12
    1132021-02-22  Chris Dumez  <cdumez@apple.com>
    214
  • trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp

    r273265 r273289  
    739739        }
    740740
    741         weakThis->m_hasFilteredDeviceList = !revealIdsAndLabels;
     741        m_hasFilteredDeviceList = !revealIdsAndLabels;
    742742        ALWAYS_LOG(LOGIDENTIFIER, filteredDevices.size(), " devices revealed");
    743743
Note: See TracChangeset for help on using the changeset viewer.