Changeset 274327 in webkit


Ignore:
Timestamp:
Mar 11, 2021 10:57:44 PM (3 years ago)
Author:
Said Abou-Hallawa
Message:

[GPUP] Enable 2D Canvas in layout tests by default
​https://bugs.webkit.org/show_bug.cgi?id=222835

Reviewed by Simon Fraser.

Source/WTF:

Move UseGPUProcessForCanvasRenderingEnabled from WebPreferencesInternal
to WebPreferencesExperimental so that the WebKitTestRunner will turn it
on by default.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:
  • Scripts/Preferences/WebPreferencesInternal.yaml:

LayoutTests:

Some of the canvas layout tests are still failing when GPUP is enabled
for 2D Canvas. Skip these tests for now.

  • http/tests/canvas/color-fonts/fill-gradient-sbix-2.html:
  • http/tests/canvas/color-fonts/fill-gradient-sbix-3.html:
  • http/tests/canvas/color-fonts/fill-gradient-sbix-4.html:
  • http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html:
  • http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html:
  • http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html:

webkit.org/b/222881

  • inspector/canvas/memory.html:

webkit.org/b/222880

Location:
trunk
Files:
13 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r274323 r274327  
     12021-03-11  Said Abou-Hallawa  <said@apple.com>
     2
     3        [GPUP] Enable 2D Canvas in layout tests by default
     4        https://bugs.webkit.org/show_bug.cgi?id=222835
     5
     6        Reviewed by Simon Fraser.
     7
     8        Some of the canvas layout tests are still failing when GPUP is enabled
     9        for 2D Canvas. Skip these tests for now.
     10
     11        * TestExpectations:
     12        * gpu-process/TestExpectations:
     13
     14        * http/tests/canvas/color-fonts/fill-gradient-sbix-2.html:
     15        * http/tests/canvas/color-fonts/fill-gradient-sbix-3.html:
     16        * http/tests/canvas/color-fonts/fill-gradient-sbix-4.html:
     17        * http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html:
     18        * http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html:
     19        * http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html:
     20        webkit.org/b/222881
     21
     22        * inspector/canvas/memory.html:
     23        webkit.org/b/222880
     24
    1252021-03-11  Sihui Liu  <sihui_liu@appe.com>
    226

  • trunk/LayoutTests/TestExpectations

    r274287 r274327  
    40844084imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-from-element-swap-width-height.tentative.html [ ImageOnlyFailure ]
    40854085imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-from-element.tentative.html [ ImageOnlyFailure ]
     4086imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2.html [ Failure ]
    40864087
    40874088# Sometimes prints weird output at the beginning of the tests.

  • trunk/LayoutTests/gpu-process/TestExpectations

    r274184 r274327  
    1 # webkit.org/b/222728
    2 imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2.html [ Failure ]
    3 inspector/canvas/memory.html [ Failure ]
    4 
    51# webkit.org/b/222726
    62fast/canvas/webgl/uniform-samplers-test.html [ Slow ]

  • trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-2.html

    r274184 r274327  
     1<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
    12<!DOCTYPE html>
    23<html>

  • trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-3.html

    r274184 r274327  
     1<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
    12<!DOCTYPE html>
    23<html>

  • trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-4.html

    r274184 r274327  
     1<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
    12<!DOCTYPE html>
    23<html>

  • trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html

    r274184 r274327  
     1<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
    12<!DOCTYPE html>
    23<html>

  • trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html

    r274184 r274327  
     1<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
    12<!DOCTYPE html>
    23<html>

  • trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html

    r274184 r274327  
     1<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
    12<!DOCTYPE html>
    23<html>

  • trunk/LayoutTests/inspector/canvas/memory.html

    r274184 r274327  
     1<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
    12<!DOCTYPE html>
    23<html>

  • trunk/Source/WTF/ChangeLog

    r274325 r274327  
     12021-03-11  Said Abou-Hallawa  <said@apple.com>
     2
     3        [GPUP] Enable 2D Canvas in layout tests by default
     4        https://bugs.webkit.org/show_bug.cgi?id=222835
     5
     6        Reviewed by Simon Fraser.
     7
     8        Move UseGPUProcessForCanvasRenderingEnabled from WebPreferencesInternal
     9        to WebPreferencesExperimental so that the WebKitTestRunner will turn it
     10        on by default.
     11
     12        * Scripts/Preferences/WebPreferencesExperimental.yaml:
     13        * Scripts/Preferences/WebPreferencesInternal.yaml:
     14
    1152021-03-11  Saam Barati  <sbarati@apple.com>
    216

  • trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml

    r274184 r274327  
    923923      default: true
    924924
     925UseGPUProcessForCanvasRenderingEnabled:
     926  type: bool
     927  humanReadableName: "GPU Process: Canvas Rendering"
     928  humanReadableDescription: "Enable canvas rendering in GPU Process"
     929  webcoreBinding: none
     930  condition: ENABLE(GPU_PROCESS)
     931  exposed: [ WebKit ]
     932  defaultValue:
     933    WebKit:
     934      default: defaultUseGPUProcessForCanvasRenderingEnabled()
     935
    925936UseGPUProcessForMediaEnabled:
    926937  type: bool

  • trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml

    r274184 r274327  
    765765      default: true
    766766
    767 UseGPUProcessForCanvasRenderingEnabled:
    768   type: bool
    769   humanReadableName: "GPU Process: Canvas Rendering"
    770   humanReadableDescription: "Enable canvas rendering in GPU Process"
    771   webcoreBinding: none
    772   condition: ENABLE(GPU_PROCESS)
    773   exposed: [ WebKit ]
    774   defaultValue:
    775     WebKit:
    776       default: defaultUseGPUProcessForCanvasRenderingEnabled()
    777 
    778767UseGPUProcessForDOMRenderingEnabled:
    779768  type: bool
Note: See TracChangeset for help on using the changeset viewer.