Changeset 27435 in webkit

Timestamp:

Nov 5, 2007 6:30:59 AM (16 years ago)

Author:

ap

Message:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15841
fast/dom/Document/early-document-access.html crashes under GuardMalloc

• fast/dom/Document/early-document-access.html: Don't check for open() timeout; wait for popup window to close as long as it takes.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/dom/Document/early-document-access.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-11-05  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Darin.
+
+        http://bugs.webkit.org/show_bug.cgi?id=15841
+        fast/dom/Document/early-document-access.html crashes under GuardMalloc
+
+        * fast/dom/Document/early-document-access.html: Don't check for open() timeout;
+        wait for popup window to close as long as it takes.
+
 2007-11-03  Darin Adler  <darin@apple.com>
 

trunk/LayoutTests/fast/dom/Document/early-document-access.html

@@ -12 +12 @@
         if (newWindow) {
             newWindow.document; // access the document
-            setTimeout(fail, 5000); // fail if we take longer than 5 seconds
         } else {
             document.body.innerText = 'FAIL: window.open failed to make a window.';
-            layoutTestController.notifyDone();
+            if (window.layoutTestController)
+                layoutTestController.notifyDone();
         }
     }
 
     function done() {
-        newWindow.close();
         if (window.layoutTestController)
-            setTimeout("layoutTestController.notifyDone()", 100);
+            if (layoutTestController.windowCount() == 1)
+                layoutTestController.notifyDone();
+            else
+                setTimeout("done()", 100);
     }
 
     function pass() {
         document.body.innerText = 'PASS';
+        newWindow.close();
         done();
     }
@@ -32 +35 @@
     function fail() {
         document.body.innerText = 'FAIL';
+        newWindow.close();
         done();
     }