Changeset 275455 in webkit

Timestamp:

Apr 5, 2021 5:00:10 PM (3 years ago)

Author:

jer.noble@apple.com

Message:

[Cocoa] Calling AudioComponentFetchServerRegistrations on main thread causes launch time regression
​https://bugs.webkit.org/show_bug.cgi?id=224137
<rdar://76137483>

Reviewed by Eric Carlson.

Run the command to fetch AudioComponent registration data on a generic background queue.

• UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::sendAudioComponentRegistrations):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/WebProcessProxyCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-04-05  Jer Noble  <jer.noble@apple.com>
+
+        [Cocoa] Calling AudioComponentFetchServerRegistrations on main thread causes launch time regression
+        https://bugs.webkit.org/show_bug.cgi?id=224137
+        <rdar://76137483>
+
+        Reviewed by Eric Carlson.
+
+        Run the command to fetch AudioComponent registration data on a generic background queue.
+
+        * UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+        (WebKit::WebProcessProxy::sendAudioComponentRegistrations):
+
 2021-04-05  Christopher Reid  <chris.reid@sony.com>
 

trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm

@@ -292 +292 @@
         return;
 
-    CFDataRef registrations { nullptr };
-    if (noErr != AudioComponentFetchServerRegistrations(&registrations) || !registrations)
-        return;
-
-    auto registrationData = SharedBuffer::create(registrations);
-    send(Messages::WebProcess::ConsumeAudioComponentRegistrations({ registrationData }), 0);
-}
-
-}
+    dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), [protectedThis = makeRef(*this)] () mutable {
+        CFDataRef registrations { nullptr };
+        if (noErr != AudioComponentFetchServerRegistrations(&registrations) || !registrations)
+            return;
+
+        RunLoop::main().dispatch([protectedThis = WTFMove(protectedThis), registrations = retainPtr(registrations)] () mutable {
+            auto registrationData = SharedBuffer::create(registrations.get());
+            protectedThis->send(Messages::WebProcess::ConsumeAudioComponentRegistrations({ registrationData }), 0);
+        });
+    });
+}
+
+}