Changeset 275456 in webkit


Ignore:
Timestamp:
Apr 5, 2021 5:04:26 PM (3 years ago)
Author:
Devin Rousso
Message:

REGRESSION (r275358): [ iOS wk2 ] media/modern-media-controls/ios-inline-media-controls/ios-inline-media-dropping-controls.html is a constant text failure
​https://bugs.webkit.org/show_bug.cgi?id=224130
<rdar://problem/76164289>

Unreviewed test fix.

  • media/modern-media-controls/ios-inline-media-controls/ios-inline-media-dropping-controls.html:
  • media/modern-media-controls/ios-inline-media-controls/ios-inline-media-dropping-controls-expected.txt:

Set a maximumRightContainerButtonCountOverride so that the collapsing behavior of the
overflow button doesn't affect the test (and force a layout to ensure it's picked up).

Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r275454 r275456  
     12021-04-05  Devin Rousso  <drousso@apple.com>
     2
     3        REGRESSION (r275358): [ iOS wk2 ] media/modern-media-controls/ios-inline-media-controls/ios-inline-media-dropping-controls.html is a constant text failure
     4        https://bugs.webkit.org/show_bug.cgi?id=224130
     5        <rdar://problem/76164289>
     6
     7        Unreviewed test fix.
     8
     9        * media/modern-media-controls/ios-inline-media-controls/ios-inline-media-dropping-controls.html:
     10        * media/modern-media-controls/ios-inline-media-controls/ios-inline-media-dropping-controls-expected.txt:
     11        Set a `maximumRightContainerButtonCountOverride` so that the collapsing behavior of the
     12        overflow button doesn't affect the test (and force a layout to ensure it's picked up).
     13
    1142021-04-05  Christopher Reid  <chris.reid@sony.com>
    215

  • trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-dropping-controls-expected.txt

    r275358 r275456  
    66PASS ready() became true
    77
    8 TracksButton was dropped at 681.
    9 PiPButton was dropped at 681.
     8TracksButton was dropped at 488.
     9PiPButton was dropped at 488.
    1010SkipForwardButton was dropped at 453.
    1111SkipBackButton was dropped at 424.
    … …  
    1313AirplayButton was dropped at 357.
    1414FullscreenButton was dropped at 325.
    15 OverflowButton was dropped at 294.
    1615
    1716PASS successfullyParsed is true

  • trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-dropping-controls.html

    r275358 r275456  
    1111const mediaControls = new IOSInlineMediaControls({ width: 680, height: 300 });
    1212mediaControls.shouldUseSingleBarLayout = true;
     13mediaControls.maximumRightContainerButtonCountOverride = 100; // A finite value larger than anything likely.
     14
     15// Trigger a layout so that `maximumRightContainerButtonCountOverride` takes effect.
     16mediaControls.needsLayout = true;
     17scheduler.flushScheduledLayoutCallbacks();
    1318
    1419const droppableControls = [
    15     mediaControls.overflowButton,
    1620    mediaControls.fullscreenButton,
    1721    mediaControls.airplayButton,
Note: See TracChangeset for help on using the changeset viewer.