Changeset 275466 in webkit


Ignore:
Timestamp:
Apr 5, 2021 6:06:22 PM (3 years ago)
Author:
sbarati@apple.com
Message:

Enable QuotaExceededError on non GSTREAMER platforms
​https://bugs.webkit.org/show_bug.cgi?id=224136
<rdar://71219720>

Reviewed by Jer Noble.

Source/WebCore:

This fixes a memory leak in Disney+ where we end up queuing up the entire
video because we never communicate to the page that they should stop queuing
more data.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferInternal):

LayoutTests:

  • platform/mac/media/media-source/media-source-append-before-last-range-no-quota-exceeded-expected.txt:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r275462 r275466  
     12021-04-05  Saam Barati  <sbarati@apple.com>
     2
     3        Enable QuotaExceededError on non GSTREAMER platforms
     4        https://bugs.webkit.org/show_bug.cgi?id=224136
     5        <rdar://71219720>
     6
     7        Reviewed by Jer Noble.
     8
     9        * platform/mac/media/media-source/media-source-append-before-last-range-no-quota-exceeded-expected.txt:
     10
    1112021-04-05  Cameron McCormack  <heycam@apple.com>
    212

  • trunk/LayoutTests/platform/mac/media/media-source/media-source-append-before-last-range-no-quota-exceeded-expected.txt

    r270106 r275466  
    116116EVENT(updateend)
    117117Appending PTS=176
    118 EVENT(updateend)
    119 EXPECTED (exception == 'QuotaExceededError: The quota has been exceeded.'), OBSERVED 'null' FAIL
    120 EXPECTED (bufferedRanges() == '[ 120...176 ]'), OBSERVED '[ 120...177 ]' FAIL
     118EXPECTED (exception == 'QuotaExceededError: The quota has been exceeded.') OK
     119EXPECTED (bufferedRanges() == '[ 120...176 ]') OK
    121120EXPECTED (video.currentTime == '115') OK
    122121Appending PTS=115

  • trunk/Source/WebCore/ChangeLog

    r275465 r275466  
     12021-04-05  Saam Barati  <sbarati@apple.com>
     2
     3        Enable QuotaExceededError on non GSTREAMER platforms
     4        https://bugs.webkit.org/show_bug.cgi?id=224136
     5        <rdar://71219720>
     6
     7        Reviewed by Jer Noble.
     8
     9        This fixes a memory leak in Disney+ where we end up queuing up the entire
     10        video because we never communicate to the page that they should stop queuing
     11        more data.
     12
     13        * Modules/mediasource/SourceBuffer.cpp:
     14        (WebCore::SourceBuffer::appendBufferInternal):
     15
    1162021-04-05  Chris Dumez  <cdumez@apple.com>
    217

  • trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp

    r274390 r275466  
    491491    m_private->evictCodedFrames(size, m_pendingAppendData.capacity(), maximumBufferSize(), m_source->currentTime(), m_source->duration(), m_source->isEnded());
    492492
    493     // FIXME: enable this code when MSE libraries have been updated to support it.
    494 #if USE(GSTREAMER)
    495493    // 5. If the buffer full flag equals true, then throw a QuotaExceededError exception and abort these step.
    496494    if (m_private->bufferFull()) {
    … …  
    498496        return Exception { QuotaExceededError };
    499497    }
    500 #endif
    501498
    502499    // NOTE: Return to 3.2 appendBuffer()
Note: See TracChangeset for help on using the changeset viewer.