Changeset 275477 in webkit

Timestamp:

Apr 5, 2021 7:19:32 PM (3 years ago)

Author:

commit-queue@webkit.org

Message:

WebSocketChannel buffers use memory after going idle (64K wasted on facebook.com
​https://bugs.webkit.org/show_bug.cgi?id=224193

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-04-05
Reviewed by Simon Fraser.

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::processFrame):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/websockets/WebSocketChannel.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-05  Alex Christensen  <achristensen@webkit.org>
+
+        WebSocketChannel buffers use memory after going idle (64K wasted on facebook.com
+        https://bugs.webkit.org/show_bug.cgi?id=224193
+
+        Reviewed by Simon Fraser.
+
+        * Modules/websockets/WebSocketChannel.cpp:
+        (WebCore::WebSocketChannel::processFrame):
+
 2021-04-05  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/Modules/websockets/WebSocketChannel.cpp

@@ -700 +700 @@
     }
 
-    return !m_buffer.isEmpty();
+    if (m_buffer.isEmpty()) {
+        m_buffer.clear();
+        return false;
+    }
+    return true;
 }