Changeset 275531 in webkit


Ignore:
Timestamp:
Apr 6, 2021 10:28:13 AM (3 years ago)
Author:
achristensen@apple.com
Message:

Revert part of crash fix to keep test infrastructure
https://bugs.webkit.org/show_bug.cgi?id=224196

These two tests change the bundle identifier to test what it's like to not be in a test:

http/tests/in-app-browser-privacy/app-bound-domain-gets-app-bound-session.html
http/tests/in-app-browser-privacy/non-app-bound-iframe-under-app-bound-domain-is-app-bound.html

This partial revert of r275486 allows the test to dynamically change whether it's in testing mode.

  • Shared/Cocoa/DefaultWebBrowserChecks.mm:

(WebKit::doesParentProcessHaveITPEnabled):
(WebKit::isParentProcessAFullWebBrowser):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r275530 r275531  
     12021-04-06  Alex Christensen  <achristensen@webkit.org>
     2
     3        Revert part of crash fix to keep test infrastructure
     4        https://bugs.webkit.org/show_bug.cgi?id=224196
     5
     6        These two tests change the bundle identifier to test what it's like to not be in a test:
     7
     8        http/tests/in-app-browser-privacy/app-bound-domain-gets-app-bound-session.html
     9        http/tests/in-app-browser-privacy/non-app-bound-iframe-under-app-bound-domain-is-app-bound.html
     10
     11        This partial revert of r275486 allows the test to dynamically change whether it's in testing mode.
     12
     13        * Shared/Cocoa/DefaultWebBrowserChecks.mm:
     14        (WebKit::doesParentProcessHaveITPEnabled):
     15        (WebKit::isParentProcessAFullWebBrowser):
     16
    1172021-04-06  Peng Liu  <peng.liu6@apple.com>
    218
  • trunk/Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm

    r275486 r275531  
    164164    ASSERT(RunLoop::isMain());
    165165
     166    if (!isParentProcessAFullWebBrowser(auxiliaryProcess) && !hasRequestedCrossWebsiteTrackingPermission)
     167        return true;
     168
    166169    static bool itpEnabled { true };
    167170    static dispatch_once_t once;
    168171    dispatch_once(&once, ^{
    169         if (!isParentProcessAFullWebBrowser(auxiliaryProcess) && !hasRequestedCrossWebsiteTrackingPermission)
    170             return;
    171172
    172173        TCCAccessPreflightResult result = kTCCAccessPreflightDenied;
     
    235236    static dispatch_once_t once;
    236237    dispatch_once(&once, ^{
    237         if (isRunningTest(WebCore::applicationBundleIdentifier())) {
    238             fullWebBrowser = true;
    239             return;
    240         }
    241 
    242238        RefPtr<IPC::Connection> connection = auxiliaryProcess.parentProcessConnection();
    243239        if (!connection) {
     
    257253    });
    258254
    259     return fullWebBrowser;
     255    return fullWebBrowser || isRunningTest(WebCore::applicationBundleIdentifier());
    260256}
    261257
Note: See TracChangeset for help on using the changeset viewer.