Changeset 275532 in webkit

Timestamp:

Apr 6, 2021 10:54:10 AM (3 years ago)

Author:

Aditya Keerthi

Message:

[iOS] Prevent background blur when presenting date/time pickers
​https://bugs.webkit.org/show_bug.cgi?id=224189
<rdar://problem/76220352>

Reviewed by Wenson Hsieh.

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/ios/forms/WKDateTimeInputControl.mm:

(-[WKDateTimePicker _contextMenuInteraction:styleForMenuWithConfiguration:]):

Presenting a UIContextMenuInteraction results in the application of a
blur effect to the background view. However, the peripheral presented
when interacting with a UIDatePicker across the rest of the system
does not blur the background.

To align our behavior with the rest of the system, remove the blur
effect by specifying an empty UIVisualEffect for the
_UIContextMenuStyle's preferredBackgroundEffects. The empty effect
must be explicitly specified, since setting an empty array will result
in the default effect being applied.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Platform/spi/ios/UIKitSPI.h (modified) (1 diff)
• UIProcess/ios/forms/WKDateTimeInputControl.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-04-06  Aditya Keerthi  <akeerthi@apple.com>
+
+        [iOS] Prevent background blur when presenting date/time pickers
+        https://bugs.webkit.org/show_bug.cgi?id=224189
+        <rdar://problem/76220352>
+
+        Reviewed by Wenson Hsieh.
+
+        * Platform/spi/ios/UIKitSPI.h:
+        * UIProcess/ios/forms/WKDateTimeInputControl.mm:
+        (-[WKDateTimePicker _contextMenuInteraction:styleForMenuWithConfiguration:]):
+
+        Presenting a UIContextMenuInteraction results in the application of a
+        blur effect to the background view. However, the peripheral presented
+        when interacting with a UIDatePicker across the rest of the system
+        does not blur the background.
+
+        To align our behavior with the rest of the system, remove the blur
+        effect by specifying an empty UIVisualEffect for the
+        _UIContextMenuStyle's preferredBackgroundEffects. The empty effect
+        must be explicitly specified, since setting an empty array will result
+        in the default effect being applied.
+
 2021-04-06  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h

@@ -1214 +1214 @@
 @property (nonatomic) _UIContextMenuLayout preferredLayout;
 @property (nonatomic) BOOL hasInteractivePreview;
+@property (nonatomic, strong) NSArray *preferredBackgroundEffects;
 + (instancetype)defaultStyle;
 @end

trunk/Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm

@@ -164 +164 @@
     _UIContextMenuStyle *style = [_UIContextMenuStyle defaultStyle];
     style.hasInteractivePreview = YES;
+    style.preferredBackgroundEffects = @[ [UIVisualEffect emptyEffect] ];
     style.preferredLayout = _UIContextMenuLayoutAutomatic;
     return style;