Changeset 275610 in webkit

Timestamp:

Apr 7, 2021 10:06:09 AM (3 years ago)

Author:

Simon Fraser

Message:

Wasted vector capacity in StyleRuleKeyframes
​https://bugs.webkit.org/show_bug.cgi?id=224264

Reviewed by Antti Koivisto.

Shrink StyleRuleKeyframes::m_keyframes. Saves 23KB on youtube.com.

• css/CSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::shrinkToFit):

• css/CSSKeyframesRule.h:
• css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::consumeKeyframesRule):

• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeAnimationShorthand):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSKeyframesRule.cpp (modified) (1 diff)
• css/CSSKeyframesRule.h (modified) (1 diff)
• css/parser/CSSParserImpl.cpp (modified) (1 diff)
• css/parser/CSSPropertyParser.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-07  Simon Fraser  <simon.fraser@apple.com>
+
+        Wasted vector capacity in StyleRuleKeyframes
+        https://bugs.webkit.org/show_bug.cgi?id=224264
+
+        Reviewed by Antti Koivisto.
+
+        Shrink StyleRuleKeyframes::m_keyframes. Saves 23KB on youtube.com.
+
+        * css/CSSKeyframesRule.cpp:
+        (WebCore::StyleRuleKeyframes::shrinkToFit):
+        * css/CSSKeyframesRule.h:
+        * css/parser/CSSParserImpl.cpp:
+        (WebCore::CSSParserImpl::consumeKeyframesRule):
+        * css/parser/CSSPropertyParser.cpp:
+        (WebCore::CSSPropertyParser::consumeAnimationShorthand):
+
 2021-04-07  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/css/CSSKeyframesRule.cpp

@@ -119 +119 @@
 }
 
+void StyleRuleKeyframes::shrinkToFit()
+{
+    m_keyframes.shrinkToFit();
+}
+
 CSSKeyframesRule::CSSKeyframesRule(StyleRuleKeyframes& keyframesRule, CSSStyleSheet* parent)
     : CSSRule(parent)

trunk/Source/WebCore/css/CSSKeyframesRule.h

@@ -61 +61 @@
     Ref<StyleRuleKeyframes> copy() const { return adoptRef(*new StyleRuleKeyframes(*this)); }
 
+    void shrinkToFit();
+
 private:
     explicit StyleRuleKeyframes(const AtomString&);

trunk/Source/WebCore/css/parser/CSSParserImpl.cpp

@@ -631 +631 @@
     // FIXME-NEWPARSER: Find out why this is done. Behavior difference when prefixed?
     // keyframeRule->setVendorPrefixed(webkitPrefixed);
+    
+    keyframeRule->shrinkToFit();
     return keyframeRule;
 }

trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp

@@ -1669 +1669 @@
                     continue;
 
-                if (RefPtr<CSSValue> value = consumeAnimationValue(shorthand.properties()[i], m_range, m_context)) {
+                if (auto value = consumeAnimationValue(shorthand.properties()[i], m_range, m_context)) {
                     parsedLonghand[i] = true;
                     foundProperty = true;