Changeset 275612 in webkit


Ignore:
Timestamp:
Apr 7, 2021 10:26:03 AM (3 years ago)
Author:
aakash_jain@apple.com
Message:

git-webkit find doesn't work well with unicode characters in author name
https://bugs.webkit.org/show_bug.cgi?id=223686

Reviewed by Jonathan Bedard.

  • Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py:

(Info.main): Added a try except block while printing author, since the script should still print rest of the info.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r275604 r275612  
     12021-04-07  Aakash Jain  <aakash_jain@apple.com>
     2
     3        git-webkit find doesn't work well with unicode characters in author name
     4        https://bugs.webkit.org/show_bug.cgi?id=223686
     5
     6        Reviewed by Jonathan Bedard.
     7
     8        * Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py:
     9        (Info.main): Added a try except block while printing author, since the script should still print rest of the info.
     10
    1112021-04-07  Jonathan Bedard  <jbedard@apple.com>
    212
  • trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py

    r274251 r275612  
    8585        if commit.message:
    8686            print(u'Title: {}'.format(commit.message.splitlines()[0]))
    87         print(u'Author: {}'.format(commit.author))
     87        try:
     88            print(u'Author: {}'.format(commit.author))
     89        except (UnicodeEncodeError, UnicodeDecodeError):
     90            print('Author: ?')
    8891        print(datetime.fromtimestamp(commit.timestamp).strftime('Date: %a %b %d %H:%M:%S %Y'))
    8992        if args.verbose > 0 or commit.revision:
Note: See TracChangeset for help on using the changeset viewer.