Changeset 275678 in webkit

Timestamp:

Apr 8, 2021 2:30:02 PM (3 years ago)

Author:

jiewen_tan@apple.com

Message:

Unreviewed, a comment fix

• crypto/mac/CryptoAlgorithmAES_GCMMac.cpp:

(WebCore::encryptAES_GCM):
(WebCore::decyptAES_GCM):
Removes unnecessary comments.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• crypto/mac/CryptoAlgorithmAES_GCMMac.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-08  Jiewen Tan  <jiewen_tan@apple.com>
+
+        Unreviewed, a comment fix
+
+        * crypto/mac/CryptoAlgorithmAES_GCMMac.cpp:
+        (WebCore::encryptAES_GCM):
+        (WebCore::decyptAES_GCM):
+        Removes unnecessary comments.
+
 2021-04-08  Rob Buis  <rbuis@igalia.com>
 

trunk/Source/WebCore/crypto/mac/CryptoAlgorithmAES_GCMMac.cpp

@@ -38 +38 @@
 static ExceptionOr<Vector<uint8_t>> encryptAES_GCM(const Vector<uint8_t>& iv, const Vector<uint8_t>& key, const Vector<uint8_t>& plainText, const Vector<uint8_t>& additionalData, size_t desiredTagLengthInBytes)
 {
-    // This is a wordaround for rdar://75093377. Force the buffer to be a non null pointer.
     Vector<uint8_t> cipherText(plainText.size() + desiredTagLengthInBytes); // Per section 5.2.1.2: http://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
     Vector<uint8_t> tag(desiredTagLengthInBytes);
@@ -55 +54 @@
 static ExceptionOr<Vector<uint8_t>> decyptAES_GCM(const Vector<uint8_t>& iv, const Vector<uint8_t>& key, const Vector<uint8_t>& cipherText, const Vector<uint8_t>& additionalData, size_t desiredTagLengthInBytes)
 {
-    // This is a wordaround for rdar://75093377. Force the buffer to be a non null pointer.
     Vector<uint8_t> plainText(cipherText.size()); // Per section 5.2.1.2: http://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
     Vector<uint8_t> tag(desiredTagLengthInBytes);
@@ -70 +68 @@
         return Exception { OperationError };
 
-    // This is a wordaround for rdar://75093377. Force the buffer to be a non null pointer.
     plainText.shrink(offset);
     return WTFMove(plainText);