Changeset 28000 in webkit

Timestamp:

Nov 24, 2007 1:52:31 PM (16 years ago)

Author:

alp@webkit.org

Message:

2007-11-24 Christian Dywan <​christian@twotoasts.de>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15793
[GTK] Webkit doesn't show title attribute tooltip when hovering over an image

Implement tooltip support using the new Tooltip API.

Support for older versions of GTK+ is still lacking.

• WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::setToolTip):

Location:

trunk/WebKit/gtk

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/ChromeClientGtk.cpp (modified) (1 diff)

trunk/WebKit/gtk/ChangeLog

@@ +1 @@
+2007-11-24  Christian Dywan  <christian@twotoasts.de>
+
+        Reviewed by Alp Toker.
+
+        http://bugs.webkit.org/show_bug.cgi?id=15793
+        [GTK] Webkit doesn't show title attribute tooltip when hovering over an image
+
+        Implement tooltip support using the new Tooltip API.
+
+        Support for older versions of GTK+ is still lacking.
+
+        * WebCoreSupport/ChromeClientGtk.cpp:
+        (WebKit::ChromeClient::setToolTip):
+
 2007-11-22  Alp Toker  <alp@atoker.com>
 

trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

@@ -284 +284 @@
 }
 
-void ChromeClient::setToolTip(const String&)
-{
-    notImplemented();
+void ChromeClient::setToolTip(const String& toolTip)
+{
+#if GTK_CHECK_VERSION(2,12,0)
+    if (toolTip.isEmpty())
+        g_object_set(G_OBJECT(m_webPage), "has-tooltip", FALSE, NULL);
+    else
+        gtk_widget_set_tooltip_text(GTK_WIDGET(m_webPage), toolTip.utf8().data());
+#else
+    // TODO: Support older GTK+ versions
+    // See http://bugs.webkit.org/show_bug.cgi?id=15793
+    notImplemented();
+#endif
 }