Changeset 28028 in webkit

Timestamp:

Nov 25, 2007 6:12:37 PM (16 years ago)

Author:

mrowe@apple.com

Message:

2007-11-24 Laszlo Gombos <​laszlo.gombos@gmail.com>

Reviewed by Sam Weinig.

Add printf format attribute to several functions. Use the the new WTF_ATTRIBUTE_PRINTF define.

• dom/XMLTokenizer.cpp:
• dom/XMLTokenizer.h:
• platform/DeprecatedString.h:
• platform/PlatformString.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/XMLTokenizer.cpp (modified) (4 diffs)
• dom/XMLTokenizer.h (modified) (1 diff)
• platform/DeprecatedString.h (modified) (1 diff)
• platform/PlatformString.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-11-24  Laszlo Gombos  <laszlo.gombos@gmail.com>
+
+        Reviewed by Sam Weinig.
+
+        Add printf format attribute to several functions. Use the the new WTF_ATTRIBUTE_PRINTF define.
+
+        * dom/XMLTokenizer.cpp:
+        * dom/XMLTokenizer.h:
+        * platform/DeprecatedString.h:
+        * platform/PlatformString.h:
+
 2007-11-25  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/dom/XMLTokenizer.cpp

@@ -1066 +1066 @@
 }
 
+WTF_ATTRIBUTE_PRINTF(2, 3)
 static void warningHandler(void* closure, const char* message, ...)
 {
@@ -1074 +1075 @@
 }
 
+WTF_ATTRIBUTE_PRINTF(2, 3)
 static void fatalErrorHandler(void* closure, const char* message, ...)
 {
@@ -1082 +1084 @@
 }
 
+WTF_ATTRIBUTE_PRINTF(2, 3)
 static void normalErrorHandler(void* closure, const char* message, ...)
 {
@@ -1551 +1554 @@
 }
 
+WTF_ATTRIBUTE_PRINTF(2, 3)
 static void balancedWarningHandler(void* closure, const char* message, ...)
 {

trunk/WebCore/dom/XMLTokenizer.h

@@ -85 +85 @@
 #ifndef USE_QXMLSTREAM
         // callbacks from parser SAX
-        void error(ErrorType, const char* message, va_list args);
+        void error(ErrorType, const char* message, va_list args) WTF_ATTRIBUTE_PRINTF(3, 0); 
         void startElementNs(const xmlChar* xmlLocalName, const xmlChar* xmlPrefix, const xmlChar* xmlURI, int nb_namespaces,
                             const xmlChar** namespaces, int nb_attributes, int nb_defaulted, const xmlChar** libxmlAttributes);

trunk/WebCore/platform/DeprecatedString.h

@@ -386 +386 @@
     DeprecatedString &setNum(double);
 
-    DeprecatedString& format(const char *, ...) 
-#if __GNUC__
-    __attribute__ ((format (printf, 2, 3)))
-#endif
-    ;
+    DeprecatedString& format(const char *, ...) WTF_ATTRIBUTE_PRINTF(2, 3);
 
     DeprecatedString &append(const DeprecatedString &);

trunk/WebCore/platform/PlatformString.h

@@ -134 +134 @@
     static String number(double);
     
-    static String format(const char *, ...)
-#if __GNUC__
-        __attribute__ ((format (printf, 1, 2)))
-#endif
-        ;
+    static String format(const char *, ...) WTF_ATTRIBUTE_PRINTF(1, 2);
 
     Vector<String> split(const String& separator, bool allowEmptyEntries = false) const;