Changeset 28300 in webkit


Ignore:
Timestamp:
Dec 1, 2007 8:41:55 AM (16 years ago)
Author:
mrowe@apple.com
Message:

2007-12-01 Rahul Abrol <ra5ul@comcast.net>

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=16128
Ignore resizable=no for window.open().

  • bindings/js/kjs_window.cpp: (KJS::setWindowFeature): (KJS::parseWindowFeatures):
  • manual-tests/window-open-features-parsing.html:
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r28299 r28300  
     12007-12-01  Rahul Abrol  <ra5ul@comcast.net>
     2
     3        Reviewed by Adam Roben.
     4
     5        http://bugs.webkit.org/show_bug.cgi?id=16128
     6        Ignore resizable=no for window.open().
     7
     8        * bindings/js/kjs_window.cpp:
     9        (KJS::setWindowFeature):
     10        (KJS::parseWindowFeatures):
     11        * manual-tests/window-open-features-parsing.html:
     12
    1132007-12-01  Dan Bernstein  <mitz@apple.com>
    214
  • trunk/WebCore/bindings/js/kjs_window.cpp

    r28225 r28300  
    10731073    else
    10741074        value = valueString.toInt();
    1075    
     1075
     1076    // We ignore a keyString of "resizable", which is consistent with Firefox.
    10761077    if (keyString == "left" || keyString == "screenx") {
    10771078        windowFeatures.xSet = true;
     
    10941095    else if (keyString == "status")
    10951096        windowFeatures.statusBarVisible = value;
    1096     else if (keyString == "resizable")
    1097         windowFeatures.resizable = value;
    10981097    else if (keyString == "fullscreen")
    10991098        windowFeatures.fullscreen = value;
     
    11161115     
    11171116     <http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/open_0.asp>
     1117     We always allow a window to be resized, which is consistent with Firefox.
    11181118     */
    11191119   
     
    11421142    windowFeatures.locationBarVisible = false;
    11431143    windowFeatures.scrollbarsVisible = false;
    1144     windowFeatures.resizable = false;
     1144    windowFeatures.resizable = true;
    11451145   
    11461146    // Tread lightly in this code -- it was specifically designed to mimic Win IE's parsing behavior.
  • trunk/WebCore/manual-tests/window-open-features-parsing.html

    r17631 r28300  
    77        - left: reads as key:left value:no, which means 0, which means aligned to the left side of the screen
    88        - \ntoolBAR: reads as key:toolbar value:yes
    9         - resizable: reads as key:resizable value:yess, which is invalid, which means no
    109        - \rstatus: reads as key:status value:"", which means yes
    1110        - the trailing comma catches a previous mistake i made reading past the end of the string
    1211    */   
    13     var sFeatures = "   ,=\twidth ==    = =     0200px|0=height  400,1width=400,left=nO \ntoolBAR=yeS,resizable=yess, \rstatus= ,";
     12    var sFeatures = "   ,=\twidth ==    = =     0200px|0=height  400,1width=400,left=nO \ntoolBAR=yeS, \rstatus= ,";
    1413    var w = window.open("resources/popup200x100.html", undefined, sFeatures);
    1514    w.focus();
     
    1716</script></head>
    1817<body>
    19 <p>This test checks whether parsing of the 'features' argument to window.open matches Win IE's behavior.</p>
     18<p>This test checks whether parsing of the 'features' argument to window.open
     19  matches Win IE's behavior (excepting resizable).</p>
    2020<p>The link below should open a window with the following attributes:</p>
    2121<ul>
     
    2424<li> Toolbar visible.
    2525<li> Statusbar visible.
    26 <li> Not resizable.
     26<li> Resizable (always).
    2727</ul>
    2828<a href="" onclick="test(); return false;">Click to test</a>
Note: See TracChangeset for help on using the changeset viewer.