Changeset 28300 in webkit
- Timestamp:
- Dec 1, 2007 8:41:55 AM (16 years ago)
- Location:
- trunk/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r28299 r28300 1 2007-12-01 Rahul Abrol <ra5ul@comcast.net> 2 3 Reviewed by Adam Roben. 4 5 http://bugs.webkit.org/show_bug.cgi?id=16128 6 Ignore resizable=no for window.open(). 7 8 * bindings/js/kjs_window.cpp: 9 (KJS::setWindowFeature): 10 (KJS::parseWindowFeatures): 11 * manual-tests/window-open-features-parsing.html: 12 1 13 2007-12-01 Dan Bernstein <mitz@apple.com> 2 14 -
trunk/WebCore/bindings/js/kjs_window.cpp
r28225 r28300 1073 1073 else 1074 1074 value = valueString.toInt(); 1075 1075 1076 // We ignore a keyString of "resizable", which is consistent with Firefox. 1076 1077 if (keyString == "left" || keyString == "screenx") { 1077 1078 windowFeatures.xSet = true; … … 1094 1095 else if (keyString == "status") 1095 1096 windowFeatures.statusBarVisible = value; 1096 else if (keyString == "resizable")1097 windowFeatures.resizable = value;1098 1097 else if (keyString == "fullscreen") 1099 1098 windowFeatures.fullscreen = value; … … 1116 1115 1117 1116 <http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/open_0.asp> 1117 We always allow a window to be resized, which is consistent with Firefox. 1118 1118 */ 1119 1119 … … 1142 1142 windowFeatures.locationBarVisible = false; 1143 1143 windowFeatures.scrollbarsVisible = false; 1144 windowFeatures.resizable = false;1144 windowFeatures.resizable = true; 1145 1145 1146 1146 // Tread lightly in this code -- it was specifically designed to mimic Win IE's parsing behavior. -
trunk/WebCore/manual-tests/window-open-features-parsing.html
r17631 r28300 7 7 - left: reads as key:left value:no, which means 0, which means aligned to the left side of the screen 8 8 - \ntoolBAR: reads as key:toolbar value:yes 9 - resizable: reads as key:resizable value:yess, which is invalid, which means no10 9 - \rstatus: reads as key:status value:"", which means yes 11 10 - the trailing comma catches a previous mistake i made reading past the end of the string 12 11 */ 13 var sFeatures = " ,=\twidth == = = 0200px|0=height 400,1width=400,left=nO \ntoolBAR=yeS, resizable=yess,\rstatus= ,";12 var sFeatures = " ,=\twidth == = = 0200px|0=height 400,1width=400,left=nO \ntoolBAR=yeS, \rstatus= ,"; 14 13 var w = window.open("resources/popup200x100.html", undefined, sFeatures); 15 14 w.focus(); … … 17 16 </script></head> 18 17 <body> 19 <p>This test checks whether parsing of the 'features' argument to window.open matches Win IE's behavior.</p> 18 <p>This test checks whether parsing of the 'features' argument to window.open 19 matches Win IE's behavior (excepting resizable).</p> 20 20 <p>The link below should open a window with the following attributes:</p> 21 21 <ul> … … 24 24 <li> Toolbar visible. 25 25 <li> Statusbar visible. 26 <li> Not resizable.26 <li> Resizable (always). 27 27 </ul> 28 28 <a href="" onclick="test(); return false;">Click to test</a>
Note: See TracChangeset
for help on using the changeset viewer.