Changeset 28345 in webkit

Timestamp:

Dec 3, 2007 4:57:14 AM (16 years ago)

Author:

alp@webkit.org

Message:

2007-12-03 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Don't delete the decoder if it's already been created. The one we have
is fine.

Cairo image cleanups. Nothing substantial.

Notify ImageObservers where appropriate.

• platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):
• platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::setData):
• platform/graphics/gtk/ImageGtk.cpp:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cairo/ImageCairo.cpp (modified) (6 diffs)
• platform/graphics/cairo/ImageSourceCairo.cpp (modified) (1 diff)
• platform/graphics/gtk/ImageGtk.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-12-03  Alp Toker  <alp@atoker.com>
+
+        Reviewed by Mark Rowe.
+
+        Don't delete the decoder if it's already been created. The one we have
+        is fine.
+
+        Cairo image cleanups. Nothing substantial.
+
+        Notify ImageObservers where appropriate.
+
+        * platform/graphics/cairo/ImageCairo.cpp:
+        (WebCore::BitmapImage::draw):
+        (WebCore::Image::drawPattern):
+        * platform/graphics/cairo/ImageSourceCairo.cpp:
+        (WebCore::ImageSource::setData):
+        * platform/graphics/gtk/ImageGtk.cpp:
+
 2007-12-03  Simon Hausmann  <hausmann@webkit.org>
 

trunk/WebCore/platform/graphics/cairo/ImageCairo.cpp

@@ -33 +33 @@
 #include "FloatRect.h"
 #include "GraphicsContext.h"
+#include "ImageObserver.h"
 #include <cairo.h>
 #include <math.h>
@@ -48 +49 @@
 }
 
-// ================================================
-// Image Class
-// ================================================
-
-// Drawing Routines
-
 void BitmapImage::draw(GraphicsContext* context, const FloatRect& dst, const FloatRect& src, CompositeOperator op)
 {
-    cairo_t* cr = context->platformContext();
-
     if (!m_source.initialized())
         return;
+
+    FloatRect srcRect(src);
+    FloatRect dstRect(dst);
 
     cairo_surface_t* image = frameAtIndex(m_currentFrame);
@@ -65 +61 @@
         return;
 
+    if (mayFillWithSolidColor()) {
+        fillWithSolidColor(context, dstRect, solidColor(), op);
+        return;
+    }
+
     IntSize selfSize = size();
-    FloatRect srcRect(src);
-    FloatRect dstRect(dst);
 
+    cairo_t* cr = context->platformContext();
     cairo_save(cr);
 
@@ -90 +90 @@
     float scaleX = srcRect.width() / dstRect.width();
     float scaleY = srcRect.height() / dstRect.height();
-    cairo_matrix_t matrix = { scaleX,  0, 0 , scaleY, srcRect.x(), srcRect.y() };
+    cairo_matrix_t matrix = { scaleX, 0, 0, scaleY, srcRect.x(), srcRect.y() };
     cairo_pattern_set_matrix(pattern, &matrix);
 
@@ -96 +96 @@
     cairo_translate(cr, dstRect.x(), dstRect.y());
     cairo_set_source(cr, pattern);
+    cairo_pattern_destroy(pattern);
     cairo_rectangle(cr, 0, 0, dstRect.width(), dstRect.height());
     cairo_fill(cr);
 
-    cairo_pattern_destroy(pattern);
     cairo_restore(cr);
 
     startAnimation();
+
+    if (imageObserver())
+        imageObserver()->didDraw(this);
 }
 
@@ -132 +135 @@
     context->setCompositeOperation(op);
     cairo_set_source(cr, pattern);
+    cairo_pattern_destroy(pattern);
     cairo_rectangle(cr, destRect.x(), destRect.y(), destRect.width(), destRect.height());
     cairo_fill(cr);
 
-    cairo_pattern_destroy(pattern);
     context->restore();
+
+    if (imageObserver())
+        imageObserver()->didDraw(this);
 }
 

trunk/WebCore/platform/graphics/cairo/ImageSourceCairo.cpp

@@ -113 +113 @@
     // If insufficient bytes are available to determine the image type, no decoder plugin will be
     // made.
-    delete m_decoder;
-    m_decoder = createDecoder(data->buffer());
+    if (!m_decoder)
+        m_decoder = createDecoder(data->buffer());
+
     if (!m_decoder)
         return;
+
     m_decoder->setData(data, allDataReceived);
 }

trunk/WebCore/platform/graphics/gtk/ImageGtk.cpp

@@ -25 +25 @@
 
 #include "config.h"
-#include "Image.h"
 
 #include "BitmapImage.h"
+#include "Image.h"
 #include "NotImplemented.h"
-#include <cairo.h>
- 
+
 // This function loads resources from WebKit
 Vector<char> loadResourceIntoArray(const char*);