Changeset 29032 in webkit

Timestamp:

Dec 29, 2007 4:33:20 PM (16 years ago)

Author:

Darin Adler

Message:

Reviewed by Oliver.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=16663 leak bot shows createCStringFromNPVariant result leaking

• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke): Added a missing free.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2007-12-29  Darin Adler  <darin@apple.com>
+
+        Reviewed by Oliver.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=16663
+          leak bot shows createCStringFromNPVariant result leaking
+
+        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
+        (pluginInvoke): Added a missing free.
+
 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
 

trunk/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp

@@ -337 +337 @@
         for (uint32_t i = 0; i < argCount; i++) {
             assert(NPVARIANT_IS_STRING(args[i]));
-            char *propertyString = createCStringFromNPVariant(&args[i]);
+            NPUTF8* propertyString = createCStringFromNPVariant(&args[i]);
             NPIdentifier propertyIdentifier = browser->getstringidentifier(propertyString);
+            free(propertyString);
             
             NPVariant variant;