Changeset 29061 in webkit

Timestamp:

Jan 1, 2008 2:40:57 AM (16 years ago)

Author:

eric@webkit.org

Message:

Reviewed by Alexey.

Don't replace \ with / in data: urls
​http://bugs.webkit.org/show_bug.cgi?id=16692

Test: fast/loader/url-data-replace-backslash.html

• platform/KURL.cpp: (WebCore::KURL::init):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/loader/url-data-replace-backslash-expected.txt (added)
• LayoutTests/fast/loader/url-data-replace-backslash.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/KURL.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-01-01  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Alexey.
+        
+        Don't replace \ with / in data: urls
+        http://bugs.webkit.org/show_bug.cgi?id=16692
+
+        * fast/loader/url-data-replace-backslash-expected.txt: Added.
+        * fast/loader/url-data-replace-backslash.html: Added.
+
 2007-12-31  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-01-01  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Alexey.
+
+        Don't replace \ with / in data: urls
+        http://bugs.webkit.org/show_bug.cgi?id=16692
+
+        Test: fast/loader/url-data-replace-backslash.html
+
+        * platform/KURL.cpp:
+        (WebCore::KURL::init):
+
 2008-01-01  Alp Toker  <alp@atoker.com>
 

trunk/WebCore/platform/KURL.cpp

@@ -286 +286 @@
     // for compatibility with Win IE, we must treat backslashes as if they were slashes, as long as we're not dealing with the javascript: schema
     DeprecatedString substitutedRelative;
-    bool shouldSubstituteBackslashes = relative.contains('\\') && !relative.startsWith("javascript:", false);
-    if (shouldSubstituteBackslashes) {
+    bool shouldSubstituteBackslashes = relative.contains('\\') && !(relative.startsWith("javascript:", false) || relative.startsWith("data:", false));
+    if (shouldSubstituteBackslashes)
         substitutedRelative = substituteBackslashes(relative);
-    }
 
     const DeprecatedString &rel = shouldSubstituteBackslashes ? substitutedRelative : relative;