Changeset 29204 in webkit

Timestamp:

Jan 6, 2008 12:13:43 AM (16 years ago)

Author:

eric@webkit.org

Message:

Reviewed by Sam.

Fix :checked matching type='text' and add test case
​http://bugs.webkit.org/show_bug.cgi?id=16750

Test: fast/dom/HTMLInputElement/checked-pseudo-selector.html

• html/HTMLInputElement.h: isChecked() can only be true for RADIO or CHECKBOX

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/HTMLInputElement/checked-pseudo-selector-expected.txt (added)
• LayoutTests/fast/dom/HTMLInputElement/checked-pseudo-selector.html (added)
• LayoutTests/fast/dom/HTMLInputElement/resources/TEMPLATE.html (added)
• LayoutTests/fast/dom/HTMLInputElement/resources/checked-pseudo-selector.js (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLInputElement.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-01-06  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Sam.
+
+        Fix :checked matching type='text' and add test case
+        http://bugs.webkit.org/show_bug.cgi?id=16750
+
+        * fast/dom/HTMLInputElement/checked-pseudo-selector-expected.txt: Added.
+        * fast/dom/HTMLInputElement/checked-pseudo-selector.html: Added.
+        * fast/dom/HTMLInputElement/resources/TEMPLATE.html: Added.
+        * fast/dom/HTMLInputElement/resources/checked-pseudo-selector.js: Added.
+
 2008-01-05  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-01-06  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Sam.
+
+        Fix :checked matching type='text' and add test case
+        http://bugs.webkit.org/show_bug.cgi?id=16750
+
+        Test: fast/dom/HTMLInputElement/checked-pseudo-selector.html
+
+        * html/HTMLInputElement.h: isChecked() can only be true for RADIO or CHECKBOX
+
 2008-01-05  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/html/HTMLInputElement.h

@@ -71 +71 @@
     bool autoComplete() const { return m_autocomplete; }
 
-    virtual bool isChecked() const { return checked(); }
+    // isChecked is used by the rendering tree/CSS while checked() is used by JS to determine checked state
+    virtual bool isChecked() const { return checked() && (inputType() == CHECKBOX || inputType() == RADIO); }
     virtual bool isIndeterminate() const { return indeterminate(); }