Changeset 29311 in webkit


Ignore:
Timestamp:
Jan 8, 2008 11:52:24 AM (16 years ago)
Author:
ap@webkit.org
Message:

Reviewed by Darin.

<rdar://problem/5659812> CrashTracer: 462 crashes in Safari at com.apple.WebCore:
WebCore::Node::setChanged + 96

Test: fast/dom/cssTarget-crash.html

  • dom/Node.cpp: (WebCore::Node::removedFromDocument): Check to see if the node being removed is currently set as the Document's cssTarget.

Ê Ê Ê Ê If it is, clear the cssTarget to prevent a hanging reference to it.

Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r29306 r29311  
     12008-01-08  Alexey Proskuryakov  <ap@webkit.org>
     2
     3        Reviewed by Darin.
     4
     5        <rdar://problem/5659812> CrashTracer: 462 crashes in Safari at com.apple.WebCore:
     6        WebCore::Node::setChanged + 96
     7
     8        * fast/dom/cssTarget-crash-expected.txt: Added.
     9        * fast/dom/cssTarget-crash.html: Added.
     10
    1112008-01-08  Anders Carlsson  <andersca@apple.com>
    212
  • trunk/WebCore/ChangeLog

    r29310 r29311  
     12008-01-08  Alexey Proskuryakov  <ap@webkit.org>
     2
     3        Reviewed by Darin.
     4
     5        <rdar://problem/5659812> CrashTracer: 462 crashes in Safari at com.apple.WebCore:
     6        WebCore::Node::setChanged + 96
     7
     8        Test: fast/dom/cssTarget-crash.html
     9
     10        * dom/Node.cpp: (WebCore::Node::removedFromDocument):
     11        Check to see if the node being removed is currently set as the Document's cssTarget.
     12Ê Ê Ê Ê If it is, clear the cssTarget to prevent a hanging reference to it.
     13
    1142008-01-08  Adam Roben  <aroben@apple.com>
    215
  • trunk/WebCore/dom/Node.cpp

    r29054 r29311  
    848848void Node::removedFromDocument()
    849849{
     850    if (m_document && m_document->getCSSTarget() == this)
     851        m_document->setCSSTarget(0);
     852
    850853    setInDocument(false);
    851854    removedFromTree(false);
Note: See TracChangeset for help on using the changeset viewer.